iotivity.git
6 months ago[IOT-2359][IOT-2360][IOT-2364] Separate provisioning with DOS 87/20387/9 1.3.0
Dmitriy Zhuravlev [Thu, 25 May 2017 12:03:12 +0000 (15:03 +0300)]
[IOT-2359][IOT-2360][IOT-2364] Separate provisioning with DOS

Restore functions removed in https://gerrit.iotivity.org/gerrit/#/c/19931/
Add NULL checking for pDev2 in SRPProvisionCredentialsDos

Change-Id: Icf3397247478c97c7029380aadcaa5dd89b42870
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20387
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agochecking on empty host case in OCResource::setHost(). 91/20391/2
Ziran Sun [Thu, 25 May 2017 12:53:36 +0000 (13:53 +0100)]
checking on empty host case in OCResource::setHost().

Change-Id: Ia3cb2fb34e6b64ad4a5874bf49045550f4c5426c
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20391
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoIOT-2204: Fix IPCA build warnings on Linux. 67/20367/5
Soemin Tjong [Wed, 24 May 2017 17:49:59 +0000 (10:49 -0700)]
IOT-2204: Fix IPCA build warnings on Linux.

A couple of warnings didn't get fixed earlier.

resource/IPCA/src/ocfframework.cpp:237:17: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
resource/IPCA/src/ocfframework.cpp:255:17: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]

Change-Id: Id901213b83a45a0f6798d7f2b8c501339b7af71c
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20367
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months ago[IOT-2357] Platform error messages 81/20381/3
Ibrahim Esmat [Thu, 25 May 2017 00:32:20 +0000 (17:32 -0700)]
[IOT-2357] Platform error messages

Update expected WARNING/ERROR messages to be INFO when trying to
get the local application data path.

Change-Id: I434f12f0183261e38cc14d6b37a05618690e736d
Signed-off-by: Ibrahim Esmat <iesmat@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20381
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months ago[IOT-2362] Fix OT for sampleserver_mfg 93/20393/3
ol.beketov [Thu, 25 May 2017 13:27:44 +0000 (16:27 +0300)]
[IOT-2362] Fix OT for sampleserver_mfg

.dat and .json from resource/provisioning/examples
updated with cred field

Change-Id: I3f5e5ecbd3e08fda30762fb4b5ca57a4cad84d3c
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20393
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2368] fix JNI crash issue for client terminate 95/20395/2
jihwan.seo [Thu, 25 May 2017 13:30:58 +0000 (22:30 +0900)]
[IOT-2368] fix JNI crash issue for client terminate

Change-Id: Ibc28948afc01f5a905d7cbd4f5bcac0772d270c7
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20395
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months ago[IOT-2369] check the start flag when ip adapter is enabled 89/20389/3
hyuna0213.jo [Thu, 25 May 2017 12:34:37 +0000 (21:34 +0900)]
[IOT-2369] check the start flag when ip adapter is enabled

Change-Id: I4fff403f809931b1bd2d4c49ea087b07d498333d
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20389
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Masud Bhuiyan <m.parves@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months ago[IOT-1943] updated .json and .dat in /csdk/stack/samples/linux/secure 67/20267/2
Nathan Heldt-Sheller [Mon, 22 May 2017 17:54:48 +0000 (10:54 -0700)]
[IOT-1943] updated .json and .dat in /csdk/stack/samples/linux/secure

These are being referenced as examples in addition to the files
in /csdk/security/provisioning/samples and so must be updated.

Please include these updates in 1.3.0 to avoid creating additional
bad .json and .dat files based off these.

Change-Id: I9f54988c1fb2914a2b63b7d4887edef99e27f440
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20267
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agofixed testcase for creating mongodb in account 57/20357/2
Jung Seungho [Wed, 24 May 2017 08:16:16 +0000 (17:16 +0900)]
fixed testcase for creating mongodb in account

Change-Id: Ic391d7315225d04fd39a414d1400c2b8f5d24178
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20357
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Tested-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
6 months agoFix invalid test case code 55/20355/3
Jee Hyeok Kim [Wed, 24 May 2017 02:33:19 +0000 (11:33 +0900)]
Fix invalid test case code

1. Fix test case regarding changed framework

Change-Id: I13eadf1143e7118ba6d55416aa14d5c6838455c3
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20355

6 months agoFix a crash error on AccountManager APIs 53/20353/3
Jaewook Jung [Wed, 24 May 2017 01:54:14 +0000 (10:54 +0900)]
Fix a crash error on AccountManager APIs

Fix a crash error occurred when throwing jni exception.

Change-Id: I941b0f90c62e7965bd112f27061c4835e5e3a9bc
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20353
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix TLSAdapter unit tests in RC3 25/20325/6
ol.beketov [Tue, 23 May 2017 16:49:55 +0000 (19:49 +0300)]
Fix TLSAdapter unit tests in RC3

Change-Id: I4cf4a6a01c64e8e455e51a3fca88e512b516e60c
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20325
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoIOT-2351 CA: Parse all interfaces 37/20337/3
Dan Mihai [Tue, 23 May 2017 20:49:32 +0000 (13:49 -0700)]
IOT-2351 CA: Parse all interfaces

The local variable interfaces gets decremented during the loop,
but the entire iflist has to be parsed.

Fixes new test errors that started on my machine with recent change
e3a3f65569f15fdf711c9d0a3123e6951f6499ba :

[ RUN      ] CATests.GetNetworkInformationTest
resource\csdk\connectivity\test\ca_api_unittest.cpp(517): error:
Value of: tempInfo[index].adapter != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(518): error:
Value of: strlen(tempInfo[index].addr) != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(517): error:
Value of: tempInfo[index].adapter != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(518): error:
Value of: strlen(tempInfo[index].addr) != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(517): error:
Value of: tempInfo[index].adapter != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(518): error:
Value of: strlen(tempInfo[index].addr) != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(517): error: Value of:
tempInfo[index].adapter != 0
  Actual: false
Expected: true
resource\csdk\connectivity\test\ca_api_unittest.cpp(518): error: Value of:
strlen(tempInfo[index].addr) != 0
  Actual: false
Expected: true
[  FAILED  ] CATests.GetNetworkInformationTest (5 ms)

Change-Id: If3a74a0739be6a53373f8b25436a50304029d751
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20337
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2340] Added NULL check for 'pdu->transport_hdr' 15/20315/2
arya.k [Tue, 23 May 2017 10:07:50 +0000 (15:37 +0530)]
[IOT-2340] Added NULL check for 'pdu->transport_hdr'

Change-Id: Id8c6c86421f156cad612417c70aa58064b3ab5ad
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20315
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2314] De-reference pResponse done after null check. 19/20319/3
Sushil Yadav [Tue, 23 May 2017 10:34:20 +0000 (16:04 +0530)]
[IOT-2314] De-reference pResponse done after null check.

In InProcServerWrapper::sendReponse() pResponse tries to dereference before
checking for the null. The bug was introduced for as part of IOT-1583.
Change-Id: Ic4ec8a08d3934d698af493703de1966b78702dba
Signed-off-by: Sushil Yadav <sushil.ky@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20319
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2300] Call callback when delete roles resource 69/20269/3 mbedtls 1.3.0-RC3
Greg Zaverucha [Mon, 22 May 2017 18:26:06 +0000 (11:26 -0700)]
[IOT-2300] Call callback when delete roles resource

When deleteting roles with OCDeleteRoleCertificateByCredId, the
callback provided by the caller was not being called.

Change-Id: I51da5fe61760ff5561fd676e5c220905f106f512
Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20269
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2113] Change the logic not to delete double time 31/19631/3
ol.beketov [Thu, 4 May 2017 13:59:56 +0000 (16:59 +0300)]
[IOT-2113] Change the logic not to delete double time

Change-Id: I56923e53e9b81da45b9ff9e50e7df9cdde233c25
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19631
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2342] Fix a crash issue on secureresourcemanager.c 97/20297/3
Jaewook Jung [Tue, 23 May 2017 05:26:46 +0000 (14:26 +0900)]
[IOT-2342] Fix a crash issue on secureresourcemanager.c

Add null checking for a resource object which could be NULL if server
receives a request message including resource uri which server doesn't
have.

Change-Id: Idf29a43aeca5a919c0b22d3f0cd9ce507c8935ab
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20297
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix compile error with g++ 6.3.1 and RD unit tests. 63/20263/2
Todd Malsbary [Mon, 22 May 2017 16:11:45 +0000 (09:11 -0700)]
Fix compile error with g++ 6.3.1 and RD unit tests.

gtest.h: In instantiation of 'testing::AssertionResult \
    testing::internal::CmpHelperNE(const char*, const char*, const \
    T1&, const T2&) [with T1 = long int; T2 = char*]':
rddatabase.cpp:126:9:   required from here
gtest.h:1577:28: error: ISO C++ forbids comparison between pointer \
    and integer [-fpermissive]

Change-Id: I6e5a2863fc6d45dffb5bc61526ae9f786eb1c638
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20263
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2322][CHP][SampleApp] Coap http proxy is not working in secured mode 57/20257/8
Veeraj Khokale [Tue, 23 May 2017 04:31:01 +0000 (13:31 +0900)]
[IOT-2322][CHP][SampleApp] Coap http proxy is not working in secured mode

1. Update dat files for proxy samples to be same as linux
   secure samples.
2. Modify logic to form server address according to linux
   secure samples while initiating proxy request.
3. Since request URI is NULL for proxy request check this
   condition before asserting role certificates in OCDoRequest().
   This also removes the need for NULL check of request info
   resource uri.

Change-Id: I20003ac7c7781666bbd4aa8955c4cc18b5a3262f
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: uzchoi <uzchoi@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20257
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
6 months ago[IOT-2303] Modify comment to OCProvisionCredentials 01/20101/2
Jongmin Choi [Fri, 19 May 2017 07:35:28 +0000 (16:35 +0900)]
[IOT-2303] Modify comment to OCProvisionCredentials

IOT-2303. Comment modified to show optional parameter

Change-Id: Iae07f2496ca3295d569ab0653afc8b61b0643605
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20101
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2344] Use correct index when checking for alloc failure. 71/20271/2
Todd Malsbary [Mon, 22 May 2017 18:45:40 +0000 (11:45 -0700)]
[IOT-2344] Use correct index when checking for alloc failure.

dimensions[0] and i may be different values.  The urlInfo is allocated
to dimensions[0] but checked against i.

Bug: https://jira.iotivity.org/browse/IOT-2344
Change-Id: Ibff3fc62d551417a71e7496027452b3d88cad413
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20271
Reviewed-by: Srikrishna Gurugubelli <srikguru@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
6 months agoFix build warning on RE. 27/20227/4
KIM JungYong [Mon, 22 May 2017 08:54:28 +0000 (17:54 +0900)]
Fix build warning on RE.

When RE build as Tizen, one of defination was redefined.
In this patch, defination tag is changed.

Change-Id: Ice25e9907481f66dac4b8a1e0aeb535120c936f0
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20227
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2063] Enable endpoints filtering in CAIPGetInterfaceInformation() 21/19821/17
hyuna0213.jo [Tue, 23 May 2017 04:03:48 +0000 (13:03 +0900)]
[IOT-2063] Enable endpoints filtering in CAIPGetInterfaceInformation()

https://gerrit.iotivity.org/gerrit/#/c/19355/ was modified to make
changes for all platforms.

Change-Id: Ib653daaad453556354b108c673b34c06a197c5f9
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19821
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agoRemove a build warning in Easy setup for Android build 43/20243/2
Jihun Ha [Mon, 22 May 2017 10:22:41 +0000 (19:22 +0900)]
Remove a build warning in Easy setup for Android build

* Change minSdkVersion to 21 in AndroidManifest.xml
* Change target source files for jni build ONLY to cpp files

Change-Id: Ic45acb59d66d30c991514a2bec38583c0e7f1550
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20243
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2175] Fix regression with optional 'pri' property. 61/20261/2
Todd Malsbary [Mon, 22 May 2017 16:01:10 +0000 (09:01 -0700)]
[IOT-2175] Fix regression with optional 'pri' property.

The checks added in commit 6758c572ecfa068d953bd3d5ed9614885dae01b1
made 'pri' mandatory again.

Bug: https://jira.iotivity.org/browse/IOT-2175
Change-Id: Idb6137f45bf06910a9789f23c87486df2289abca
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20261
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix provisioning unit tests 47/20247/3
Oleksandr Dmytrenko [Mon, 22 May 2017 10:58:28 +0000 (13:58 +0300)]
Fix provisioning unit tests

Update test due to DOS enabling

Change-Id: I9f0c4b0b01ee3fe79a2126cd580cca4e6d374afd
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20247
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2302] Don't assert roles for KeepAlive 17/20217/6
hyuna0213.jo [Mon, 22 May 2017 11:29:46 +0000 (20:29 +0900)]
[IOT-2302] Don't assert roles for KeepAlive

Remove assert role in case of TCP KeepAlive

Patch #1: initial upload

Bug: https://jira.iotivity.org/browse/IOT-2302
Change-Id: If99610a3a302357aa33ac0d1466219e78fdd01fa
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20217
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2330] fix block issue related rfcomm accept logic 23/20223/5
jihwan.seo [Mon, 22 May 2017 07:58:44 +0000 (16:58 +0900)]
[IOT-2330] fix block issue related rfcomm accept logic

Change-Id: I79f62fdd362542f1dc05cb77f986e34587c422e0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20223
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agoFilter out an exceptional case if a response payload of discovery is NULL 45/20245/2
Jihun Ha [Mon, 22 May 2017 10:58:53 +0000 (19:58 +0900)]
Filter out an exceptional case if a response payload of discovery is NULL

If a response payload of discovery is NULL, which means discovery request
is failed for some reason, it should not proceed a further operation.
Only if a result of discovery request is OK, GET/PUT/POST requests can be
performed, further.

Change-Id: I95e79038dfae5e455f61db89aa9c7f3a724cee29
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20245
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months agoIOT-2274 : Json2Cbor support for swagger files - introspection 41/19541/6
Srikrishna Gurugubelli [Fri, 19 May 2017 23:46:07 +0000 (16:46 -0700)]
IOT-2274 : Json2Cbor support for swagger files - introspection

Change-Id: I0ae46770b08fb6b8c2d632189a060dc14e0e94c0
Signed-off-by: Srikrishna Gurugubelli <srikguru@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19541
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2205] g_sslContextMutex synchronization improvements 33/19633/6
Dan Mihai [Thu, 4 May 2017 13:24:20 +0000 (06:24 -0700)]
[IOT-2205] g_sslContextMutex synchronization improvements

Change-Id: Ib5e6df4e02da583e086a07591ef1e35f367ae4f0
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19633
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoIOT-1828 Add oc_mutex_new_recursive 05/19605/5
Way Vadhanasin [Thu, 27 Apr 2017 18:31:13 +0000 (11:31 -0700)]
IOT-1828 Add oc_mutex_new_recursive

This change adds ability to create oc_mutex with recursive support.

The function oc_mutex_new_recursive() will be used by a later change
in OCStack to remove the responsibility of calling OCProcess from
applications so that they don't have to call it in an endless loop.

Change-Id: I0d60188af9bce866f5ba18800292204c78daba11
Signed-off-by: Way Vadhanasin <wayvad@microsoft.com>
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19605
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoIOT-1828 Fix oc_mutex_assert_owner bug 57/19857/3
Way Vadhanasin [Thu, 27 Apr 2017 17:12:45 +0000 (10:12 -0700)]
IOT-1828 Fix oc_mutex_assert_owner bug

When a mutex goes through the condition variable wait API, there is a
bug that causes oc_mutex_assert_owner to fail. This patch fixes that
bug.

Change-Id: I0d60188af9bce866f5ba18800292204c78daba12
Signed-off-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19373
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19857
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2284] connectivity: Fixed dead lock issue in catcpserver 09/20109/10
hyuna0213.jo [Sun, 21 May 2017 23:51:20 +0000 (08:51 +0900)]
[IOT-2284] connectivity: Fixed dead lock issue in catcpserver

use caqueueingthread to send tls message in CATCPPacketSendCB

Bug: https://jira.iotivity.org/browse/IOT-2284
Change-Id: Ie32ef9d9c593c3668232263ce9a58ad476986f83
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20109
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months agoRevert cloud sign-up response behavior 25/20225/2
Jee Hyeok Kim [Mon, 22 May 2017 08:22:57 +0000 (17:22 +0900)]
Revert cloud sign-up response behavior

1. Revert cloud behavior not to disconnect client
   after cloud sends sign-up response to client.

Change-Id: I367dfe4ebe16567ada67ae2f7aac8b8a4c0f5db2
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20225
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoMake loading of oauth libraries available without changing iotivity codebase. 09/20009/5
Ondrej Tomcik [Wed, 17 May 2017 22:15:45 +0000 (00:15 +0200)]
Make loading of oauth libraries available without changing iotivity codebase.

Change-Id: I4ac25b7f605e355fc3aad286baa206d67584be69
Signed-off-by: Ondrej Tomcik <ondrej.tomcik@kistler.com>
Issue: IOT-2316
Reviewed-on: https://gerrit.iotivity.org/gerrit/20009
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
6 months agoUpdate cloud project README files 09/20209/2
Jee Hyeok Kim [Mon, 22 May 2017 00:11:18 +0000 (09:11 +0900)]
Update cloud project README files

Change-Id: I10a04fcc499fa8de7fccfd6333d74f6688bb691b
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20209
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ondrej Tomcik <ondrej.tomcik@kistler.com>
6 months ago[IOT-2295] Some libraries in "services" don't have the soname set. 05/20105/2
Herve Jourdain [Thu, 18 May 2017 08:06:57 +0000 (16:06 +0800)]
[IOT-2295] Some libraries in "services" don't have the soname set.

In the android case, this results in some jni libraries not being able
to load the shared libraries they depend upon, which results in errors.
The solution is to add the soname for the libraries that don't have it.

Change-Id: I52e3e3e182b1aeb9257862c7253d11023a634ac3
Signed-off-by: Herve Jourdain <herve.jourdain@beechwoods.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20105
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoIoT-1842: Fix OCRepresentation issues on VS2013. 53/19553/4
Soemin Tjong [Wed, 3 May 2017 00:51:02 +0000 (17:51 -0700)]
IoT-1842: Fix OCRepresentation issues on VS2013.

https://jira.iotivity.org/browse/IOT-1842

Removed the not working shallow copy of the OCRepresentation object.
No problem is observed.

Deep copy should also fix the problem if any issue is found in the
future.

Change-Id: Ifc4aba57a591d0cb6a55e65e1a179e2c8a9ebc08
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19553
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months ago[IOT-2271] [IOT-2308] fix hard-coded ACL for discovery and onboarding 71/19971/12
Nathan Heldt-Sheller [Wed, 17 May 2017 02:34:21 +0000 (19:34 -0700)]
[IOT-2271] [IOT-2308] fix hard-coded ACL for discovery and onboarding

The GetDefaultACL() function needed to be updated to /acl2 format.
Fixed the printACL() function to support ace2 as well.
Fixed aclresourcetest.cpp unit tests.
Updated related .json and .dat files.

Change-Id: Id1a14067e3c9d743cab489c733486fcea1e91d52
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19971
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoFix defects detected by static code analyzer 87/20087/7
Jaewook Jung [Fri, 19 May 2017 02:02:29 +0000 (11:02 +0900)]
Fix defects detected by static code analyzer

 - fixed memory leak
 - removed unreachable codes
 - add a null checking before refer a character pointer

Change-Id: Ie49c44f0d2e5211dec24a607382c202900b4f6a3
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20087
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months ago[IOT-2334][IOT-2335] Fixed presence sample app crash issue 11/20211/3
hyuna0213.jo [Mon, 22 May 2017 04:50:11 +0000 (13:50 +0900)]
[IOT-2334][IOT-2335] Fixed presence sample app crash issue

we should call CADestroyToken() to free memory after merging
https://gerrit.iotivity.org/gerrit/19263

Bug: https://jira.iotivity.org/browse/IOT-2334
Bug: https://jira.iotivity.org/browse/IOT-2335
Change-Id: I10fb78d1f6f63a31678b07d917da547e054161b0
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20211
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months agoFix build warning on Notification service. 15/20215/2
KIM JungYong [Mon, 22 May 2017 06:23:26 +0000 (15:23 +0900)]
Fix build warning on Notification service.

1. unused parameters is resolved.
2. implicit using of functions is fixed as including owned header.
3. print format is fixed.

Change-Id: I240ac626f6ed9f1aa02db7980ba657ae666653e9
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20215
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agonotification: Build when cloud is not enabled 35/19835/6
Philippe Coval [Fri, 12 May 2017 18:50:10 +0000 (20:50 +0200)]
notification: Build when cloud is not enabled

Problem was observed while building with:

scons VERBOSE=1 RELEASE=true SECURED=0 WITH_MQ=PUB,SUB,BROKER

  service/notification/examples/linux/notificationconsumer.c:268:23: \
  error: 'CLOUD_ADDRESS' undeclared (first use in this function)
  service/notification/examples/linux/notificationconsumer.c:268:23: \
  note: each undeclared identifier is reported only once for each function it appears in

Bug: https://jira.iotivity.org/browse/IOT-2244
Change-Id: I12f9a457ac7f838b90567794cbb030bdf80c3dc9
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19835
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2281] /oic/sec/amacl responding to GET but not to POST 85/20185/3
Nathan Heldt-Sheller [Sat, 20 May 2017 18:36:29 +0000 (11:36 -0700)]
[IOT-2281] /oic/sec/amacl responding to GET but not to POST

Until AMS and /amacl functionality is implemented, the /amacl Resource
should not be instantiated as it misleads Clients (including CTT) into
expecting full Specification behavior.

Change-Id: Id542b7a5974cb96ae84e7165326e4d2e8170d5dd
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20185
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoFix two "implicit function declarations 43/19943/2
Mats Wichmann [Fri, 7 Apr 2017 16:42:20 +0000 (10:42 -0600)]
Fix two "implicit function declarations

service/easy-setup/enrollee/src/easysetup.c:182:9: warning: implicit declaration of function 'RegisterConnectRequestEventCallBack' [-Wimplicit-function-declaration]
service/notification/examples/linux/notificationprovider.c:99:14: warning: implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]

Change-Id: I0e449b2834da90422f44e116c6ee91f241d6ec9e
Signed-off-by: Mats Wichmann <mats@linux.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18613
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit f33bfc11627ee1adc9bcde85fea4e5f1df0ca197)
Reviewed-on: https://gerrit.iotivity.org/gerrit/19943

6 months agoWindows: single-threaded unit test run 61/20061/5
Dan Mihai [Thu, 18 May 2017 17:29:06 +0000 (10:29 -0700)]
Windows: single-threaded unit test run

Serialize the tests, because otherwise investigation of failures is
too difficult. For an example of puzzling failure, see:
https://build.iotivity.org/ci/job/iotivity-verify-windows-x86-vs2015/1495/

Change-Id: I90b836b4c4c6587de108de32d761f99fb3073819
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20061
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months ago[IOT-2280] update /doxm.rowneruuid in POST handler 83/20083/2
Nathan Heldt-Sheller [Fri, 19 May 2017 00:53:36 +0000 (17:53 -0700)]
[IOT-2280] update /doxm.rowneruuid in POST handler

This workaround fixes issue reported in 2280, but the root cause of
2280 is that the /doxm POST handler still does all sorts of strange
things per IOT-2107.  IOT-2107 will certainly result in another failed
TC shortly.  I am changing IOT-2107 to P1 and to Fix In 1.3.0.  This
patch doesn't hurt in the meantime to resolve 2280.

Change-Id: I2204cddabe943941f46136b60d0922a77f208665
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20083
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2293] [IOT-2192] reject POST to /acl2 Resource with ACL1 payload 89/20189/2
Nathan Heldt-Sheller [Sat, 20 May 2017 20:42:52 +0000 (13:42 -0700)]
[IOT-2293] [IOT-2192] reject POST to /acl2 Resource with ACL1 payload

/acl2 POST handler now calls a version-check-only optional CBORPayloadToAcl()
function and, if an acl1 payload is found, denies the POST request.

This update caught some unit test issues that were also corrected with
this patch.

Change-Id: I20d148ef037c82f5862fd9fec156bbb399ab7417
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20189
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months agoIgnore introspection 99/20199/2
Dmitriy Zhuravlev [Sun, 21 May 2017 14:55:35 +0000 (17:55 +0300)]
Ignore introspection

Skip /introspection resource in secure stack sample

Change-Id: I36dd6718ba57d0712b22a147e3a7d2c638fe1c92
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20199
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months ago[IOT-2105] Removing undocumented property oxmtypes from doxm 03/19703/8
saurabh.s9 [Mon, 8 May 2017 08:34:55 +0000 (14:04 +0530)]
[IOT-2105] Removing undocumented property oxmtypes from doxm

[patch 2] Retrigger jenkins

Change-Id: I2fc90f3814471ad6c0961b3d6266dc1a04fe1fc3
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19703
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2315] gAcl fix 27/20127/5
Oleksandr Dmytrenko [Fri, 19 May 2017 10:36:30 +0000 (13:36 +0300)]
[IOT-2315] gAcl fix

1) Problem of accessing 'gAcl' global pointer variable fix
2) compile warning fix

Change-Id: Ib79d6b9e2ad3c6a377ca08b30252378356a31a28
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20127
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2337] Fix credential resource warnings 95/20195/2
Dmitriy Zhuravlev [Sun, 21 May 2017 10:23:59 +0000 (13:23 +0300)]
[IOT-2337] Fix credential resource warnings

Fix compiler warnings in credresource.c

Change-Id: Ibf6d9a115771c444e656329950a8f5c88e9f5ff6
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20195
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
6 months ago[IOT-2282] Do not update ACL in SVR DB when receive NULL aces from cloud 93/20193/2
Andrii Shtompel [Sun, 21 May 2017 09:52:05 +0000 (12:52 +0300)]
[IOT-2282] Do not update ACL in SVR DB when receive NULL aces from cloud

Change-Id: I0aea3490cd9f41c6a192c2ed87d8f49c80f6ac3c
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20193
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2087] Check NULL pointer after realloc 21/19621/10
ol.beketov [Sun, 21 May 2017 09:37:48 +0000 (12:37 +0300)]
[IOT-2087] Check NULL pointer after realloc

Change-Id: Ia9eac5375ea4d322cbe4f685588a57b6af047deb
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19621
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2245] Fix CredEntityHandlerDeleteTest 83/20183/6
Dmitriy Zhuravlev [Sat, 20 May 2017 15:01:17 +0000 (18:01 +0300)]
[IOT-2245] Fix CredEntityHandlerDeleteTest

POST replaced by Add

Change-Id: If8f529b4dc18744c9362eab715cec84e43f89a31
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20183
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
6 months ago[IOT-2331] segmentation fault in aclresource.c 69/20169/3
Oleksandr Dmytrenko [Sat, 20 May 2017 10:34:48 +0000 (13:34 +0300)]
[IOT-2331] segmentation fault in aclresource.c

Linux enrollee sample crashes - segmentation fault in aclresource.c

Change-Id: Id6d50d29184e239ac7cc3371918bed8980c35204
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20169
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2124] added NULL check after OICCalloc 75/20175/3
saurabh.s9 [Sat, 20 May 2017 13:15:28 +0000 (18:45 +0530)]
[IOT-2124] added NULL check after OICCalloc

Change-Id: I4013385beb5ba13fe8830f6b64a20f9562f0bdbf
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20175
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2133] Adding missing updateIndividualAcl API 97/19897/7
saurabh.s9 [Sat, 20 May 2017 09:15:43 +0000 (14:45 +0530)]
[IOT-2133] Adding missing updateIndividualAcl API

Change-Id: I0b2f2db077a77b586e0799ec4d2ea3551fc363ca
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19897
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[NS] Valgrind Invalid read/write fix for notification consumer. 15/20015/5
Jay Sharma [Thu, 18 May 2017 04:07:14 +0000 (09:37 +0530)]
[NS] Valgrind Invalid read/write fix for notification consumer.

Bug: https://jira.iotivity.org/browse/IOT-2200
Change-Id: Iadff8323da99f9267193787f2e8192d18cd50c4b
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20015
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix issues detected by static analysis 45/20045/7
Glen Youngjin Kim [Thu, 18 May 2017 12:36:49 +0000 (21:36 +0900)]
Fix issues detected by static analysis

Fixed memory leak issue on occlientcb.c, occollection.c, ocpayload.c
and ocresource.c.
Fixed dereference issue without checking NULL on ocpayloadparse.c

Change-Id: Ibf1757ca85833c2f1b849354e93882730c6c78f9
Signed-off-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20045
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoRevert "[IOT-2250] Mediator Android App Crash Fix." 49/20149/3
Senthil Kumar G S [Fri, 19 May 2017 13:16:43 +0000 (13:16 +0000)]
Revert "[IOT-2250] Mediator Android App Crash Fix."

This reverts commit 24a880e4a5e02cd40451a66857d3c92790f6f588.

Reason: Dependent patch https://gerrit.iotivity.org/gerrit/#/c/20007/ got reverted.

Change-Id: I19502c667b56a762eba3987d3f372e806f78088c
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20149
Reviewed-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFree payload and option in clientCB. 57/20157/3
Ziran Sun [Fri, 19 May 2017 18:21:25 +0000 (19:21 +0100)]
Free payload and option in clientCB.

This is to fix crash issue when OCF client sends unicast GET to OIC server.

Bug: https://jira.iotivity.org/browse/IOT-2329
Change-Id: Id3992563e3d7a8db02f8308ab00eaea1f93db5e5
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20157
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months ago[IOT-2283] connectivity: Fixed the duplicated response issue on discovery 17/20117/6
hyuna0213.jo [Fri, 19 May 2017 09:48:02 +0000 (18:48 +0900)]
[IOT-2283] connectivity: Fixed the duplicated response issue on discovery

Dualstack is unnecessary condition.

Bug: https://jira.iotivity.org/browse/IOT-2283
Change-Id: I1a0635fdfc85c27ead8da66b1bd2ccd7fe1e25c4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20117
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix Windows build breaks 79/20179/2
Dan Mihai [Sat, 20 May 2017 14:06:14 +0000 (07:06 -0700)]
Fix Windows build breaks

New build breaks introduced by a79fe554f66c1332d1f1b55743d6d4705d2a7c7f

Change-Id: I85d96c44ad0d6e1faca620837c4be0172db44499
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20179
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
6 months ago[IOT-2263] Fix provisioning flow with DOS 31/19931/24
Dmitriy Zhuravlev [Mon, 15 May 2017 20:56:00 +0000 (23:56 +0300)]
[IOT-2263] Fix provisioning flow with DOS

Updates provisioning flow for:
1) Trust Chain
2) PSK
3) ACL

Change-Id: Id1824b3ef7974658857a203125d36ca25a653add
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19931
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months agoFix SVACE defects - part 2 41/20141/6
Oleg Kopysov [Fri, 19 May 2017 19:10:49 +0000 (22:10 +0300)]
Fix SVACE defects - part 2

File: resource/csdk/security/provisioning/sample/certgenerator.cpp
-- file handle loss
-- potential buffer overrun by sprintf call

Change-Id: I12217045b42683b4eac3af03b76c4c189f7a00db
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20141
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2262][IOT-2232][IOT-2305] Fix manufacturer certificate OTM 99/19899/11
ol.beketov [Fri, 19 May 2017 10:52:50 +0000 (13:52 +0300)]
[IOT-2262][IOT-2232][IOT-2305] Fix manufacturer certificate OTM

Fix for manufacturer certificate ownership transfer

Patch 4: remove workaround and fixed original issue for certOTM

Change-Id: I44bcc2c09f75c3170644e48fc297c8ac323b7405
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Signed-off-by: Jongsung Lee <js126.lee@samsung.com>
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19899
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months agoFix defects detected by SVACE 49/20049/9
Oleg Kopysov [Fri, 19 May 2017 17:38:46 +0000 (20:38 +0300)]
Fix defects detected by SVACE

Fix SVACE warnings in the following directories:
- /resource/csdk/security/provisioning
- /resource/provisioning

Implemented:
- use snprintf instead of sprintf
- null pointer checks
- fclose added to remove lost handles

Change-Id: I31d6765df649e30c24c931932eb68bc35b7e6cef
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20049
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months agoRemove build warnings 93/20093/4
Jaewook Jung [Fri, 19 May 2017 05:56:49 +0000 (14:56 +0900)]
Remove build warnings

 - fix implicit declaration of function
 - remove unused codes
 - remove unused parameter warnings

Change-Id: I830f9ada169e334a566bb696dee6cf9b46c87459
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20093
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months agodisable cloud function in simplebase app. 29/20129/2
jihwan.seo [Fri, 19 May 2017 10:39:56 +0000 (19:39 +0900)]
disable cloud function in simplebase app.

since both cloudprovisioningclient app is main app and
simplebase app can not cover update cloud spec directly.

it is better to disable cloud function in the app before final spec fix.

Change-Id: I6573683f1dd92a1e63021a905cc3dac06481bb44
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20129
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months agoIOT-2333 : Introspection resource should be OC_SECURE only 59/20159/2
Srikrishna Gurugubelli [Fri, 19 May 2017 23:54:58 +0000 (16:54 -0700)]
IOT-2333 : Introspection resource should be OC_SECURE only

Change-Id: I2ce16521c98eb6b2c2d131189a860da1433e74a9
Signed-off-by: Srikrishna Gurugubelli <srikguru@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20159
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months agoFixed memory leak on ocpayload.c 37/19937/3
hyuna0213.jo [Tue, 16 May 2017 07:17:50 +0000 (16:17 +0900)]
Fixed memory leak on ocpayload.c

Fixed memory leak on ocpayload.c detected by static analysis

Change-Id: I3a8de43b8feff88509af6959f6b78b79eb8feb4c
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19937
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
6 months ago[IOT-2294] Resolved saveTrustChain issue 29/20029/3
saurabh.s9 [Thu, 18 May 2017 10:00:32 +0000 (15:30 +0530)]
[IOT-2294] Resolved saveTrustChain issue

Change-Id: Ib64f565304c78a281d082be1dd6cc99a73e3fdb9
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20029
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoFix some lines for proper coding convention. 37/20037/3
Jihun Ha [Thu, 18 May 2017 10:37:37 +0000 (19:37 +0900)]
Fix some lines for proper coding convention.

Some brace locations are changed to better coding convention in scene manager

Change-Id: Id8edd9fbdf582ffcae1bfd8ba239e13a875f2068
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20037
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2324]warning fix 2 39/20039/3
Oleksandr Dmytrenko [Thu, 18 May 2017 10:52:39 +0000 (13:52 +0300)]
[IOT-2324]warning fix 2

Warning fix in resource/csdk/security/provisioning

Change-Id: I3791fa427b04ac80a7e0847d4b13e6b121f74aa5
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20039
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2324]warning fix 1 27/20027/3
Oleksandr Dmytrenko [Thu, 18 May 2017 09:58:00 +0000 (12:58 +0300)]
[IOT-2324]warning fix 1

Warning fix in resource/provisioning

Change-Id: I75664d7e2d083caab3eee222bef486a433a77e26
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20027
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2317] gDoxm NULL checks 39/20139/3
Oleksandr Dmytrenko [Fri, 19 May 2017 11:54:35 +0000 (14:54 +0300)]
[IOT-2317] gDoxm NULL checks

Accessing global pointer variable gDoxm without NULL check fix

Change-Id: Ief964e6c941ef17a7a24fc07fb4f1807cfc07e0f
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20139
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months agoFix return value in GetDtlsPskCredentials() 37/20137/2
ol.beketov [Fri, 19 May 2017 11:42:37 +0000 (14:42 +0300)]
Fix return value in GetDtlsPskCredentials()

Fix return value in GetDtlsPskCredentials() from
credresource.c missed in patchset #19785

Change-Id: Id79111409f574ce49f037adb6602a4195666db0c
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20137
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months agoDefine OC_CALL (call convention for public APIs). 47/18847/9
Soemin Tjong [Fri, 3 Mar 2017 08:13:17 +0000 (00:13 -0800)]
Define OC_CALL (call convention for public APIs).

Set to __stdcall for WIN32.
Add to IPCA public APIs.
Other public APIs will be updated in separate commit.

Change-Id: I3201b7088eeb2227d2681847d20172825fbf4cae
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18169
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18847

6 months ago[IOT-2131] Adding Method to create ACL id for Android App 91/19791/7
saurabh.s9 [Thu, 11 May 2017 04:52:19 +0000 (10:22 +0530)]
[IOT-2131] Adding Method to create ACL id for Android App

Change-Id: I49658c8612f42b4d5caf90cce04e97d8e3315642
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19791
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoFix MessageQueue TC failure 03/20103/3
jihwan.seo [Fri, 19 May 2017 07:36:19 +0000 (16:36 +0900)]
Fix MessageQueue TC failure

Change-Id: I8a3ed1067f86a9a398b6b640ba738586cedf3f7e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20103
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix some filenames to be more Linux-friendly 59/19359/4
Mats Wichmann [Fri, 10 Mar 2017 20:13:52 +0000 (13:13 -0700)]
Fix some filenames to be more Linux-friendly

Two filenames: one contains space, another an apostrophe,
interferes with easily running linux "find" on iotivity,
and there's no compelling reason why these characters are needed
in the names.

Change-Id: I85b554d874bed654a150915a23fb8b237e2f189a
Signed-off-by: Mats Wichmann <mats@linux.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19359
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoFix build warning on notification sample. 45/19945/2
KIM JungYong [Tue, 16 May 2017 08:46:21 +0000 (17:46 +0900)]
Fix build warning on notification sample.

strcmp function is used but does not a including header.
in this patch string.h is included.

Change-Id: I37de71e3171c3586982c4173ef3c22864d82092b
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19945
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agosimulator: Fix permission of sources 27/19827/3
Philippe Coval [Tue, 9 May 2017 17:27:07 +0000 (19:27 +0200)]
simulator: Fix permission of sources

Change-Id: Iad9def49f47016435243c8ff44e2b052cd946ed2
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19827
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months agoFix static analysis warnings on notification. 25/20025/4
jake [Thu, 18 May 2017 09:49:40 +0000 (18:49 +0900)]
Fix static analysis warnings on notification.

 - Uninitialized variable is initialized
 - Function strcpy is changed to strncpy
 - When execution of equal operation, prevent copied it self
 - Insert brace

Change-Id: I4de2c8cae30eea4c81cde1db7191788dc646b3dc
Signed-off-by: jake <jaehong2.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20025
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
6 months agoUpdated mediator android application for secure mode. 53/20153/2
Senthil Kumar G S [Fri, 19 May 2017 15:11:10 +0000 (20:41 +0530)]
Updated mediator android application for secure mode.

In secure mode, mediator should send requests to the secure endpoint
of the easy-setup resource. Updated the sample to handle the same.

Change-Id: I5a27f06bcf2f8698d58e2b79049d7b342e303599
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20153
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoUnit tests enhancements for Proxy 55/20155/2
Abhishek Sharma [Fri, 19 May 2017 16:22:45 +0000 (21:52 +0530)]
Unit tests enhancements for Proxy

Change-Id: I6c0285b3c8b396dde5337fe69c54a81ad610f2f3
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20155
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months agoRemove a build warning in easy-setup compilation 41/19941/2
Jihun Ha [Tue, 16 May 2017 08:43:18 +0000 (17:43 +0900)]
Remove a build warning in easy-setup compilation

- The 3rd parameter of OCRepPayloadSetStringArray is one in "const char **"
type, not "char **"
- Align types to unsigned int in comparison

Change-Id: I391b29ac86f75928e4bea34077a38a2bea392b7e
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19941
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
6 months ago[IOT-2319] Discovery Request fix 51/20151/2
Oleksandr Dmytrenko [Fri, 19 May 2017 14:21:06 +0000 (17:21 +0300)]
[IOT-2319] Discovery Request fix

[CS][Csdk][Sample App] Discovery Request Crashed fix

Change-Id: Iffc7b61fce57dfab706122bc5649d3fd65ab0daa
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20151
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months ago[IOT-2265] [IOT-2142] [IOT-2164] Resolved Unowned device discovery in Android 19/20019/6
saurabh.s9 [Thu, 18 May 2017 07:22:19 +0000 (12:52 +0530)]
[IOT-2265] [IOT-2142] [IOT-2164] Resolved Unowned device discovery in Android

Change-Id: Ic4327443832798ed3ce093566f1994216b84dad4
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20019
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
6 months agoIOT-2204: Fix IPCA compiler warnings on Linux 53/19753/9
Soemin Tjong [Tue, 9 May 2017 02:16:19 +0000 (19:16 -0700)]
IOT-2204:  Fix IPCA compiler warnings on Linux

https://jira.iotivity.org/browse/IOT-2204

Change-Id: I523c947aba51b3d4d7b0b6e19745e783eab3eeeb
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19753
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months agoIOT-2258: Allow secure and nonsecure endpoints with OCCreateResource. 95/19995/4
Todd Malsbary [Wed, 17 May 2017 18:56:13 +0000 (11:56 -0700)]
IOT-2258: Allow secure and nonsecure endpoints with OCCreateResource.

Added new property flag OC_NONSECURE.  To specify both secure and
nonsecure endpoints use OC_SECURE | OC_NONSECURE.  The behavior when
neither flag is specified is OC_NONSECURE, the same as before this
change.

Bug: https://jira.iotivity.org/browse/IOT-2258
Change-Id: I12ffdff70a83455eff46d4464e234963063c4f35
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19995
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months agoIOT-2275 Windows: Disable the Cloud APIs 67/19967/3
Dan Mihai [Tue, 16 May 2017 20:00:32 +0000 (13:00 -0700)]
IOT-2275 Windows: Disable the Cloud APIs

These APIs are not working on Windows.

Change-Id: I6c4869da290808fdb41d2d834a5dd1cbd0766744
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19967
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
6 months ago[IOT-2259] Windows: Handle Persistent Storage for UWP Apps 45/19845/11
Ibrahim Esmat [Thu, 27 Apr 2017 16:13:35 +0000 (09:13 -0700)]
[IOT-2259] Windows: Handle Persistent Storage for UWP Apps

Changes to allow UWP apps that use IPCA to handle Persistent
Storage:
- Updated the SConscripts to point to store LIBS
- Added a UWP_APP env variable to enable building store DLLs
- Disabled gtest and other tests when building store DLLs
  because gtest is heavily dependent on win32 APIs and DLLs
- Add code to set the sqlite3 temporary directory when building
  for store DLLs (as required by sqlite3). This temporary
  directory will be the appropriate temp directory.
- Add a platform helper function to get the best application
  path to store the Persistent Storage files. IPCA uses this
  helper function to get the path when opening PS files.
- Add capability to run.bat to build UWP DLLs

Change-Id: Iac3a2c9e9e2fd994b06e964254f2d394b15526aa
Signed-off-by: Ibrahim Esmat <iesmat@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19845
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months ago[IOT-2269] Do not include rowner property in csr resource CBOR 13/20013/3
Kevin Kane [Wed, 17 May 2017 23:13:26 +0000 (16:13 -0700)]
[IOT-2269] Do not include rowner property in csr resource CBOR

"rowner" property was being erroneously included in the CBOR
payload for the CSR resource, which caused the map in the
response to contain one more key/value pair than it should have.

This property should not be included as it is not part of the
specification for this resource.

Change-Id: I61a25535b79d21857b18f7f1f2bb077e8420b3f5
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20013
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
6 months ago[IOT-2289] Add NULL check for acl param in OCProvisionACL 43/20043/3
Andrii Shtompel [Thu, 18 May 2017 11:10:45 +0000 (14:10 +0300)]
[IOT-2289] Add NULL check for acl param in OCProvisionACL

Change-Id: I5f950a890d4d7492795aced3dee4d6a052635361
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20043
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months ago[IOT-2291] Remove OCProvisionCRL from ocprovisioningmanager.h 41/20041/3
Andrii Shtompel [Thu, 18 May 2017 10:58:15 +0000 (13:58 +0300)]
[IOT-2291] Remove OCProvisionCRL from ocprovisioningmanager.h

Change-Id: I07415f840dac350beee008698d7b64f5bdae4517
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20041
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
6 months agoCheck for null alloc in rddatabase unit tests. 29/19229/6
Ziran Sun [Thu, 13 Apr 2017 12:48:14 +0000 (13:48 +0100)]
Check for null alloc in rddatabase unit tests.

Bug: https://jira.iotivity.org/browse/IOT-2022
Change-Id: I6306e10d1c3ab1146e4588077cbe091f34089059
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19229
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>