iotivity.git
13 months agotizen: Only package libuuid1.so if present 93/14193/2 1.1-rel
Philippe Coval [Fri, 28 Oct 2016 13:29:46 +0000 (15:29 +0200)]
tizen: Only package libuuid1.so if present

As this trick is a workaround for current version of Tizen SDK,
avoid to break on failure to ship copied lib.

Backported to 1.1-rel, I suppose this issue is caused by SDK update

Change-Id: Idad5dd5ab3e24a569bffe22b1f83badb1906978f
Bug: https://jira.iotivity.org/browse/IOT-1343
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13827
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 6cc3ae595f9e77c210323116656649ab2af71056)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13937
Reviewed-on: https://gerrit.iotivity.org/gerrit/14193
Reviewed-by: Habib Virji <habib.virji@samsung.com>
13 months agoyocto: Add aarch64 for DragonBoard-410c 85/14185/3
Philippe Coval [Thu, 10 Nov 2016 11:47:39 +0000 (12:47 +0100)]
yocto: Add aarch64 for DragonBoard-410c

Backported to 1.1-rel branch

Change-Id: I0ebf93ca17a9a6624da3caaaf7487529b2c556d6
Credit-to: Kotaro HASHIMOTO <Hashimoto.Kotaro@ds.MitsubishiElectric.co.jp>
Origin: https://gerrit.iotivity.org/gerrit/#/c/14073/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
13 months agotizen: Add iotivity namespace for headers 17/13617/2
Philippe Coval [Thu, 22 Sep 2016 08:45:45 +0000 (10:45 +0200)]
tizen: Add iotivity namespace for headers

Currently symlink to parent folder,
 this way it's aligned to yocto recipe.

In longer term it would be nice to rely on scons install rules.

Change-Id: Ie8067c13302ccf92936d599bb4f6b3740d3cf009
Bug: https://jira.iotivity.org/browse/IOT-524
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 5a494b98d65b2950a9331ec77b03ce429ba64cde)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12485
(cherry picked from commit 921341bdb110113afbfffb4c4de98f2f4eb7ba1c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13617
Reviewed-by: Habib Virji <habib.virji@samsung.com>
13 months agodoc: Fix some typos in scons_script_how_to.txt 67/11267/8
Philippe Coval [Sat, 27 Aug 2016 14:53:16 +0000 (16:53 +0200)]
doc: Fix some typos in scons_script_how_to.txt

Maybe this file worth to be migrated to iotivity wiki in a scons page

Change-Id: I288da1273621a48add047993506ed40c107363ab
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit da851aa0583bb1fcccfa634de8b61ee815fbdbd8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11267

13 months agolinux: Support also armeabi-v7a TARGET_ARCH 19/13619/2
Philippe Coval [Wed, 28 Sep 2016 12:07:16 +0000 (14:07 +0200)]
linux: Support also armeabi-v7a TARGET_ARCH

This EABI is used in Tizen, this way iotivity
 can be rebuild on Tizen using "linux" profile (TARGET_OS).

For instance unsupported older tizen profiles can be rebuilt using gbs
 (ie Tizen:2.3:Wearable).

Change-Id: Ia84cb173add8efbb10cb2a9632a7637cf6202114
Origin: https://gerrit.iotivity.org/gerrit/#/c/12417/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit bc8f5a286869e02b518f68363c717c52e9eeb819)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13619
Reviewed-by: Habib Virji <habib.virji@samsung.com>
13 months agosecurity: Improve with more specific error core and log of it 21/13621/2
Philippe Coval [Thu, 21 Jul 2016 08:38:18 +0000 (10:38 +0200)]
security: Improve with more specific error core and log of it

This improvement has been suggested by Randeep Singh at :

 https://gerrit.iotivity.org/gerrit/#/c/9521/

Also reducing presence of "goto:" is always welcome ;)

Change-Id: I2ca21c37105c530c92e2cfd4b6ae9e3cfbc06231
Origin: https://gerrit.iotivity.org/gerrit/#/c/9543/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6b06fdadbadac7874da63f0150b7cd8e75fb31d5)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13621
Reviewed-by: Habib Virji <habib.virji@samsung.com>
13 months agostdassert.h is not standard-compliant. Change this to assert.h 21/13721/2
daeken.kwon [Fri, 29 Apr 2016 02:00:45 +0000 (11:00 +0900)]
stdassert.h is not standard-compliant. Change this to assert.h

Change-Id: I7034df1b22b2040815bdc06521921814e5a09998
Signed-off-by: daeken.kwon <daeken.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
(cherry picked from commit 9f278d12b1adb38e95497c1cdba70e6eafb13a53)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13721
Reviewed-by: Habib Virji <habib.virji@samsung.com>
14 months agoyocto: Use tools from sysroot before system PATH 99/11899/2
Philippe Coval [Fri, 16 Sep 2016 18:22:03 +0000 (20:22 +0200)]
yocto: Use tools from sysroot before system PATH

To ensure reproductibily Scons avoids to rely on environment
 but some systems like Yocto are defining their own cross compiling env.

To deal with those orthogonal paradigms,
 a new CONFIG_ENVIRONMENT_IMPORT variable has been introduced,
 It enables import of needed variables (PATH and pkg-config's ones).

Without this change, system tools might be used by scons
 instead of looking into yocto's sysroot.
 This is not not wanted and may be less reproductible.

This problem was noticed when building Ostro OS
 (on a system without all Yocto dependencies)
 reported error messages were:

  | sh: gdbus-codegen: command not found
  | /bin/sh: 1: pkg-config: not found

More information about using SCONS along Yocto, check some notes at:

https://bitbucket.org/scons/scons/wiki/Notes

Bug: https://jira.iotivity.org/browse/IOT-1219
Change-Id: I6af59a590f8be489398623d29cf85c2f568dd6a3
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/on/master/mine
Origin: https://gerrit.iotivity.org/gerrit/#/c/11897/
Thanks-to: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11899
Reviewed-by: Kishen Maloor <kishen.maloor@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mikko Ylinen <mikko.ylinen@intel.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
14 months agoresource-container: Change file permission of SampleResource sources 39/11439/4
Philippe Coval [Fri, 11 Dec 2015 10:10:49 +0000 (15:40 +0530)]
resource-container: Change file permission of SampleResource sources

Removed the execute permission for the SampleResourceClient.cpp and
SampleResourceServer.cpp files in service/resource-encapsulation/examples/linux

Change-Id: I2ac6381ada31d76aead5e7139ea62d888d1a2877
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Author: Ravi Nanjundappa <nravi.n@samsung.com>
Origin: 1.0.1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11485
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 264c01be6ac029c5b278bd20b8c985d6d7ed6dad)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11439

14 months agoUpdated scons build configuration for Yocto 55/11855/2
Kishen Maloor [Mon, 21 Sep 2015 12:38:57 +0000 (05:38 -0700)]
Updated scons build configuration for Yocto

* Added i686 to the list of supported target architectures
  for a Yocto build.

Change-Id: I2b5b3191807ab7229cb3457f42a21a94a1d1611e
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11855
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Mikko Ylinen <mikko.ylinen@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
15 months agoresource-encapsulation: Avoid reinterpret_cast in const_expr 65/11665/5
Philippe Coval [Fri, 9 Sep 2016 17:12:26 +0000 (19:12 +0200)]
resource-encapsulation: Avoid reinterpret_cast in const_expr

As unsupported in C++11 standard and g++-6 or clang

Reported error message is:

  service/resource-encapsulation/src/serverBuilder/unittests/RCSResourceObjectTest.cpp:368:13:
  error: reinterpret_cast from integer to pointer
  reinterpret_cast<OCRequestHandle>(0x1234);

Problem was observed while building for Yocto with generic toolchain:
  i586-poky-linux-g++ (GCC) 6.2.0

For reference see p125 of:

  http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3797.pdf

Change-Id: I20b21ad1bdac40c2aec44706501343ae1d9d7b69
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/meta-oic
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit fdefa8c077e0d854984b6d40622f633fe1b1b6cf)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11665
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
15 months agoCorrect wrong use of API for creating resources in unittests. 37/10737/5
Ziran Sun [Mon, 8 Aug 2016 10:05:48 +0000 (11:05 +0100)]
Correct wrong use of API for creating resources in unittests.

Change-Id: Ib05481a2a87c2eb4714832d453a8455a80c1456f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10139
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit 8414027f9fef2258d4e5b2f579987d20f5f50503)
Reviewed-on: https://gerrit.iotivity.org/gerrit/10737
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
15 months agoFixed memory-leak of |cJSON| object on |json2cbor| 67/10667/6
Kyungsun Cho [Fri, 19 Aug 2016 08:22:05 +0000 (17:22 +0900)]
Fixed memory-leak of |cJSON| object on |json2cbor|

Change-Id: I632a01ae6f7eab2172d471ed1c1a86341a603aa3
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
15 months agogtest: Hotfix to prevent download failure 03/11203/7
Philippe Coval [Tue, 30 Aug 2016 07:38:22 +0000 (09:38 +0200)]
gtest: Hotfix to prevent download failure

gtest-1.7.0.zip (md5=2d6ec8ccdf5c46b05ba54a9fd1d130d7) is gone from:
  https://googletest.googlecode.com/files/gtest-1.7.0.zip

So let's switch to a mirrored file:
  http://pkgs.fedoraproject.org/repo/pkgs/gtest/gtest-1.7.0.zip/2d6ec8ccdf5c46b05ba54a9fd1d130d7/gtest-1.7.0.zip

Note, now upstream project moved to:
  https://github.com/google/googletest/archive/release-1.7.0.zip

But archive structure is different (configure is missing),
 so a additional works are needed,
 maybe it worth to be done on latest release instead (1.8.0 ATM).

Change-Id: Ib1cf308fb2d3a15bdf69246cccfd379234bbce22
Bug: https://jira.iotivity.org/browse/IOT-820
Origin: https://gerrit.iotivity.org/gerrit/#/c/11119/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 69261095d7b80609ed4fc67fee75e47a7e2e548b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11203

15 months agoyocto: Use LDFLAGS if defined in build environment 83/11083/6
Philippe Coval [Mon, 29 Aug 2016 13:16:13 +0000 (15:16 +0200)]
yocto: Use LDFLAGS if defined in build environment

Without this change, extra flags like "--hash-style=gnu"
 will be ignored and quality checks will fail.

Reported message is:
  ERROR: iotivity-* do_package_qa: QA Issue:
  No GNU_HASH in the elf binary:
  '*/samples/opt/iotivity/examples/plugins/zigbee/iotivityandzigbeeserver'
  (...)
  ERROR: iotivity-* do_package_qa: QA run found fatal errors. Please consider fixing them.
  ERROR: iotivity-* do_package_qa: Function failed: do_package_qa
  (...)
  Summary: There were 8 ERROR messages shown, returning a non-zero exit code.

Bug: https://lists.yoctoproject.org/pipermail/yocto/2016-August/031442.html
Bug-AGL: https://jira.automotivelinux.org/browse/SPEC-158
Change-Id: Ifa240817c768df3a7d154d36b699de8ca0f0307a
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11073
Reviewed-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit 82c95d3ba9fb607980981dfb56e8bd9515609454)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11083
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
15 months agocsdk: fix minimal linux tests 21/9621/8
Philippe Coval [Wed, 20 Jul 2016 15:12:14 +0000 (17:12 +0200)]
csdk: fix minimal linux tests

Update to current API, and make them build by default.

Those samples files are good candidates
 to illustrate C API in plain C and not C++,
 specially for systems without recent g++ (ie: Tizen:2.2-)

Change-Id: I22e18903037a249e1dce4d29c2580ffe865caf50
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 2cef6ebad7aa757ff3987ff7668b269d05712670)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9621

15 months agoupdated dat file for directPairing android sample app 15/9815/2
Sunil Kumar K R [Thu, 28 Jul 2016 05:37:22 +0000 (11:07 +0530)]
updated dat file for directPairing android sample app

Change-Id: If4cfc00a57c07f52556f3938271c4f1f2f42f498
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9815
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
15 months agoFix memory corruption when reading integers from cbor 27/8927/5
Hauke Mehrtens [Wed, 22 Jun 2016 09:41:43 +0000 (11:41 +0200)]
Fix memory corruption when reading integers from cbor

When the cbor_value_get_*() function is called with a pointer to some int, it
should have the correct size. When we cast it to something else it is treated
as a pointer to an uint64_t in the function for example and them 64 bits gets
written to memory even with the real type is only 32 bit long. When the real
type is only 32 bit long some other memory gets overwritten. On Big endian
systems the least significant bits are cut of so in most cases 0 is read.

With this patch a value cast is used and the value is converted to the other size.

This is the same as in commit 0d64c7c95a5c11a9fb5201e729fd8c75da210c80
"security: fix reading of permission attribute from configuration"

Change-Id: If5965491241e25ebf60a22dc45d37d74a33cb02f
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8927
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
15 months agobuild: Disable provisioning logging when not wanted 49/9849/3
Philippe Coval [Thu, 28 Jul 2016 16:06:50 +0000 (18:06 +0200)]
build: Disable provisioning logging when not wanted

- Also polish use of LOGGING / TB_LOG option.
- When using scons CPPDEFINES there is no need to add -D prefix.
- Add machine readable header in python files (to avoid tabs).

Bug: https://jira.iotivity.org/browse/IOT-1203
Origin: https://gerrit.iotivity.org/gerrit/9841
Change-Id: Ibfae4ee23b6b157e891e9792c464cd9a481f9eef
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9849
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
15 months agoHandle OC_STACK_RESOURCE_CHANGED as success in Jni Layer 05/9905/2
ljsachs [Wed, 27 Jul 2016 18:50:31 +0000 (11:50 -0700)]
Handle OC_STACK_RESOURCE_CHANGED as success in Jni Layer

Change-Id: Ifbf030ed08424b901f47e58aafac02aff3e60031
Signed-off-by: ljsachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9801
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Signed-off-by: ljsachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9905
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
16 months agobuild: Stop logging RD if not wanted 47/9847/2 1.1.1
Philippe Coval [Thu, 28 Jul 2016 16:06:50 +0000 (18:06 +0200)]
build: Stop logging RD if not wanted

 - Also polish use of LOGGING / TB_LOG option.
 - When using scons CPPDEFINES there is no need to add -D prefix.
 - Add machine readable header in python files (to avoid tabs).

Without this change,
 even if LOGGING is unset, extra verbose log is printed :

  DEBUG: SRM: SRMRegisterHandler !!
  DEBUG: SRM-PSI: GetSecureVirtualDatabaseFromPS IN
  ERROR: SRM-PSI: ps is NULL
  DEBUG: SRM-DOXM: ReadSVDataFromPS failed

This does not occurs in master branch.

Change-Id: Ibfae4ee23b6b157e891e9792c464cd9a00000001
Bug: https://jira.iotivity.org/browse/IOT-1203
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9847
Reviewed-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
16 months agoModified eCode checker in callback method related PUT/POST of SampleApps. 69/9769/2
jihwan.seo [Mon, 25 Jul 2016 11:30:34 +0000 (20:30 +0900)]
Modified eCode checker in callback method related PUT/POST of SampleApps.

as OC_STACK_RESOURCE_CHANGED result is added,
sample application which use callback related put/post
will include checker about OC_STACK_RESOURCE_CHANGED result.
(it is from https://gerrit.iotivity.org/gerrit/#/c/9695/ in master)

Change-Id: I05e69192fed653a4bc1004b1b25ba45408cd50e0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9769
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
16 months agoFix client crash caused by observe cancellation with sequence No 1. 41/9541/2 1.1.1-RC3
Ziran Sun [Wed, 20 Jul 2016 15:16:52 +0000 (16:16 +0100)]
Fix client crash caused by observe cancellation with sequence No 1.

1. Added support for sequence number starting from 1.
2. When sequence number is 1, client treats it as a normal response
rather than de-registration response.
3. Correct default sequence number value to be valid.

JIRA Issue: https://jira.iotivity.org/browse/IOT-1195

Change-Id: I2ce68d70ff5f8f0cce98234a7dbda566b8085a61
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9541
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
16 months agomodified network interface monitoring logic in tizen 27/9527/5
hyuna0213.jo [Thu, 21 Jul 2016 01:34:16 +0000 (10:34 +0900)]
modified network interface monitoring logic in tizen

To detect network interface changes in tizen,
CAFindInterfaceChange() function was modified.

Change-Id: I325c59205b090f9715d72f533faf27831e114792
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
16 months agobuild: Suggest to download tinycbor v0.2.1 65/9565/2
Philippe Coval [Mon, 18 Jul 2016 23:51:09 +0000 (16:51 -0700)]
build: Suggest to download tinycbor v0.2.1

Related to error about undefined reference to _cbor_value_dup
 introduced by new files.

Note this patch is appropriate for frozen versions
 while master or development branches can follow tinycbor master
 and eventually synched when needed.

Change-Id: Ic764a3aa7231982d24fcdd17d66142557bfd8d8a
Cc: Thiago Macieira <thiago.macieira@intel.com>
Credit-to: kartik6402 <karthikeyan.selvaraj@intel.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/9449
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9565
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
16 months agoBug fix OCRepPayloadIsNull function. All of return value is false. 71/9671/3
Sunyoung Jung [Mon, 25 Jul 2016 02:34:10 +0000 (11:34 +0900)]
Bug fix OCRepPayloadIsNull function. All of return value is false.

Change-Id: I24596dc6d1fb1314a9ab669e8f7f63fa297ded63
Signed-off-by: Sunyoung Jung <sy0514.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9671
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
16 months ago[IOT-1196] MAX_QUERY_LENGTH is too short 11/9611/3
ljsachs [Tue, 19 Jul 2016 19:14:09 +0000 (12:14 -0700)]
[IOT-1196]  MAX_QUERY_LENGTH is too short

Increase MAX_QUERY_LENGTH to 256.

Use #define MAX_QUERY_LENGTH in sample code.

Change-Id: Idfc74db1a18af26b2ff5811dac86585ae2b48f9c
Signed-off-by: ljsachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit 634cecc49d0bf0973a93e6944480929148618461)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9611
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
16 months agotizen: Dereference sqlite3 symlinks before building 41/9641/4
Philippe Coval [Sat, 23 Jul 2016 04:52:30 +0000 (06:52 +0200)]
tizen: Dereference sqlite3 symlinks before building

If existing sqlite3 files (not dead links) are present
 it will use them and prevent downloading at buildtime
 and break if running in a "disconnected environment"
 like Tizen GBS (chroot).

Typically, if files are not part of packaging,
  this is the error message you'll face:

   *** Checking for installation of SQLite 3.8.11.1 ***
   Download /home/abuild/rpmbuild/BUILD/iotivity-1.1.1/extlibs/sqlite3/sqlite-amalgamation-3081101.zip
   from https://www.sqlite.org/2015/sqlite-amalgamation-3081101.zip
   Downloading ...
   scons: *** <urlopen error [Errno -3] Temporary failure in name resolution> [https://www.sqlite.org/2015/sqlite-amalgamation-3081101.zip] Stop.

Here are some examples of failed jenkins sessions:

- https://gerrit.iotivity.org/gerrit/#/c/9609/1/
- https://build.iotivity.org/ci/job/iotivity-verify-tizen/364/consoleText

Bug: https://jira.iotivity.org/browse/IOT-820
Change-Id: I59ac88807a2d9222e94b841d99a9163765e8596c
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
16 months agoRAML spec gap changes for ACL 15/9615/4
Sandeep Sharma [Fri, 22 Jul 2016 10:24:22 +0000 (15:54 +0530)]
RAML spec gap changes for ACL

Base: Upadted Java/JNI and provisioning client app
      corresponding to ACL structure updation.

patch#1: Fixed review commnets
patch#2: Few more fixes.

Change-Id: Ibd8e98989c20d6d12c635b2f490d4dfa60f0450d
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9615
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agoupdate version info in build.gradle 31/9531/2
Jaewook Jung [Thu, 21 Jul 2016 01:37:53 +0000 (10:37 +0900)]
update version info in build.gradle

Change-Id: If663a34b81766830e64af3314ead23f1d0ad651e
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Hauke Mehrtens <hauke.mehrtens@intel.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
16 months agoAdd sample provisioning servers in package 11/9311/11
Ashwini Kumar [Tue, 19 Jul 2016 08:44:07 +0000 (14:14 +0530)]
Add sample provisioning servers in package

Added sample provisioning servers into the test package built
Corresponding .dat files are also added to same location as binary file
,i.e. /usr/bin/provision-sample
Server opens the dat file from the current location of the binary file.
This needs to be updated for tizen, to be in a place out of bin, where Read-Write
is possible.

Change-Id: I0d13386976d2d4910934064d6092e1b360dcf919
Credit-to: Ashwini Kumar <k.ashwini@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9311
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agoAdd the device remove API which is using UUID. 25/9425/9
Chul Lee [Mon, 18 Jul 2016 05:33:16 +0000 (14:33 +0900)]
Add the device remove API which is using UUID.

* NOTE : This API is created for easy-setup team's requirement.

Patch #1~#5 : Initial upload
Patch #6 : Add C++ API and unittest.
Patch #7 : Rebase
Patch #8 : Resolve the merge conflict.

Change-Id: I9092526b9112324903bb3041bf572917521e5912
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9425
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agoclean up FreeCARequestInfo of security 21/9521/3
Philippe Coval [Mon, 2 May 2016 07:23:40 +0000 (16:23 +0900)]
clean up FreeCARequestInfo of security

[jihwan.seo]

- added null checker
- removed duplicated codes with line 133 of header file

[Philippe Coval]

- Backport from master branch

Observed issue on client (same on server) :

  INFO: OIC_RI_STACK: Client mode: CAStartDiscoveryServer
  DEBUG: OIC_CA_QING: message handler main thread start..
  DEBUG: OIC_CA_QING: wait..
  ERROR: SRM-AMSMGR: FreeCARequestInfo: Can't free memory. Received NULL requestInfo

Change-Id: I7a7454e29ef2a63cfa9cf3107922e90b56baa313
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8023
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Author: jihwan.seo <jihwan.seo@samsung.com>
Origin: ee2b2072d8c6717afd0e124b40b3fd461456029d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9521
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agoUpdate CKM's sample according to changed ACL data-structure 57/9457/4
Andrii Shtompel [Thu, 21 Jul 2016 11:11:22 +0000 (14:11 +0300)]
Update CKM's sample according to changed ACL data-structure

Change-Id: I50e6b0287d7e76701c6147a3babdfb97cfc59ed8
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9457
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agoRemote Reset 53/9553/4
Chul Lee [Thu, 21 Jul 2016 12:05:10 +0000 (21:05 +0900)]
Remote Reset

Create Reset Profile and Remote Reset by Provisioning Tool
Rebased for 1.1-rel from https://gerrit.iotivity.org/gerrit/#/c/8915/

Patch #1 : Initial upload
Patch #2 : Rebase
Patch #3 : Fix the bugs caused by rebase.

Change-Id: Iecfef8d64fe465fbfb6a2f5768684a1af4769537
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9553
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
16 months agoUpdate POST request handler of PSTAT resource 17/9417/7
Chul Lee [Fri, 15 Jul 2016 13:39:46 +0000 (22:39 +0900)]
Update POST request handler of PSTAT resource

   1. Revert back the error handling for invalid pstat POST request.
   2. Add logic to check validation of 'om' when handle the POST request
   3. Fix incorrect logs
   4. Fix typo in samples.

Patch #1~#5 : Initial upload
Patch #6 : Update according to comments.

Change-Id: I5d1d003b4f622fb86010bad909b51fa648036a44
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
16 months agotizen: set verbose mode for building 73/9473/2
Philippe Coval [Tue, 19 Jul 2016 16:23:17 +0000 (18:23 +0200)]
tizen: set verbose mode for building

Change-Id: If87868e716291445df754b7e567f87e49c444cce
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
16 months agotizen: defines plaform for logger 71/9471/2
Philippe Coval [Tue, 19 Jul 2016 16:23:18 +0000 (18:23 +0200)]
tizen: defines plaform for logger

Fix Fail to build for sources :

  sampleserver_justworks.cpp:(.text+0x234): \
    undefined reference to `OCLog'

May be squashed into :

  https://gerrit.iotivity.org/gerrit/#/c/9311/

Change-Id: Ib721633c982aa28ec5d72dd1bd84cad7115b179c
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
16 months agotizen: Bump to 1.1.1 09/9509/2
Philippe Coval [Fri, 1 Jul 2016 21:45:20 +0000 (23:45 +0200)]
tizen: Bump to 1.1.1

Change-Id: I0a5a0ba9c8d1f82af01e7ed9bae54209af67e582
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9093
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 89babb026f86de27de29fe72b54e7224976eaee0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9509
Reviewed-by: Uze Choi <uzchoi@samsung.com>
16 months agoBuild: add gtest libs automatically 47/9447/2
Philippe Coval [Mon, 18 Jul 2016 19:56:20 +0000 (21:56 +0200)]
Build: add gtest libs automatically

Once gtest's sconfile is imported, build flags are propagated.

This change is part of a massive cleanup change:

  https://gerrit.iotivity.org/gerrit/#/c/249/

Problem was observed with g++-4.8.4 (Ubuntu 14.04.4)
 which needs pthread to be after gtest on cmdline :

  g++ -o out/linux/x86_64/debug/service/resource-encapsulation/src/resourceBroker/unittest/broker_test  \
  (...) \
  -L. -lcoap -lc_common -llogger -ldl -lpthread -lrt -luuid -lroutingmanager -lboost_thread -lboost_system -lconnectivity_abstraction -loc_logger -loctbstack -loc -lrcs_client -lrcs_common -lgtest -lgtest_main

  /usr/bin/ld: extlibs/gtest/gtest-1.7.0/lib/.libs/libgtest.a(gtest-all.o): \
    undefined reference to symbol 'pthread_key_delete@@GLIBC_2.2.5'
  /lib/x86_64-linux-gnu/libpthread.so.0: \
    error adding symbols: DSO missing from command line

Bug: https://jira.iotivity.org/browse/IOT-863
Bug-AGL: https://jira.automotivelinux.org/browse/SPEC-158
Change-Id: I7a0b0e1c9c1760fd29694fafec5befa1d4245eb1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9447
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
16 months agotizen: also support ARMv7 machine 41/6141/13
Philippe Coval [Sat, 12 Dec 2015 01:05:32 +0000 (01:05 +0000)]
tizen: also support ARMv7 machine

It was successfully tested on :

* Tizen:2.4:Mobile profile (TM1 and Samsung Z1)
* Tizen:2.3:Wearable profile (GearS)

Change-Id: I9e43f35ed2fa18e7dc691f1f5cbfa9a2e4830aad
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
16 months agoRD Payload memory handling 31/9431/2
Habib Virji [Mon, 4 Jul 2016 16:04:26 +0000 (17:04 +0100)]
RD Payload memory handling

By default 255 bytes of memory is allocated for the payload, when it need
extra amount of memory, cbor library provides a size member that keeps incrementing
but no memory is allocated or written.

In case of failure this value is passed to the ocpayloadconvert.c, which allocates
the right size and calls the conversion function again. It is necessary to allow the
code to get the right size.

Change-Id: I92202a91780fcf01d4ff8fea0a3c194ac5a42e83
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 05250eb740e5313c170a6f74b21c9621856bbf36)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9431

16 months agoUpdated InProcClientWrapper to handle OC_STACK_RESOURCE_CHANGED error code. 15/9415/2
G S Senthil Kumar [Fri, 15 Jul 2016 13:46:06 +0000 (19:16 +0530)]
Updated InProcClientWrapper to handle OC_STACK_RESOURCE_CHANGED error code.

OC_STACK_RESOURCE_CHANGED will be sent in the response for POST requests.
This should also be considered as a success response for POST.

Change-Id: I1b8bc97ab5df21cbf06c1cbb9fd43b38d1730379
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9415
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
16 months agoFixed to prevent a UPDATE request on read-only property 49/9249/10 1.1.1-RC2
Randeep Singh [Fri, 15 Jul 2016 10:20:15 +0000 (15:50 +0530)]
Fixed to prevent a UPDATE request on read-only property

Fix doxm and pstat resource handler in order to prevent the modification on read-only properties.

Patch #1: Initial patch
Patch #2: Fix Ownership Transfer fail
Patch #4: Rebased to latest 1.1-rel
Patch #5: Rebase
Patch #6: Fix on CT fail during Ownership Transfering as well as gerrit comments
Patch #7: Fix on CT fail
Patch #8: Fixed arduino build error

- CAUTION - : DO NOT Merge this patch before completing tests.

Change-Id: Ie709ac0023aeec979de0de545a10ec165c0b5278
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9249

16 months agoUpdate ACL post request handler according to current POST usage of OCF spec. 85/9385/4
Chul Lee [Thu, 14 Jul 2016 05:33:06 +0000 (14:33 +0900)]
Update ACL post request handler according to current POST usage of OCF spec.

Patch #1 : Initial upload.
Patch #2 : Update to support both POST usage(Replace/Append)
Patch #3 : Remove the compile errors for arduino.

Change-Id: Ic83bc0c19255c443d768bea03337823177b531c9
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoChanged the Policy key name for TCP Discovery 43/9343/6
hyuna0213.jo [Tue, 12 Jul 2016 23:06:46 +0000 (08:06 +0900)]
Changed the Policy key name for TCP Discovery

If the devices can be accessed via TCP, then the "tcp" key indicates
the assigned tcp port number.
The name of "tcp" key was changed from "tcp" to "x.org.iotivity.tcp".

Change-Id: I509c0f35c6703f6eae45ce6c421df6afaa97a13f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9343
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
17 months agoFix GET ocresource response for /oic/d 53/9353/2
Habib Virji [Tue, 12 Jul 2016 11:11:12 +0000 (12:11 +0100)]
Fix GET ocresource response for /oic/d

If an application does not set oic.wk.d, set in savedDeviceInfo to get proper response for GET message.

Change-Id: I028b821ffe29b467d0ecc2add9a7a6ebfff5e72d
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9309
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
(cherry picked from commit fdbdbceee131f8c39af5af7e61a2b87876e6f26d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9353

17 months agoChange name of dpc to x.org.iotivity.dpc 07/9307/4
Jongmin Choi [Tue, 12 Jul 2016 11:06:03 +0000 (20:06 +0900)]
Change name of dpc to x.org.iotivity.dpc

vendor-specific name for dpc changed to "x.org.iotivity.dpc"

Patch #1: Initial upload
Patch #2: DAT files updated
Patch #3: CREATE->CHANGE for Direct Pairing

Change-Id: I06c160caf78722bfdc452dd886d89350203a79a9
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9307
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
17 months agoChange OC_EH_RESOURCE_CREATED to OC_EH_CHANGED in the post hanlder of security resources. 27/9327/4
Chul Lee [Tue, 12 Jul 2016 18:03:43 +0000 (03:03 +0900)]
Change OC_EH_RESOURCE_CREATED to OC_EH_CHANGED in the post hanlder of security resources.

Change-Id: Ib2d4bc30e99589d7630d33d2fa5557e25df70db7
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9327
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoModify incorrect cbor map size in credential resource. 25/9325/2
Chul Lee [Tue, 12 Jul 2016 17:44:49 +0000 (02:44 +0900)]
Modify incorrect cbor map size in credential resource.

Change-Id: Idce32a9bd6f5cc210139b7cdefc0c203d01c0488
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9325
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoBuild: reworked unit tests to use gtest in a more generic way 49/9149/5
Philippe Coval [Mon, 4 Jul 2016 12:56:55 +0000 (14:56 +0200)]
Build: reworked unit tests to use gtest in a more generic way

The benefit of this change is to keep most gtest related configuration
 in a single file and avoid to duplicate paths in sub sconfiles.

For portability concern "os.path.join" is preferred
 to appending unix paths.

Some libs are reordered and some cleanup was done.

Let's also remove hardcoded pathes, as there is not guarantee
 that the files will remain at the same place in all configurations.

Problem was observed when crossbuilding with Yocto distro
 with security checks enabled (LfAgl).

More refactoring and deeper cleanup might come in later patch.

Backport from master branch.

Change-Id: Ia13ee8c03f65f3407e88ff21d51b292261c9f2a3
Bug: https://jira.iotivity.org/browse/IOT-863
Bug-AGL: https://jira.automotivelinux.org/browse/SPEC-158
Origin: https://gerrit.iotivity.org/gerrit/#/c/8127/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
17 months agoResponse CREATED changed to CHANGED 17/9317/2
Jongmin Choi [Tue, 12 Jul 2016 13:40:17 +0000 (22:40 +0900)]
Response CREATED changed to CHANGED

Responses to POST requests changed from CREATED to CHANGED

Patch #1: Initial upload

Change-Id: I3574d377042dfdee55a4a2f65c2ea4d6d9f7457e
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9317
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
17 months agoAdd support of 'OC_STACK_RESOURCE_CHANGED' return code. 13/9313/2
Ziran Sun [Mon, 11 Jul 2016 13:38:00 +0000 (14:38 +0100)]
Add support of 'OC_STACK_RESOURCE_CHANGED' return code.

This is to map 'UPDATE' or 'CHANGED' code in coap.

JIRA Issue: https://jira.iotivity.org/browse/IOT-1191

Change-Id: Ic5b426cbb1560a989305a600070a77dbe90f01e1
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9313
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
17 months agoAdding rt and if into response of Get request to cred and acl 05/9305/3
Chul Lee [Tue, 12 Jul 2016 10:32:03 +0000 (19:32 +0900)]
Adding rt and if into response of Get request to cred and acl

Issue: Response of GET request to /oic/sec/cred & pstat resource has problem
       (no "rt" and "if" property)
       Per the core spec, every Resource shall have both rt and if.
Solution : Adding rt and if into response payload of Get request to acl and cred

* NOTE : This patch was generated by JongSung Lee.

Change-Id: I9233be8498e1641f05ce9f5e9626825d5ce0ad62
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9305
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
17 months agoUse the IANA assigned IPv6 multicast addresses for "All OCF Nodes". 91/9291/2
Stephane Lejeune [Mon, 11 Jul 2016 15:31:38 +0000 (17:31 +0200)]
Use the IANA assigned IPv6 multicast addresses for "All OCF Nodes".

In order to avoid processing incompatible messages with CoAP application
syntax in constrained devices, OCF has registered its own IPv6 multicast
address. This patch changes the IPv6 multicast address used for
discovery and group messages from “All CoAP Nodes” to “All OCF Nodes”.
See
http://www.iana.org/assignments/ipv6-multicast-addresses/ipv6-multicast-addresses.xhtml

Change-Id: I2bb16e8d927e6c77f69ee55d487736f30f8073b8
Signed-off-by: Stephane Lejeune <stlejeun@cisco.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9291
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Sungkyu Ko <sungkyu.ko@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
17 months agoPrevent restore of doxm/pstat resource 73/9273/4
Chul Lee [Mon, 11 Jul 2016 05:10:21 +0000 (14:10 +0900)]
Prevent restore of doxm/pstat resource
in case of owned status and retransmission.

[Patch #1] : initial upload
[Patch #2] : Update pstat resource same as doxm/cred

Change-Id: I33dbf272753ef79ad4f79c62296154500dc67e14
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9273
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoBuild: disable shared library of gtest as suggested 51/9151/5
Philippe Coval [Mon, 4 Jul 2016 11:58:15 +0000 (13:58 +0200)]
Build: disable shared library of gtest as suggested

As suggested by Jon A. Cruz "
 "GTest in general is more focused away from the shared.
  System-wide pre-compiled shared libs were deprecated a while back.
  Sets of programs built at the same time *might* be OK
  with a local shared version,
  but static linkage makes it safer."

So this patch explicitly disable dynamic library of gtest,
it can be reverted on trouble as there is no "hard requirement" for it.

For the record, I came to this once I noticed
that using default shared library
caused troubles on some Yocto distros (LfAgl) :

  relocation R_X86_64_PC32 \
  against undefined hidden symbol
  `__init_array_start'
  can not be used  ...

I suspect this problem is not related to gtest or iotivity.

Bug: https://jira.iotivity.org/browse/IOT-863
Bug-AGL: https://jira.automotivelinux.org/browse/SPEC-158
Change-Id: I9e4798aa3a579020255e8f53a8da8926dc4dee4f
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9147
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
(cherry picked from commit 1c9e619998d38e36045b465f0784ae999610e819)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9151
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months agoModified Scene UnitTest 05/9205/3
ChaJiWon [Wed, 6 Jul 2016 04:23:24 +0000 (13:23 +0900)]
Modified Scene UnitTest

Scene container is changed to unordered_map in SceneCollection.
Apply the change to 'getAllSceneInstance' logic.

Change-Id: I48916883b115c7eb57cfe63d1ae55d6d2ee1c430
Signed-off-by: ChaJiWon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9205
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
17 months ago[I0T-1159] Resolved twice response issue 51/9251/4
js126.lee [Fri, 8 Jul 2016 08:55:09 +0000 (17:55 +0900)]
[I0T-1159] Resolved twice response issue

Issue : The server is responding with both 4.00(ACK) & 5.00(CON) error message
Solution : If SendSRMResponse succeed, return OC_EH_OK to OCStack

Patch1: Init
Patch2: Apply review comment
Patch3: Change file mode

Change-Id: I70e2b3e0a703cd137a9244097e128b3ecbed5c77
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9251
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
17 months agoFixed issue where "oic.wk.d" was removed from array of device types. 03/9103/2 1.1.1-RC1
Joseph Morrow [Sat, 2 Jul 2016 23:33:39 +0000 (16:33 -0700)]
Fixed issue where "oic.wk.d" was removed from array of device types.

Change-Id: I54ee75be4e7bbb9ce4de2b656dabff4c6386d58f
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9103
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months agoUpdated version to 1.1.1 39/9239/2
Randeep Singh [Fri, 8 Jul 2016 05:14:56 +0000 (10:44 +0530)]
Updated version to 1.1.1

Change-Id: I97793b9176039655d2f010a1776806cdeaf0930f
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9239
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months ago[IOT-1133] Fix size setting for CA URI buffer 81/9181/2
Inga Stotland [Wed, 29 Jun 2016 06:15:33 +0000 (23:15 -0700)]
[IOT-1133] Fix size setting for CA URI buffer

Use common define CA_MAX_URI_SIZE instead of hardcoded magic number

Change-Id: I61f6f39d1646166be92775e25419c1749f946c76
Signed-off-by: Inga Stotland <inga.stotland@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 51d5f10fbbc1a98e1ee722bd17fb694e1bf875cc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9181
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months ago[IOT-1185] Add OCResultToSuccess to ensure success. 31/9231/2
Jaehong Jo [Thu, 7 Jul 2016 12:47:53 +0000 (21:47 +0900)]
[IOT-1185] Add OCResultToSuccess to ensure success.

If just check only OC_STACK_OK, it can cause problems.
Below value is success like OC_STACK_OK.
OC_STACK_RESOURCE_CREATED,
OC_STACK_RESOURCE_DELETED,
OC_STACK_CONTINUE.

BUG : https://jira.iotivity.org/browse/IOT-1185

Change-Id: I60b369138df00b98c4dbeb952ffba140aa902b27
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9231
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months ago[IOT-1179] Adding rt and if into response of Get request to doxm and pstat 07/9207/2
js126.lee [Tue, 5 Jul 2016 08:04:46 +0000 (17:04 +0900)]
[IOT-1179] Adding rt and if into response of Get request to doxm and pstat

Issue: Response of GET request to /oic/sec/doxm resource has problem(no "rt" and "if" property)
       Per the core spec, every Resource shall have both rt and if.
Solution : Adding rt and if into response payload of Get request to doxm and pstat

Patch1,2 : Apply patch
Patch 3,4,5: Apply dongik's review

Change-Id: I6f9ad75194f9baa6c9dda25f742e38b790cd6cb7
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 922c3364ab8c680a366136ad6a27451a60089e90)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9207

17 months agoChange request method to POST on updating cred in OTM 95/9195/3
js126.lee [Tue, 5 Jul 2016 06:10:18 +0000 (15:10 +0900)]
Change request method to POST on updating cred in OTM

the issue is that the /cred resource will actually exist, just will have no creds in it (empty array).
So this is really an UPDATE, to update the "creds" property of the oic.r.cred resource.
Once CTT has changed to POST on OTM, OC_REST_PUT case will be removed in CredEntityHandler

Patch1: apply patch
Patch2: Add comment

Change-Id: Iaa4b7d72e5855575be1f91b48997ee445941df03
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit c2673aea5ef37ec6f6711eeeb6ea2cdf5b370911)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9195
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
17 months agoUpdate ACL and dpc property to resolve the spec gab. 19/9219/5
Chul Lee [Thu, 7 Jul 2016 13:45:32 +0000 (22:45 +0900)]
Update ACL and dpc property to resolve the spec gab.

This patch includes patch below :
    1. Update ACL data-structure based on RAML spec.
       https://gerrit.iotivity.org/gerrit/#/c/8241/
    2. Change the name of dpc property of doxm to the vendor-defined name
       https://gerrit.iotivity.org/gerrit/#/c/9197/

[Patch #1] Initial upload
[Patch #2] Fix the OTM unittest
[Patch #3] Update missed *.json files
[Patch #4] Fix typo

Change-Id: I74ad8baad14914a4fae11fda3ab57f1f27c4acfc
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agotizen: Bump to 1.1.1 91/9091/2
Philippe Coval [Thu, 23 Jun 2016 19:52:14 +0000 (21:52 +0200)]
tizen: Bump to 1.1.1

Change-Id: I4ba6addba481b3180f6ebb6969caf86115589c48
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8953
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 1fa4a7f1d533ed08eca8271141038d28d82d3ef4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9091
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months agoBuild: Bump version to 1.1.1 85/9185/2
Philippe Coval [Tue, 5 Jul 2016 16:32:57 +0000 (18:32 +0200)]
Build: Bump version to 1.1.1

To generate correct iotivity.pc

Bug: https://jira.iotivity.org/browse/IOT-1117
Change-Id: I9e671c151044c3336edc576b2ee5f093872c2027
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months agotizen: deploy gtest file to be included by unittests 55/9155/3
Philippe Coval [Tue, 7 Jun 2016 08:24:28 +0000 (10:24 +0200)]
tizen: deploy gtest file to be included by unittests

Note, currently unit testing is not done on Tizen,
 but only on GNU/Linux and Darwin (OSX).

Change-Id: Ifaf020bdf23fba3f0922f38f260e81b7481930dc
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 1d9eb84071b9db4f0d84a719b1ebfdfd791cc7ae)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9155
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
17 months agoDisable OC_SECURE flag in case of SECURED=0 build. 71/9171/2
Chul Lee [Wed, 22 Jun 2016 12:19:17 +0000 (21:19 +0900)]
Disable OC_SECURE flag in case of SECURED=0 build.

Change-Id: I53b8a05fc1bc84ea9b32bd8c5c312616b7c3f5c6
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8875
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 9694e5f50d12fa462db107210528b526b42f3f3e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9171
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
17 months ago[IOT-986] Not send response to multicast message for resource not existing 73/9173/2
Habib Virji [Fri, 1 Jul 2016 14:09:57 +0000 (15:09 +0100)]
[IOT-986] Not send response to multicast message for resource not existing

The resource not existing, it should not return any response for multicast packet.
There was no check for multicast request, this has been added and it does not send
any response.

Also add OC_MULTICAST type in octypes.h.
octypes.h transport flag should correspond to flags set in the CA layer. In the CA
layer (1 << 7), 7 bit is set for Multicast. In the RI layer, the type were differing,
hence was not possible to check if it is multicast packet. Please note the OC_RESERVED1
was not used anywhere and was wrong, it should match the transport flag of the CA layer.

BUG: http://jira.iotivity.org/browse/IOT-1126,
     http://jira.iotivity.org/browse/IOT-1107,
     http://jira.iotivity.org/browse/IOT-986

Change-Id: Ia8a7d1bdacf4e9a8a8d6cb21c49ad830cce7c3cc
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9173
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months ago[IOT-1097] Fixed bug related to dpc property in doxm 69/9169/2
js126.lee [Tue, 5 Jul 2016 08:32:48 +0000 (17:32 +0900)]
[IOT-1097] Fixed bug related to dpc property in doxm

Issue : There is bug when handling dpc property
Solution : If PUT/POST payload do not has dpc in doxm, iotivity server keep own dpc value.
Related jira : https://jira.iotivity.org/browse/IOT-1097
cherry-pick https://gerrit.iotivity.org/gerrit/#/c/8313/ of master branch.

Change-Id: I474be742b39c907fcefdc4ad66de975c2bed206a
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9169
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoClean up compiler warnings 55/9055/3
George Nash [Mon, 27 Jun 2016 16:56:01 +0000 (09:56 -0700)]
Clean up compiler warnings

ocresource.c: (-Wunused-variable)
Fix the waring by moving the tcport inside the #ifdef

amsmgr.c (-Wunused-variable)
b64Ret, outLen, and base64Buff were all local variables that were
unused. They are removed since they are unused.

amaclresource.c (-Wunused-function)
OicSecAmaclCount function is unused anywhere. Since it is unused
it is not being maintained so it was removed.

Change-Id: Ia0327aec1feb484f084b2ce0d6608738ef5f6ad9
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8969
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit eef1bb6254b254669127b7430bf4f80d7a6a9739)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9055

17 months agoPrevent the duplicate PIN output in case of retransmission message. 63/9163/2
Chul Lee [Thu, 23 Jun 2016 00:56:49 +0000 (09:56 +0900)]
Prevent the duplicate PIN output in case of retransmission message.

[Patch #1] Initial upload.

Change-Id: I3f69865a5fccaef9775d0200c0afaa7ce7247c20
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6b15edb6deb7968ca3b307da62cec50158ba7551)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9163

17 months agoFixed the missed returned_length on |credresource| 29/9129/2
Kyungsun Cho [Mon, 4 Jul 2016 08:34:08 +0000 (17:34 +0900)]
Fixed the missed returned_length on |credresource|

Change-Id: I7098520a88c224f62c711917f3db1b139be064bf
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9129
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoocpayload: in DMV remove undesired trailing separator 31/9131/2
Philippe Coval [Fri, 1 Jul 2016 20:58:37 +0000 (22:58 +0200)]
ocpayload: in DMV remove undesired trailing separator

Also add more tests cases too.

Suggestion for improvements:

Note the test uses a different message container to prevent ambiguity:
 same one could be used but accessed at next indice
 because MessageContainer::setPayload
 actually adds given payload to internal list.

It would makes sense to rename method to MessageContainer::addPayload
 and eventually add a new different method like :
 MessageContainer::set(Payload) to reset list.

Bug: https://jira.iotivity.org/browse/IOT-1174
Change-Id: I9e7bf3c9eb7a311214e438ec2434d53b4ae0f313
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9131
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
17 months agoFix issue where double array was not fetched from CBOR correctly. 05/9105/2
Joseph Morrow [Sat, 2 Jul 2016 23:17:51 +0000 (16:17 -0700)]
Fix issue where double array was not fetched from CBOR correctly.

Change-Id: I7d7f9ac4fe216d883ddb26d624136d098a8a7a14
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9105
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
17 months agoFixed Security Resource Flags and Interface 59/9059/2
Jongmin Choi [Fri, 24 Jun 2016 09:33:22 +0000 (18:33 +0900)]
Fixed Security Resource Flags and Interface

OCResourceProperty Fixed for Following Security Resources
- doxm: OC_OBSERVABLE Removed
- cred, pstat: changed from OC_RES_PROP_NONE to OC_SECURE

Patch #2: OC_DISCOVERVABLE added to pstat
Patch #4: oic.mi.def removed

Change-Id: I35978a242636754977724045780af0082562b525
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8951
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 333df2714d4c6cc451b038dd9cd989264a60d1f2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9059

17 months agoFixed svase-warnings for iotivity-product's SQA on |credresource| 63/9063/2
Kyungsun Cho [Fri, 1 Jul 2016 04:49:55 +0000 (13:49 +0900)]
Fixed svase-warnings for iotivity-product's SQA on |credresource|

Change-Id: I48452b2b0e634d2d7b6cf7643ba9a27ede4877e5
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9063
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoRemove the endianness dependency in cbor conversion. 53/9053/2
Chul Lee [Wed, 22 Jun 2016 03:40:21 +0000 (12:40 +0900)]
Remove the endianness dependency in cbor conversion.

A similar bug reported from https://gerrit.iotivity.org/gerrit/#/c/8755/

Change-Id: I631bab77f7486f1f45eaff96c67d39606e37c6b6
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8829
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hauke Mehrtens <hauke.mehrtens@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 24474a8d2555229efb425b6cb63e19b3279ba810)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9053

17 months agoSvace Defects Fixes. 51/9051/2
Vinay Bhatia [Wed, 29 Jun 2016 12:41:07 +0000 (18:11 +0530)]
Svace Defects Fixes.

Removed Tab and extra space.

Fixed Remaining Defects.

Fixed Defect in provisioning/unittest/otmunittest.cpp

Change-Id: I1d163b1a39fe858323c5c799f9e26ba6a1a3f620
Signed-off-by: Vinay Bhatia <vinay.bhatia@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9031
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 153cb2647598cbff08e50f9eccdc480b7f59c745)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9051

17 months agoChange observe option header behaviour to be in line with spec 47/9047/2
Ziran Sun [Tue, 21 Jun 2016 13:30:35 +0000 (14:30 +0100)]
Change observe option header behaviour to be in line with spec
at the following points:

1. If the resource can't register the client as observer,
or the resource does not support observe, then the resource
sends back normal GET Response with NO observe option field.

2. Upon successfully removing the client from observer list,
the resource sends back a normal GET response with NO observe
option field

3. This patch also reverted https://gerrit.iotivity.org/gerrit/#/c/8901/
after discussed with the author to be inline with spec.

JIRA issue: https://jira.iotivity.org/browse/IOT-1122

Change-Id: I36510baa69a8ef3be9e0d9aef3fbd40d31488b0f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8815
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
(cherry picked from commit ed9352f40b86c8d6c7e5f7732d4f68498ec69460)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9047

17 months agoFixed SVACE report defects. 49/9049/2
i.pazderskyy [Wed, 29 Jun 2016 11:25:41 +0000 (14:25 +0300)]
Fixed SVACE report defects.

Change-Id: I90bef9beb9619b1fba1ce03f96a6873d6fc31594
Signed-off-by: i.pazderskyy <i.pazderskyy@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9029
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4aa491c7251cfea0a4bce740503f5ded6f4d9cf4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9049

17 months agoFixed policy response in /oic/res discovery 17/9017/2
Jongmin Choi [Tue, 28 Jun 2016 08:02:20 +0000 (17:02 +0900)]
Fixed policy response in /oic/res discovery

Added "sec": false to response in case of unsecure resource
Removed "port" information in case of unsecure resource

This patch is based on the Core Spec CR on resource policy.
If "sec" is false, it may or may not be included in /oic/res discovery response.
If "sec" is false, "port" shall be omitted in the response.
This patch should be used together with
Disable OC_SECURE flag in case of SECURED=0 build patch
(https://gerrit.iotivity.org/gerrit/#/c/8875/)

Change-Id: I8e0f3b39896c8856ab659f966e1227196e0f2153
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8987
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit ec2bcb63d5319f71409ba04e565b165c9c43525d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9017

17 months agoocpayload: Set default DMV values and only use comma as delim 33/9033/2
Philippe Coval [Mon, 27 Jun 2016 21:33:40 +0000 (23:33 +0200)]
ocpayload: Set default DMV values and only use comma as delim

For IoTivity-1.1.1: "res.1.1.0,sh.1.1.0" are used
as default Data Model Versions.

Now only use ',' as CSV separator (so ';' must be avoided).

This change has been tested on Debian jessie
and can be squashed into :

https://gerrit.iotivity.org/gerrit/#/c/8707/

Bug: https://jira.iotivity.org/browse/IOT-1101
Change-Id: I8e79776a8fc6c6112db9d5a9ab9a2008e9ea426e
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8973
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 9b99c1aab222637e5f8e24c43458651bd1767411)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9033

17 months agoDiscard provisioning tool reply for owned device discovery 03/9003/2
Sandeep Sharma [Fri, 27 May 2016 11:30:40 +0000 (17:00 +0530)]
Discard provisioning tool reply for owned device discovery

[Patch #1] fix C provisioning client as now PT's reply won't come
           for owned device discovery.

Change-Id: Ica5a66166c589282e99a3fd6c60bfd68b79013f6
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1fc38daf68ac36cb150dcdc39faea1b641928b5c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9003

17 months agoocpayload: Supports multiple data model versions (DMV) using CSV 01/9001/3
Phil Coval [Thu, 16 Jun 2016 08:25:44 +0000 (10:25 +0200)]
ocpayload: Supports multiple data model versions (DMV) using CSV

DMV can be CVS if multiple values are supplied.

OIC 1.1 has a single value but future spec is expected to have multiple values

For more details about this specification please refer to:

  20160531-OIC_Core_Specification_v1.1.0_r0.13.docx
  Section 11.3.4,
  Table 18 for property description
  & Section D.3.4 for RAML definition.

For now it's supporting simple patterns like "one-1,two-2"
In the longer term a full implementation of rfc4180 might be desired.

Internally those items are stored in OCStringLL (linked list of strings),
and later it would make sense to relocate those helper functions
in a common place.

This change has been tested on Tizen:3.0:IVI

Bug: https://jira.iotivity.org/browse/IOT-1101
Change-Id: I7274d74ba525aedda49b78398743aa24a7999c00
Signed-off-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8707
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
(cherry picked from commit 00380c6e4145bf0f084b235bc153c9617093efe5)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9001

17 months agoJira Issue-964: Add more types for OCEntityHandlerResult 21/9021/4
Habib Virji [Tue, 28 Jun 2016 10:09:09 +0000 (11:09 +0100)]
Jira Issue-964: Add more types for OCEntityHandlerResult

OCEntityHandlerResult includes more type that matches with
CAResponseResult_t.

This patch does not modify the return value of the exisitng code
and neither changes the enum value of the existing code.
It appends to the existing list based on the CoAP return values.

Change-Id: I2be12bb5f80ab751c9afc4e89c48446479c8f565
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8991
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 1ee5b8d93173f469c061dfa0c6cc8d88aa3f2242)
Reviewed-on: https://gerrit.iotivity.org/gerrit/9021

17 months ago[JIRA-1151] IoTivity Blockwise transfer is sort of broken when 13/9013/3
hyuna0213.jo [Wed, 29 Jun 2016 05:03:55 +0000 (14:03 +0900)]
[JIRA-1151] IoTivity Blockwise transfer is sort of broken when
paired with slow response

- When a resource is set as slow response resource,
and it has a large enough payload to be sent as blockwise
transfer data, and a CON retrieve message is sent to the resource,
the coap messaging mechanism break down.
- Remove the unnecessary code

Change-Id: I4bfabc4f457f637a8a88e6c237c25831c7b6c776
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8895
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9013

17 months agoChange resource type of /oic/res from string to array. 63/8963/2
Ziran Sun [Thu, 23 Jun 2016 10:18:45 +0000 (11:18 +0100)]
Change resource type of /oic/res from string to array.

JIRA Issue: https://jira.iotivity.org/browse/IOT-1131

Change-Id: I91f77f806ed7feb290fea0aa1b12f76a3b119442
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8921
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
(cherry picked from commit 9ebf006a9118872586d6de1da718006c19ff914f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8963

17 months agoRemove double checking type in credential data 47/8947/2
js126.lee [Wed, 22 Jun 2016 11:53:10 +0000 (20:53 +0900)]
Remove double checking type in credential data

Remove double checking type in credential data

Patch 1,2: Remove double checking type in credential data

Change-Id: Ibb532700dff39e1f4ef261de7dda15a48e782d61
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit f84babec1adc66512e9deb6bf626326608a864ff)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8947

17 months agoChange CARemovePeer condition when DTLS is closed 45/8945/2
js126.lee [Fri, 24 Jun 2016 07:17:53 +0000 (16:17 +0900)]
Change CARemovePeer condition when DTLS is closed

In order to align with tinydtls, this patch have modified that
CARemovePeer is called in below condition.
(DTLS_ALERT_LEVEL_FATAL == level || DTLS_ALERT_CLOSE_NOTIFY == code)

Change-Id: Ia8c9d6294973416e01714dad35fe239907eba48c
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8943
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6768322b280aea23dff049bb489588a2621e09fb)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8945

17 months agoImplementation for Direct Pairing Android Interface API and Sample App. 49/8949/2
Sandeep Sharma [Mon, 23 May 2016 09:33:33 +0000 (15:03 +0530)]
Implementation for Direct Pairing Android Interface API and Sample App.

1. Android Interface API's for direct Pairing feature.
2. Android Sample App for Direct Pairing.

[patch #2]
Commnts fixes.
Add Support for direct Pair provisioning in ProvsioningClient Android sample
app.

[Patch #3]
Build Fix.

[Patch #4]
Review comments addressed.

Change-Id: I09572eb8cb54f7cd122c6eb224ac2abbcb1ec530
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8281
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6533783c3270d5441c4340492f80c20847e584d3)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8949

17 months ago Merging changes of https://gerrit.iotivity.org/gerrit/#/c/8633 from master to 1.1 71/8871/3
sahil bansal [Wed, 22 Jun 2016 11:15:40 +0000 (16:45 +0530)]
 Merging changes of https://gerrit.iotivity.org/gerrit/#/c/8633 from master to 1.1

Change-Id: I8ce6410fc361fa215051ae0f6d4b8c742f9526c7
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months ago merging https://gerrit.iotivity.org/gerrit/#/c/8527 from master to 1.1 69/8869/2
sahil bansal [Wed, 22 Jun 2016 10:56:24 +0000 (16:26 +0530)]
 merging https://gerrit.iotivity.org/gerrit/#/c/8527 from master to 1.1

Change-Id: I6f73f0bb9d4196f9f911abd04cccf3178e847d73
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8869
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoMerge code of https://gerrit.iotivity.org/gerrit/#/c/8565 from master to 1.1 67/8867/2
sahil bansal [Wed, 22 Jun 2016 10:42:23 +0000 (16:12 +0530)]
Merge code of https://gerrit.iotivity.org/gerrit/#/c/8565 from master to 1.1

Change-Id: Ia69ebbdb0cdba9de2f98f7e58258f61ad04ed197
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8867
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
17 months agoAdded UTC to cover uncovered APIs and Corrected build issue in credentialgenerator.h 41/8941/2
saurabh.s9 [Tue, 24 May 2016 12:17:38 +0000 (17:47 +0530)]
Added UTC to cover uncovered APIs and Corrected build issue in credentialgenerator.h
This patch is dependent upon https://gerrit.iotivity.org/gerrit/#/c/8813/
Change-Id: I49a9de85e04c47f0d9ebbfab99248cf58a998248
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 41b43bd645037676c38556b252200c6502db2e88)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8941

17 months agoUpdated and typo-fixed |SHA| API names on tinydtls module 33/8833/2
Kyungsun Cho [Thu, 19 May 2016 15:04:38 +0000 (00:04 +0900)]
Updated and typo-fixed |SHA| API names on tinydtls module

this change is for updating the fixed |tinydtls-sha| API names
and correcting the missed typo on its API names. this change
was reviewed finally by Mr. Olaf Bergmann and Mr. Craig Pratt,
who maintain |eclipse-tinydtls|.

Change-Id: I9d4eb21ab5d507726b2dda0b3f27bfa0264b0565
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Craig Pratt <craig@ecaspia.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 72e0dfc040f880078da776c3ece467e628e9951f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8833

17 months agoImplement missing unit tests for CKM. 47/8847/2
i.pazderskyy [Tue, 24 May 2016 15:34:25 +0000 (18:34 +0300)]
Implement missing unit tests for CKM.

Added CKM unit tests to common build.
Added result state to functions.
Change-Id: I11ef2d003f95d850ed395f5c2584bbb34ca154a4
Signed-off-by: i.pazderskyy <i.pazderskyy@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit c2b7d54fdd4c59e3422d2ff635475eca0d7dec80)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8847

17 months agoCheck for NULL parameter 09/8909/2
saurabh.s9 [Tue, 21 Jun 2016 06:49:25 +0000 (12:19 +0530)]
Check for NULL parameter

Change-Id: I27b316b11f0362deeaff2de8e06ffc296759411d
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8813
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit b9cbeb8577a6598b963f33113f784f059291e955)
Reviewed-on: https://gerrit.iotivity.org/gerrit/8909