iotivity.git
17 months ago[IOT-3075] Aborting TCP connect operation 63/25463/6
koushik.girijala [Fri, 25 May 2018 10:12:34 +0000 (15:42 +0530)]
[IOT-3075] Aborting TCP connect operation

Aborting TCP connect operation during IP disconnect and Adapter stop

Change-Id: If6a51416f90be533ebdd70096781c3d094512752
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
17 months agoAdd 'webos' into the target OS list 35/23935/67
sungmok.shin [Mon, 15 Jan 2018 09:52:29 +0000 (18:52 +0900)]
Add 'webos' into the target OS list

- TARGET_OS "webos" is added
- IP adapter for network monitoring is implemented
- Introduce PmLog for IoTivity over webos
- Provisioning library is included
- Crash with iotivity-node application is fixed
- Build error due to RD_MODE=all is fixed
- ACG (Access Control Group) configuration file for
  sample application is added
- Procedure for registering/Unregistering luna service
  is implemented
- Internal function for getting LSHandle is implemented
- ocserverbasicops & occlientbasicops for webos
  is implemented (built from separate folder)
- IoTivity sampler(iotivity-node) for webOS is implemented
- Set native application path to /usr/palm/services

Bug: https://jira.iotivity.org/browse/IOT-2967
Change-Id: I3f4f143e7f528e873e5758410e226d98b2679151
Signed-off-by: sungmok.shin <sungmok.shin@lge.com>
17 months ago[IOT-3083] IUT crash while batch update by href 35/25735/3
Biman Paul [Fri, 8 Jun 2018 10:25:03 +0000 (15:55 +0530)]
[IOT-3083] IUT crash while batch update by href

IUT crash occured while executing CTT Server Testcase 1.2.13
Batch update by href. Double free occured for server request
handle. Once in HandleSingleResponse() and another in
HandleAggregateResponse().
6  0x00007ffff705f452 in OICFree (ptr=0x7fffd400d6f0)
    at resource/c_common/oic_malloc/src/oic_malloc.c:150
7  0x00007ffff729da8e in DeleteServerRequest (serverRequest=0x7fffd40008c0)
    at resource/csdk/stack/src/ocserverrequest.c:412
8  0x00007ffff729eaf1 in HandleAggregateResponse (ehResponse=0x7fffe8dcc450)
    at resource/csdk/stack/src/ocserverrequest.c:892

Change-Id: I69ca3d5a0fe59626b545047530b68fd0cfdd27ad
Signed-off-by: Biman Paul <biman.paul@samsung.com>
17 months agoFix:Added default target_os for tizen 65/24465/3
Sanjay Kumar [Fri, 23 Mar 2018 08:59:55 +0000 (14:29 +0530)]
Fix:Added default target_os for tizen

Change-Id: I9599855e1e88d0c4af95d822373ddf4352ec1265
Signed-off-by: Sanjay Kumar <sanjay@graniteriverlabs.in>
17 months agoUpdate java/scons version check 85/25785/1
Mats Wichmann [Tue, 12 Jun 2018 14:25:04 +0000 (08:25 -0600)]
Update java/scons version check

Java 9/10 still not supported in scons 3, but at least
print more updated information.

Change-Id: Ic4948540fa0a9aaa7ef0c98b4a3774d8ea557972
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months agoFix PATH not append to env on windows. 11/22311/5
Ricky He [Mon, 4 Sep 2017 08:26:42 +0000 (01:26 -0700)]
Fix PATH not append to env on windows.

Change-Id: I26688494a209cbc320fbb79eb18a957ec3ce8999
Signed-off-by: Ricky He <timemanager.rick@gmail.com>
17 months agoFix rapidjson build for gcc8 another way 07/25707/2
Mats Wichmann [Thu, 7 Jun 2018 15:00:15 +0000 (09:00 -0600)]
Fix rapidjson build for gcc8 another way

Uplifiting rapidjson version apparently not sufficient,
so do a temporary fix to disable Werror.

Also changed link to point to official github location.

Change-Id: I762636f3185c3d75b28aad237da69ba9cf0c6884
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months agofix compilation failure on VS2017 73/25473/7
George Nash [Fri, 25 May 2018 22:02:33 +0000 (15:02 -0700)]
fix compilation failure on VS2017

In the latest build of Visual Studio 2017 will
produce a build waring when encountering any code
in the str::tr1 namespace. The warning is produced
when headers from the external googletest framework
are included in the build.

Adding the _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
macro will cause the build to ignore the build warning.

The googletest project is aware of the issue. See the
actual commit for a link to the ticket for the google
test project.

Change-Id: I9be616498df95b8dd9aa165717bd178c53f3221b
Signed-off-by: George Nash <george.nash@intel.com>
17 months agoupdate NSAcceptedProviders copy/assign operators 77/25677/3
George Nash [Wed, 2 May 2018 18:45:10 +0000 (11:45 -0700)]
update NSAcceptedProviders copy/assign operators

This addresses an iterator missmatch error that is reported by
static analysis tool. This changes the code to use the built in
map assignment operator as well as grab locks before copying the
map to prevent the map being modified while the copy is
occuring.

Bug: https://jira.iotivity.org/browse/IOT-1742
Change-Id: Id7d8eeed91d587db7d2b0f8ca6a8d5b3d98f90fe
Signed-off-by: George Nash <george.nash@intel.com>
17 months agoFix double free in bridging curl client 17/25317/2
Mats Wichmann [Sat, 19 May 2018 14:25:47 +0000 (08:25 -0600)]
Fix double free in bridging curl client

A recent change added a destructor for _MemoryChunk, to
fix a problem where something was not being freed.
However, this left another location freeing memory
twice - once explicitly, once when the destructor runs.

Change-Id: Ie10829334238a359e38c55df789d3e69425f67b3
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months agoFix memory leak 99/25299/3
Inho Oh [Fri, 1 Dec 2017 07:06:06 +0000 (16:06 +0900)]
Fix memory leak

This patch fix critical memory leak. When I run CTT with CT1.2.3 test
case, memory is increased every time.

Change-Id: Idee5e3ed9b043a21d55ba5dc752c537156d99d8e
Signed-off-by: Inho Oh <webispy@gmail.com>
17 months agoMerge "Merge branch '1.4-rel' (01fd9ec)"
Phil Coval [Mon, 4 Jun 2018 08:08:57 +0000 (08:08 +0000)]
Merge "Merge branch '1.4-rel' (01fd9ec)"

17 months ago[IOT-3012] Update JniOcProvisioning API usage 43/25343/3
Larry Sachs [Mon, 21 May 2018 21:24:26 +0000 (14:24 -0700)]
[IOT-3012] Update JniOcProvisioning API usage

Use of deprecated functions in JniOcProvisioning.cpp has been updated
to use their replacements.

Java example ProvisioningClient.java has also been updated.

Change-Id: Ie46dccffc714b47109100dbd8c70aa3598d94190
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
17 months agoMerge branch '1.4-rel' (01fd9ec) 71/25571/1
Philippe Coval [Thu, 31 May 2018 08:22:26 +0000 (10:22 +0200)]
Merge branch '1.4-rel' (01fd9ec)

Relate-to:
      I25836d20803e82764b8f9dbc30ddfde80810518f
      I40a9b3c3f89894e92c75c798e918f1713e9e6740
      I44bd904f13cdd7b44e34e47a69ce403248e550b9
      Idbe257c1baa90a7cabce6fe6113ab09fb5644eab
      I1cfad27fcfd5cf3a42510412e6555b84ea905259

Change-Id: I01fd9ecd719dbb68b74712b058a50d768f90624d
Bug: https://jira.iotivity.org/browse/IOT-2453
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
17 months ago[IOT-3022] Add cloud reset api 15/25315/4
Aleksey Volkov [Fri, 11 May 2018 10:01:07 +0000 (13:01 +0300)]
[IOT-3022] Add cloud reset api

Change-Id: I40a9b3c3f89894e92c75c798e918f1713e9e6740
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
17 months ago[IOT-3022] Session delete fix 07/25407/2
Aleksey Volkov [Wed, 23 May 2018 14:04:41 +0000 (17:04 +0300)]
[IOT-3022] Session delete fix

Do not delete session in case if token refresh thread stops

Change-Id: I44bd904f13cdd7b44e34e47a69ce403248e550b9
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
17 months agoAdd SECURED flag to SimpleClientServer build 73/24573/4
Mats Wichmann [Wed, 4 Apr 2018 13:56:13 +0000 (07:56 -0600)]
Add SECURED flag to SimpleClientServer build

The code in this sample contains #ifdef SECURED,
but the flag is not set during building even if
SECURED mode is selected.

Change-Id: Ied64c34db0437736aaaac4c88d0b53037639a34a
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months agoAdd csdk API to send COAP ping messages over TCP 05/25305/3
Koushik Girijala [Mon, 26 Mar 2018 12:53:15 +0000 (18:23 +0530)]
Add csdk API to send COAP ping messages over TCP

Add csdk API in ocstack to send COAP ping messages
over tcp.

Change-Id: Idbe257c1baa90a7cabce6fe6113ab09fb5644eab
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: koushik girijala <g.koushik@samsung.com>
(cherry picked from commit bfbac92c38ba2ae9280ff8694e0862610423b43f)

17 months agoMerge "Merge branch '1.4-rel'"
Phil Coval [Fri, 25 May 2018 19:35:38 +0000 (19:35 +0000)]
Merge "Merge branch '1.4-rel'"

17 months agoMerge branch '1.4-rel' 69/25469/1
Mats Wichmann [Fri, 25 May 2018 13:16:34 +0000 (07:16 -0600)]
Merge branch '1.4-rel'

Includes:

e6f2764e1 Cloud resource fix
b08cb060d tizen: Only support IP transport by default
718227d3f [IOT-3022] Code style and fix minor issues.
456bc2189 [IOT-3047] Request to csr creates a new credential
e8671983e [IOT-3022] CNC fixes for CTT
9204d7826 [IOT-3022] cloud fix #2
dbf736917 mbedtls: Install Static libs
b6744aca4 tinycbor: Update to v0.5.1
ee6a853cb Merge branch '1.3-rel' into 1.4-rel

Change-Id: I832157c55f2ea18654a021d2579a461c48a5220e
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months agoIOT-3079 Fix change port number issue 41/25441/4
Jeonghwan Kim [Thu, 24 May 2018 01:09:49 +0000 (10:09 +0900)]
IOT-3079 Fix change port number issue

When using provisioning tool, this code change to target dev's port number.
reproduction case is below in provisioning tol.

1. Discovery All devices or unowned devices.
2. do Ownership transfers.
3. hard reset device.

4. Discovery All devices
5. Do Ownership transfer.

it happens to error in provisioning tool because of changing to target's port number

Conflicts:
resource/csdk/security/provisioning/src/ocprovisioningmanager.c

Change-Id: Ie5bcc1be58bc11609dd3bcc0b674d64202ed4573
Signed-off-by: Jeonghwan Kim <addy.kim@lge.com>
17 months agoRemoving arduino files that came back in merge 49/25449/1
Mats Wichmann [Thu, 24 May 2018 13:19:02 +0000 (07:19 -0600)]
Removing arduino files that came back in merge

A merge commit unintentionally brought back previously deleted arduino
sample code.  Removing again.

Change-Id: I77284bea5ba0bec2c0ee8e065a831727d624b742
Signed-off-by: Mats Wichmann <mats@linux.com>
17 months ago[IOT-3044] No response for Ping message 43/25443/1
Veeraj Khokale [Thu, 5 Apr 2018 09:35:54 +0000 (15:05 +0530)]
[IOT-3044] No response for Ping message

TCP adapter disconnects the session whenever
the data to be sent has an empty payload.
Since ping messages and signaling messages
need to have an empty payload they are dropped.
Fix this by checking if the message is a signaling
message before dropping it.

Change-Id: I1cfad27fcfd5cf3a42510412e6555b84ea905259
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
(cherry picked from commit c7dce6b522604e2c6b99847c88a00f7da275c08d)

18 months agotizen: Only support IP transport by default 27/24927/8
Philippe Coval [Tue, 24 Apr 2018 13:57:57 +0000 (15:57 +0200)]
tizen: Only support IP transport by default

It looks like BLE support has been dropped,
while some bits are remaining, check for:
CA_BLE_NORMAL_SEGMENT_PAYLOAD_SIZE

Bug: https://jira.iotivity.org/browse/IOT-2030
Change-Id: Idb99ebfbd721c6abb5ce6cfcf2c381ece195ffc8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
(cherry picked from commit b08cb060de3421b9277c097c18d369c3eb682248)

18 months agoCloud resource fix 85/25385/1
koushik.girijala [Fri, 18 May 2018 05:16:34 +0000 (10:46 +0530)]
Cloud resource fix

fixed resource uri for issue [IOT- 3069]
removed unsecure enpoints from cloud payload [IOT-3071]
adding oic.if.rw interface to cloud resource [IOT-3070]

Change-Id: I719d54bd846f77a5cf2905ccc130ab0434005491
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
18 months agotizen: Add dockerfile to rebuild package 51/23451/8
Philippe Coval [Fri, 24 Nov 2017 17:31:47 +0000 (18:31 +0100)]
tizen: Add dockerfile to rebuild package

Usage:
  docker build -f tools/tizen/Dockerfile .

Reference:

  docker 17.12.1-ce
  gbs 0.25.2

Bug: https://jira.iotivity.org/browse/IOT-524
Change-Id: I5feec4f3b0e70831c6069e78473e1374b45aeadf
Forwarded: https://gerrit.iotivity.org/gerrit/#/c/23451/
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/on/master/fedora
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
18 months agotizen: Only support IP transport by default 81/24881/2
Philippe Coval [Tue, 24 Apr 2018 13:57:57 +0000 (15:57 +0200)]
tizen: Only support IP transport by default

It looks like BLE support has been dropped,
while some bits are remaining, check for:
CA_BLE_NORMAL_SEGMENT_PAYLOAD_SIZE

Bug: https://jira.iotivity.org/browse/IOT-2030
Change-Id: Idb99ebfbd721c6abb5ce6cfcf2c381ece195ffc8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
18 months agoFix recently introduced python2-ism 77/25277/2
Mats Wichmann [Wed, 16 May 2018 16:32:27 +0000 (10:32 -0600)]
Fix recently introduced python2-ism

print statement needs to be a function

Change-Id: Iaa163903749e64156a2cbbb9a97f4dd1da9ff901
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months agoDocumentation improvements to layout and grouping 35/24535/12
Mats Wichmann [Sun, 25 Mar 2018 18:07:27 +0000 (12:07 -0600)]
Documentation improvements to layout and grouping

All four doxyfiles are updated to current template
  (newer doxygen version) by running doxygen -u
iotivity logo is added, doxyfiles point to it
C SDK adds individual listings for (some) libraries
xml template for C SDK displays library page
  doxygen thinks these are "modules", but mostly ok
xml template also displays "pages", which causes a
  a list of deprecated elements to be displayed
Some headers are marked up for their inclusion
  in libraries (work in progress). Libraries are
  "defined" in guides/Home.txt, so far with only
  minimal definitions - need improving.
An iotivity-specific css file is added, so far
  includes markup for two new elements (aliases)
Two aliases are defined, @experimental prints a section
  indicating the feature is experimental; @sideeffect
  takes one argument and prints a section with that
  argument as the body. Intended as a way to be able
  to note e.g. if a function causes allocations that need to
  be tracked - there are no current users of this alias.
Some minor doc cleanup is included.
Cloud auth.h emits errors on processing, those were
  fixed, some doc wording added, and the prototype
  for CloudStart was removed as there is no implementation.

Change-Id: I8a434bb3cb51523129ec8e478ac45ac196cf41b5
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months ago[IOT-3022] Code style and fix minor issues. 49/25249/8
Vitalii Irkha [Tue, 15 May 2018 15:09:02 +0000 (18:09 +0300)]
[IOT-3022] Code style and fix minor issues.

Fixed some negligible issues.

Change-Id: If6ef5b77514a2b4cccea90e609da340c75083ac6
Signed-off-by: Vitalii Irkha <v.irkha@samsung.com>
18 months ago[IOT-3011] Deprecate PlatformConfig to match C++ 79/25279/4
Larry Sachs [Wed, 16 May 2018 20:56:06 +0000 (13:56 -0700)]
[IOT-3011] Deprecate PlatformConfig to match C++

In OCApi.h constructors for PlatformConfig that take ipAddress and port
as parameters have been deprecated.  These deprecated constructors are
now similarly removed from the JNI code and deprecated in the Java code.
Non-deprecated constructors are now available.

Sample code has been changed to use the new constructors.

Change-Id: I3daa9c4eac0480c8fd8d3be7a5d0a80dada8c902
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
18 months ago[IOT-3047] Request to csr creates a new credential 31/24931/2
Vitalii Irkha [Thu, 26 Apr 2018 16:15:39 +0000 (19:15 +0300)]
[IOT-3047] Request to csr creates a new credential

Request to /oic/sec/csr creates itself a new credential
Get PrimarySertKey for appropriated Primary Certificate.

Change-Id: Ie09a186fb03c3cc0006a583fc6ea03c5aa739790
Signed-off-by: Vitalii Irkha <v.irkha@samsung.com>
18 months agoUplift rapidjson version to follow upstream 47/25247/3
Mats Wichmann [Tue, 15 May 2018 14:37:38 +0000 (08:37 -0600)]
Uplift rapidjson version to follow upstream

This is one of a series of patches to accomodate building
with gcc8.  rapidjson fails to build (line broken to quiet
gerrit line-length complaint)

extlibs/rapidjson/rapidjson/include/rapidjson/document.h:1635:24:
 error: 'void* memcpy(void*, const void*, size_t)'
 writing to an object of type
'class rapidjson::GenericValue<rapidjson::UTF8<> >'
 with no trivial copy-assignment; use copy-assignment or
 copy-initialization instead [-Werror=class-memaccess]
             std::memcpy(data_.a.elements, values, count * sizeof(GenericValue));
             ~~~~~~~~~~~^~~~~~~~~~~

Fortunately, the current upstream version builds fine.

Change-Id: Ib64fd73bb4d16487db951823adcfcca7f57e435c
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months ago[IOT-3022] CNC fixes for CTT 73/24873/14
Aleksey Volkov [Tue, 24 Apr 2018 13:03:13 +0000 (16:03 +0300)]
[IOT-3022] CNC fixes for CTT

- fixed clec
- disable multiple cloud support
- add more logging
- fix apn & redirectUri errors
- freeCloud fix
- cloud refresh fix

Change-Id: I7898e2c704320a84d441ffc4a3dae6de03eb8a7e
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
18 months ago[IOT-3022] cloud fix #2 95/24795/5
Aleksey Volkov [Tue, 24 Apr 2018 12:59:54 +0000 (15:59 +0300)]
[IOT-3022] cloud fix #2

a) sample server justwork: added key press check
b) fixed apn check
c) signout in delete cloudconfig
d) delete cloud
e) use redirect uri
f) update cloud if not working
g) token refresh timeout

Change-Id: Iefe5e0d0c37359a5699f021364a0aa82e8799f68
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
18 months agonotification: Enable SECURED build of unit tests. 71/22171/14
Pawel Winogrodzki [Sat, 8 Jul 2017 00:28:37 +0000 (17:28 -0700)]
notification: Enable SECURED build of unit tests.

The notification consumer and provider tests didn't include
the "SECURED" macros for builds with security turned on, even
though it seems clear from the code, that it expected that macro
to be present in some cases.

Bug: https://jira.iotivity.org/browse/IOT-1583
Change-Id: I1166a60c2ad821a7d6002e22a8c9e8bda7321800
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/21329
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
(cherry picked from commit e3968b9a84ac1e577feac2924980a0ffc6846f21)

18 months agoAdded OCF secure apps in examples/OCFSecure 97/25097/2
Rami Alshafi [Fri, 15 Sep 2017 18:12:05 +0000 (11:12 -0700)]
Added OCF secure apps in examples/OCFSecure

Added OCF secure server sample application in C++.
Added OCF secure client sample application in C.
Added supporting json and dat files putting the applications in RFNOP state.
Added README file descriping how to use the sample applications.
Added utilities file containing utility functions used by the server
and client applications.
Added SConscript to build the secure samples and modified the SConscipt in
the root directory to include the new SConscript.

Change-Id: I9e1cd4647b55b3e95d1455d7939f13bf3451fd1b
Signed-off-by: Rami Alshafi <ralshafi@vprime.com>
(cherry picked from commit 3974e003fb14a6269ab93d3c2c865e7cb65ce11a)

18 months agotizen: Enable TCP 93/15193/16
Philippe Coval [Tue, 4 Oct 2016 08:37:48 +0000 (10:37 +0200)]
tizen: Enable TCP

This change was applied downstream,
so for tracking it is shared upstream,
but I feel that if this feature should be turned on
It should be done globally in build_common

Change-Id: I56b8abcea1a3397f546ef0b8edc42711ff62b9d8
Origin: https://gerrit.iotivity.org/gerrit/#/c/14655/
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/15193/

18 months ago[IOT-3044] No response for Ping message 81/24581/7
Veeraj Khokale [Thu, 5 Apr 2018 09:35:54 +0000 (15:05 +0530)]
[IOT-3044] No response for Ping message

TCP adapter disconnects the session whenever
the data to be sent has an empty payload.
Since ping messages and signaling messages
need to have an empty payload they are dropped.
Fix this by checking if the message is a signaling
message before dropping it.

Change-Id: I1cfad27fcfd5cf3a42510412e6555b84ea905259
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
18 months agoAdd csdk API to send COAP ping messages over TCP 89/24489/8
Koushik Girijala [Mon, 26 Mar 2018 12:53:15 +0000 (18:23 +0530)]
Add csdk API to send COAP ping messages over TCP

Add csdk API in ocstack to send COAP ping messages
over tcp.

Change-Id: Idbe257c1baa90a7cabce6fe6113ab09fb5644eab
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: koushik girijala <g.koushik@samsung.com>
18 months agombedtls: Install Static libs 79/24879/3
Philippe Coval [Tue, 24 Apr 2018 09:16:30 +0000 (11:16 +0200)]
mbedtls: Install Static libs

Change-Id: Ia69fc0a9d7b0624a13c7d3ef2ba6a0e921ea4ba3
Bug: https://jira.iotivity.org/browse/IOT-3027
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
(cherry picked from commit cca779a39cc587460d2793f58897a277f0e93e00)

18 months agotinycbor: Update to v0.5.1 61/24761/5
Philippe Coval [Wed, 18 Apr 2018 13:04:40 +0000 (15:04 +0200)]
tinycbor: Update to v0.5.1

Bug: https://jira.iotivity.org/browse/IOT-1600
Change-Id: I1f59d7d0dc13e00d041d6feb465a359cd7388282
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
(cherry picked from commit 5c16320f2fee0194a1285e35ffe189bb082d6732)

18 months agoRemove unimplemented single thread headers 01/25001/2
George Nash [Tue, 1 May 2018 22:11:09 +0000 (15:11 -0700)]
Remove unimplemented single thread headers

the headers caedradapter_singlethread.h and
cainterfacecontroller_singlethread.h have no
implementation associated with these headers.

The implementation was most likely removed when
arduino support was removed.

Change-Id: Idef573722c51f465d8b83378b5751244ef78ffc6
Signed-off-by: George Nash <george.nash@intel.com>
18 months agombedtls: Install Static libs 89/24889/2
Philippe Coval [Tue, 24 Apr 2018 09:16:30 +0000 (11:16 +0200)]
mbedtls: Install Static libs

Change-Id: Ia69fc0a9d7b0624a13c7d3ef2ba6a0e921ea4ba3
Bug: https://jira.iotivity.org/browse/IOT-3027
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
18 months agoMerge branch '1.4-rel' (811a49a) 01/24901/1
Philippe Coval [Wed, 25 Apr 2018 08:20:59 +0000 (10:20 +0200)]
Merge branch '1.4-rel' (811a49a)

Relate-to:
      I37adc9b039e1ab9377b8024552eee4fb1e3ed1ab
      I615432439a68600f00d7335d3641c7d7499c8955

Change-Id: I811a49a882b09f00a8e6729fe855142b1400a0a7
Bug: https://jira.iotivity.org/browse/IOT-2453
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
18 months agoFix Memory Leaks (valgrind) 07/24607/3
George Nash [Sat, 7 Apr 2018 00:19:49 +0000 (17:19 -0700)]
Fix Memory Leaks (valgrind)

This fixes memory leaks reported by valgrind

Change-Id: I99fe0b69e2c466e495f19bffd2226ebcd019cc85
Signed-off-by: George Nash <george.nash@intel.com>
18 months agoUninitialized payload pointer mey be freed 25/24825/5
Mats Wichmann [Sat, 21 Apr 2018 12:55:39 +0000 (06:55 -0600)]
Uninitialized payload pointer mey be freed

initialize response on declaration; don't free if pointer is null.

Change-Id: I9936a4f24c4ab6f8c322a2493ab5a1c303cd97cb
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months agoFix uninitialized value (valgrind) 05/24605/2
George Nash [Fri, 6 Apr 2018 21:38:47 +0000 (14:38 -0700)]
Fix uninitialized value (valgrind)

Valgrind reported that the buffer was not initilized
before being used for a conditional jump. This change
zero ('/0') intilizes the buffer.

Change-Id: I51d1716167f3da628783bef6bd733ab06e24de1e
Signed-off-by: George Nash <george.nash@intel.com>
18 months agoDrop unneeded libcoap references 77/24877/1
Mats Wichmann [Tue, 5 Dec 2017 14:52:07 +0000 (07:52 -0700)]
Drop unneeded libcoap references

We know they're unneeded because they are malformed: LIBS will be
turned into -l calls, which prepends 'lib', which means these three
are actually references to liblibcoap, which does not exist.

Change-Id: I4cacbbdf81651a768d6a1840e7c67fbcac48bfeb
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months agoAdd unused markers if MULTIPLE_OWNER is undefined 41/24841/2
Mats Wichmann [Mon, 23 Apr 2018 16:18:47 +0000 (10:18 -0600)]
Add unused markers if MULTIPLE_OWNER is undefined

Several functions in one source file have code which is bracketed
by #ifdef MULTIPLE_OWNER. If not defined, these trigger warnings
about unused parameters; since warnings now cause error, this is
fatal. Add OC_UNUSED() wrappings for these.

Change-Id: I6b6320e8a6444a43c6400527f2f982a39a3d9128
Signed-off-by: Mats Wichmann <mats@linux.com>
18 months agoAdd python version to build output 39/24839/2
Mats Wichmann [Mon, 23 Apr 2018 15:48:55 +0000 (09:48 -0600)]
Add python version to build output

For diagnostic purposes, also include the Python version

Change-Id: Idfceca024d3e9c18acd9e72fa637a94128e97ea4
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agoresource: prevents copy elision 17/8517/13
Gregg Reynolds [Tue, 7 Jun 2016 06:13:38 +0000 (01:13 -0500)]
resource: prevents copy elision

eliminate warning: moving a local object in a return statement prevents copy elision

Change-Id: I8a2bc85fb2d8f6e31d04e067a4476970d7d657c6
Signed-off-by: Gregg Reynolds <reynolds-gregg@norc.org>
19 months agoStatic analysis: add dtor in bridging curl-client 53/24753/2
Mats Wichmann [Wed, 18 Apr 2018 21:48:11 +0000 (15:48 -0600)]
Static analysis: add dtor in bridging curl-client

Coverity analysis points out _MemoryChunk struct has a ctor which
malloc's memory, but no dtor to free it.  It's one byte, not going
to lead to memory exhaustion (!) but let's keep to good practices.

Change-Id: I3dccb8b6355b6cdee0110653074f748abf9a2c16
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months ago[IOT-2908] Build fail for option WITH_CLOUD. 79/23879/3
Harry [Mon, 27 Nov 2017 10:46:30 +0000 (16:16 +0530)]
[IOT-2908] Build fail for option WITH_CLOUD.

Printing int64_t value as "%ld" triggered build
failure as int64_t is "long long int" in 32 bit linux
environment. Using "PRId64" so that compiler chooses
"long int" or "long long int" based on it's architecture.

Change-Id: I92c22a312465875cfd0b077c85d215ac9aa4d0d1
Signed-off-by: Harry <h.marappa@samsung.com>
19 months agobuild: Disable MOT by default to align spec 93/21493/17
Philippe Coval [Mon, 17 Jul 2017 17:17:11 +0000 (19:17 +0200)]
build: Disable MOT by default to align spec

An extra build job might be requiered to turn on all features

Bug: https://jira.iotivity.org/browse/IOT-2241
Change-Id: I9bed4ade3fb12747e35d390b4a4e0339288ff564
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/21493/

19 months agoiOS:Fix to build IoTivity 1.3.1 provisioning 71/24071/9
Yogisha Poojary [Fri, 2 Feb 2018 13:38:00 +0000 (08:38 -0500)]
iOS:Fix to build IoTivity 1.3.1 provisioning

Bug:https://jira.iotivity.org/browse/IOT-2968

Dependency::If8eb4fd34191da7144f39b9e6d1870209d17c9ca Ia97785ff88ef0b7e83538f09a394eefe824ba54f

Change-Id: I04014707bfdd22caab570cd7d2b0de23caa9e2ba
Signed-off-by: Yogisha Poojary <yogisha.poojary@lnttechservices.com>
19 months agotinycbor: Update to v0.5.1 43/24743/4
Philippe Coval [Wed, 18 Apr 2018 13:04:40 +0000 (15:04 +0200)]
tinycbor: Update to v0.5.1

Bug: https://jira.iotivity.org/browse/IOT-1600
Change-Id: I1f59d7d0dc13e00d041d6feb465a359cd7388282
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agombedtls: catch errors, stop using os.system 49/24549/2
Mats Wichmann [Sun, 4 Feb 2018 15:54:06 +0000 (08:54 -0700)]
mbedtls: catch errors, stop using os.system

Change-Id: Id743749b817f4b345181c3ec96bad76b87f541fa
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agoMerge branch '1.3-rel' into 1.4-rel 13/24813/1
Philippe Coval [Fri, 20 Apr 2018 15:23:16 +0000 (17:23 +0200)]
Merge branch '1.3-rel' into 1.4-rel

Change-Id: I43209c55d6b5a6b7dc8ef8b1de8f49f2f8e7eb9a
Bug: https://jira.iotivity.org/browse/IOT-2453
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agoMerge "Merge branch '1.3-rel' (0615f17)"
Mats Wichmann [Fri, 20 Apr 2018 12:48:25 +0000 (12:48 +0000)]
Merge "Merge branch '1.3-rel' (0615f17)"

19 months ago[IOT-3022] Plugfest hotfix 4 75/24775/3
Aleksey Volkov [Tue, 17 Apr 2018 13:28:52 +0000 (16:28 +0300)]
[IOT-3022] Plugfest hotfix 4

-- return empty filled response from /oic/cloudconf in case if cloud data is not provisioned
-- add rt and if fields to the RETRIEVE response payload

Change-Id: I37adc9b039e1ab9377b8024552eee4fb1e3ed1ab
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
19 months agoJava example of OCF Light Server 39/24539/14
Larry Sachs [Mon, 2 Apr 2018 22:32:27 +0000 (15:32 -0700)]
Java example of OCF Light Server

Change-Id: Ia1583c9dbea61572f0cb1a3fa4bfcf3962ebfcec
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
19 months agocloud fix #1 71/24771/1
Aleksey Volkov [Wed, 18 Apr 2018 13:30:26 +0000 (16:30 +0300)]
cloud fix #1

a) mandatory fixed
b) apn param usage in signup
c) clean

Change-Id: I615432439a68600f00d7335d3641c7d7499c8955
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
(cherry picked from commit 0532f6be172f805384e4c1b5fc549f183a45b3b5)

19 months agoignore: generated files from debian 49/24749/2
Philippe Coval [Wed, 18 Apr 2018 16:49:01 +0000 (18:49 +0200)]
ignore: generated files from debian

Change-Id: Ifc7d3179993ad3a10cf866f0ae648c7cd4fd00c7
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agocloud fix #1 27/24727/4
Aleksey Volkov [Wed, 18 Apr 2018 13:30:26 +0000 (16:30 +0300)]
cloud fix #1

a) mandatory fixed
b) apn param usage in signup
c) clean

Change-Id: I615432439a68600f00d7335d3641c7d7499c8955
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
19 months agoMerge branch '1.3-rel' (0615f17) 73/24373/12
Philippe Coval [Wed, 18 Apr 2018 14:21:47 +0000 (16:21 +0200)]
Merge branch '1.3-rel' (0615f17)

Relate-to:
      I93a37cc65b8b0536d05c1acfd4da26e7719525a1
      I14190ffe2f857d48e062f3f78e9b7b52123efe1b
      I2f7d54c0ff6b4a372b82c4e99263af4df2c98a4e

Change-Id: Icf3012285f8eff116acc3d8971a293e12af38f8d
Bug: https://jira.iotivity.org/browse/IOT-2453
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agostatic analysis: buffer size violations 63/24163/7
Mats Wichmann [Thu, 15 Feb 2018 20:15:35 +0000 (13:15 -0700)]
static analysis: buffer size violations

fix reported "might leave destination string unterminated" when
using strncpy and the size argument is the size of the desitnation
buffer. There are several ways to fix, but the IoTivity API OCStrncpy
adjusts the size before calling the underlying fuction and so fixes
the problem. This is the coding standard recommendation anyway.

for instances in examples, oic_string.h is not in the public API,
so just fix up the counts.

bridging/common/messageHandler.cpp had a third strncpy which was not
flagged - but it was using a constant that did not match the size
in the destination - MPMResourceList.href is size MPM_MAX_URI_LEN,
so this was adjusted.

service/notification/src/consumer/NSConsumerCommon.c had this construct:
   sizeof(char) * NS_DEVICE_ID_LENGTH
in several places (one of which was one of these strncpy calls that
was changed). the instances were shortened NS_DEVICE_ID_LENGTH for
readability. This is not fixing any reported problem and can be
dropped if it bothers reviewers.

Change-Id: I8f22f7dd704849477dad0dd1f16cd9276ebf1d04
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months ago[IOT-3022] 37/24637/4
Oleksandr Dmytrenko [Thu, 12 Apr 2018 13:52:33 +0000 (16:52 +0300)]
[IOT-3022]

outdated cloud sample removed

Change-Id: I8d8991d1e6f5f0879c3a168b7807680710b2e0a2
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
19 months ago[IOT-3022] 27/24527/22
Oleksandr Dmytrenko [Fri, 30 Mar 2018 09:02:00 +0000 (12:02 +0300)]
[IOT-3022]

a) cloud resource unittests
b) amacl resource make cbor fix

Change-Id: Ib4d56f3105e060656d52f5b0b498ae188fe42c03
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
19 months agoEnhanced comment ratio for le_adapter 17/24617/6
Kush [Tue, 10 Apr 2018 09:47:53 +0000 (15:17 +0530)]
Enhanced comment ratio for le_adapter

Change-Id: I893246e60d959efa65741635e8e8b286e05a0b4d
Signed-off-by: Kush <kush.agrawal@samsung.com>
19 months ago[IOT-3022] Plugfest hotfix 3 23/24723/3
Aleksey Volkov [Tue, 17 Apr 2018 12:46:03 +0000 (15:46 +0300)]
[IOT-3022] Plugfest hotfix 3

- add coapcloudconf uri to DCR list
- start cloud signin on RFNOP, not on RFPRO

Change-Id: Id52b650a23c82830a2641d5e0e5b94af79aa0c27
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
19 months ago[IOT-2052] Update to support OCF 1.0 47/24647/3
v.riznyk [Fri, 13 Apr 2018 15:17:00 +0000 (18:17 +0300)]
[IOT-2052] Update to support OCF 1.0

missing fix for task, changed size of map

Change-Id: I8a6cf6fc06058c003da3ec52d695aa0dd303c63f
Signed-off-by: v.riznyk <v.riznyk@samsung.com>
19 months ago[IOT-3022] plugfest hotfix 91/24691/2
Aleksey Volkov [Mon, 16 Apr 2018 14:24:42 +0000 (17:24 +0300)]
[IOT-3022] plugfest hotfix

Change-Id: I9ffd0a80eef1343c28034dfb66edc7d55cb5e8de
Signed-off-by: Aleksey Volkov <a.volkov@samsung.com>
19 months agoRE: Check MLK in resourceBroker unit-test 97/15397/44
Philippe Coval [Fri, 9 Dec 2016 23:09:48 +0000 (00:09 +0100)]
RE: Check MLK in resourceBroker unit-test

Bug: https://jira.iotivity.org/browse/IOT-2267
Change-Id: I0cc8d19fd693a2f10ac2230f0ca34a4ae4bc31ea
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months ago[IOT-3040] OCProvisionTrustCertChain CB not called 85/24585/3
Vitalii Irkha [Thu, 5 Apr 2018 12:29:26 +0000 (15:29 +0300)]
[IOT-3040] OCProvisionTrustCertChain CB not called

SRPGetSpResourceCB registers any client responce.

Change-Id: Ib24479bfd76c8c683998ac4c7187dfc90fb47041
Signed-off-by: Vitalii Irkha <v.irkha@samsung.com>
19 months ago[Resource-Encapsulation] Improved doxygen comments 61/23761/5
Jay Sharma [Thu, 12 Apr 2018 13:19:32 +0000 (18:49 +0530)]
[Resource-Encapsulation] Improved doxygen comments

Change-Id: I367e12d25e27b904a18bf9c6bb14c87001c3e20b
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
19 months agoc_common: Fix warnings in octhread.c 29/24129/4
Philippe Coval [Mon, 13 Nov 2017 14:09:38 +0000 (15:09 +0100)]
c_common: Fix warnings in octhread.c

They were discovered when building for Tizen:RT

Bug: https://jira.iotivity.org/browse/IOT-2539
Origin: https://gerrit.iotivity.org/gerrit/#/c/24129/
Change-Id: Idea365f15f5aff38634e05914d9c55afe2d6bd8e
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agobuild: Update version to 1.4.0 21/24421/4
Philippe Coval [Mon, 19 Mar 2018 08:28:29 +0000 (09:28 +0100)]
build: Update version to 1.4.0

Change-Id: I3e6ab42060cd082094dd906e36897dc58f152773
Origin: https://gerrit.iotivity.org/gerrit/#/c/24421/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months ago[IOT-3041] return OC_STACK_OK when pDev2=NULL 51/24551/2
v.riznyk [Tue, 3 Apr 2018 15:37:05 +0000 (18:37 +0300)]
[IOT-3041] return OC_STACK_OK when pDev2=NULL

The checking pDev2 was added to OCProvisionCredentials.

Change-Id: Ic289559c68250a1436fab64bcbd5dfb26d7eb4c8
Signed-off-by: v.riznyk <v.riznyk@samsung.com>
19 months ago[IOT-2052] Update to support OCF 1.0 73/24273/14
v.riznyk [Wed, 7 Mar 2018 11:53:48 +0000 (13:53 +0200)]
[IOT-2052] Update to support OCF 1.0

Update Cred recource with adding partial generating CBOR.

Change-Id: I25dcf3d020da09c67d0769eee8659d85253b4f5d
Signed-off-by: v.riznyk <v.riznyk@samsung.com>
19 months agoFix two more problems building with Python3 09/24609/3
Mats Wichmann [Sat, 7 Apr 2018 23:46:27 +0000 (17:46 -0600)]
Fix two more problems building with Python3

The boost script used string.replace() which is no longer
supported; problem did not turn up until trying a build on Windows

The security - provisioning - unittest script had a Windows
stanza for killing running server processes before launching a
new one. It printed the process id it was going to kill in a way
that caused an AttributError exception - this was a conversion
error from when print statement was changed to print function,
again the code path had not been hit. At the same time a second
exception ocurred because when the first exception took place the
script attempted to us the message attribute of the exception for
printing, but not all exceptions have such an attribute. Change
to just print the string representation of the exception, which
is more reliable.

Additionally, in the libcoap script, the term 'string' is used
which while not broken since the script never imports the string
module, is unnecessarily ambiguous. Use the Python recommended
disambiguation of adding a trailing underscore on an identifier
which might match one used by Python.

Change-Id: I635796a6442caacb6988e21dbe46938f860e333f
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agoMemory leak in security spresource 15/24615/3
Mats Wichmann [Mon, 9 Apr 2018 15:52:53 +0000 (09:52 -0600)]
Memory leak in security spresource

In TestEncodeDecode, a profile is allocated and filled;
it is unwound but not deallocated, leading to valgrind
memory leak report like this:

32 bytes in 1 blocks are definitely lost in loss record 130 of 271

The freeing change eliminates nine such reports, one for
each call to the function.

Change-Id: I8b1223f7b832d4fafac4d7225ea2544fc348a7a4
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agoUse `URI` all caps in documentation 59/24559/2
George Nash [Tue, 3 Apr 2018 19:00:18 +0000 (12:00 -0700)]
Use `URI` all caps in documentation

URI is all caps when used in documentation

Fixed instances where param document parameters
[in], [out] and [in,out] were used incorrectly.

A few other minor documentation issues cleaned up.

Change-Id: Ic9db0c22a667d371fd1ca00c60b5bbceba6a3c77
Signed-off-by: George Nash <george.nash@intel.com>
19 months agoresource-container: Install unit tests 79/24479/4
Philippe Coval [Fri, 23 Mar 2018 10:44:03 +0000 (11:44 +0100)]
resource-container: Install unit tests

Bug: https://jira.iotivity.org/browse/IOT-524
Change-Id: I1b88b500f18445ea145c24a8e52ea07c6b11c521
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agoFix issues found using static code analysis 89/24589/3
George Nash [Thu, 5 Apr 2018 18:32:14 +0000 (11:32 -0700)]
Fix issues found using static code analysis

Fixed possible issue that the for loop could be
accessing element outside the array. Replaced the
variables holding the size of the array with a
compile time calculation. Removed separate member varaible
use to track the size of the resource type array and
the resource interface array.

Changed the initialization of m_dimmingLightServer from
C++11 initializer list style to C++98 initializer style
due to this causing build failure on gcc/g++ v4.8.4.
Issue reported by Abhishek Pandey

Change-Id: I553e661dbd2e6fa3fe38d8694d88273c5b309c58
Signed-off-by: George Nash <george.nash@intel.com>
19 months agoscene-manager: Install unit tests 85/24485/3
Philippe Coval [Fri, 23 Mar 2018 10:45:37 +0000 (11:45 +0100)]
scene-manager: Install unit tests

Bug: https://jira.iotivity.org/browse/IOT-524
Change-Id: I9db429a928d6fb5084948a7122c2a4f0151829bd
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agoresource: Install unit tests 83/24483/6
Philippe Coval [Fri, 23 Mar 2018 10:45:14 +0000 (11:45 +0100)]
resource: Install unit tests

logger tests are renamed to more meaningful names,
note that yocto used different names (logger_test_c/cpp),
I aligned to upstream's sources.

Bug: https://jira.iotivity.org/browse/IOT-524
Origin: https://gerrit.iotivity.org/gerrit/#/c/24483/
Change-Id: Ib5eabdece4414801cd08d27671bb759d27914174
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agocsdk: Install unit tests 81/24481/4
Philippe Coval [Fri, 23 Mar 2018 10:44:47 +0000 (11:44 +0100)]
csdk: Install unit tests

Bug: https://jira.iotivity.org/browse/IOT-524
Change-Id: Ie1e99e3c06d1723730d81621e78a941df1b031f9
Origin: https://gerrit.iotivity.org/gerrit/#/c/24481/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months ago1.2 support 73/23873/8
Oleksandr Dmytrenko [Fri, 24 Nov 2017 12:24:17 +0000 (14:24 +0200)]
1.2 support

old version servers support

Change-Id: I2f7d54c0ff6b4a372b82c4e99263af4df2c98a4e
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
(cherry picked from commit cf3012285f8eff116acc3d8971a293e12af38f8d)
Origin: https://gerrit.iotivity.org/gerrit/#/c/23445/

19 months agoIOT-3045 Fix return type of getResourceHandleAtUri 75/24575/3
George Nash [Wed, 4 Apr 2018 19:27:47 +0000 (12:27 -0700)]
IOT-3045 Fix return type of getResourceHandleAtUri

OcPlatfrom.getResourceAtUri should return null
when a resource is not found at the specified
URI. The class JniOcResourceHandle returned
a non-null value even when a null resourceHandle
was passed into the function. The assumption
when the code was originally created was that
it would return null. This assumption was incorrect.

This was tested by modifying simpleserver sample
Modifications not included as part of this commit.

Bug: https://jira.iotivity.org/browse/IOT-3045
Change-Id: I3e923dca3415e9e0ec473b1dd4ff4619538f325b
Signed-off-by: George Nash <george.nash@intel.com>
19 months agoconnectivity: Declare strict void function 69/23969/10
Philippe Coval [Mon, 22 Jan 2018 09:06:39 +0000 (10:06 +0100)]
connectivity: Declare strict void function

Declare void functions as strict prototype

If built along -Wstrict-prototypes it will raise and error,
this is the case on TizenRT.

More patches to come to enable this flag by default.

Bug: https://jira.iotivity.org/browse/IOT-2539
Change-Id: I71c37805b5fb60b4d8e1c78845194979fb18f9af
Origin: https://gerrit.iotivity.org/gerrit/#/c/23969/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agosecurity: Declare strict void function 71/23971/6
Philippe Coval [Mon, 22 Jan 2018 09:09:35 +0000 (10:09 +0100)]
security: Declare strict void function

Declare void functions as strict prototype

If built along -Wstrict-prototypes it will raise and error,
this is the case on TizenRT.

More patches to come to enable this flag by default.

Bug: https://jira.iotivity.org/browse/IOT-2539
Change-Id: I8597f301bb7f2fbe11b4dc46f1eab8620a714da4
Origin: https://gerrit.iotivity.org/gerrit/#/c/23971/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agoeasy-setup: Install unit tests 77/24477/4
Philippe Coval [Fri, 23 Mar 2018 11:09:32 +0000 (12:09 +0100)]
easy-setup: Install unit tests

Bug: https://jira.iotivity.org/browse/IOT-524
Change-Id: I36ec02bc79d41c8cc3627c51a6eecc6e5f322b17
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agotinycbor version bump 31/24531/2
Mats Wichmann [Sun, 1 Apr 2018 21:37:40 +0000 (15:37 -0600)]
tinycbor version bump

bugfix release: upstream is now on 0.5.1 - one fix is for a bug that an
iotivity user actually ran into, so it is a fix we want to pick up.

Bug: https://jira.iotivity.org/browse/IOT-3019
Change-Id: I0be712b375e16047161f5416fd2c61f94c676db3
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agoSample implementation of ocf_light 63/24263/24
George Nash [Fri, 9 Feb 2018 22:57:25 +0000 (14:57 -0800)]
Sample implementation of ocf_light

This sample borrows a lot of code from the server
sample generated from the DeviceBuilder project
https://github.com/openconnectivityfoundation/DeviceBuilder

Eventhough this borrows a lot of code from the
DeviceBuilder project it has been modified to make
it more useful as an example separating the code into
smaller classes and adding helper classes.

This code has been run against the OCF CTT. See the
README.md file for more information about the CTT
results.

Change-Id: If0ae5e3527517bb722648a614fbd96f13ad01144
Signed-off-by: George Nash <george.nash@intel.com>
19 months agofix cloud unitialized pointer dereference 23/24523/1
Mats Wichmann [Thu, 29 Mar 2018 18:45:20 +0000 (12:45 -0600)]
fix cloud unitialized pointer dereference

Change-Id: I869aa695160203ebb1d0cb0701c3d43f55278c41
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months ago[IOT-2928][IOT-3017][IOT-3022] 27/24427/19
Oleksii Beketov [Wed, 28 Mar 2018 14:57:05 +0000 (17:57 +0300)]
[IOT-2928][IOT-3017][IOT-3022]

The cloud provisioning:
1. sid add
2. get cloud status request add
3. Remove 'accesstoken' from coapcloudconf resource response

Change-Id: I5f5c1aa7ae414f02f6d1c288258084cacfdd1ed0
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
19 months agobuild: Align yocto to linux 57/24457/5
Philippe Coval [Thu, 22 Mar 2018 19:58:20 +0000 (20:58 +0100)]
build: Align yocto to linux

Until next refactoring it's safe to keep yocto aligned to linux,
at least only on this file, because OS is set to linux at bottom line.

Problem was observed when build using:

  EXTRA_OESCONS += " TARGET_TRANRSPORT=IP"
  EXTRA_OESCONS += " WITH_CLOUD=True"
  EXTRA_OESCONS += " WITH_TCP=True"
  EXTRA_OESCONS += " WITH_MQ=PUB,SUB"

Change-Id: I2bd6d9e32c9819d6cd485dc9d7691e213f33f2a1
Origin: https://gerrit.iotivity.org/gerrit/#/c/24457/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
19 months agoAlign license file 45/24045/4
Mats Wichmann [Tue, 30 Jan 2018 19:02:13 +0000 (12:02 -0700)]
Align license file

Minor:
The current LICENSE.md file is modified from the Apache original.
The modification is mostly incorrect (the change made is
intended for other source files, as described in the Appendix
in the original, not for the license file itself).  Restored the
pristine original.

Main problem addressed: github mirror misidentifies the license
of the project, since the first few lines do not match the
known text of the Apache 2.0 license.

Change-Id: Ia994002384bf93fa999ac634bc6d4c711b5c9d60
Signed-off-by: Mats Wichmann <mats@linux.com>
19 months agosecurity: Declare strict void function 27/24127/2
Philippe Coval [Fri, 9 Feb 2018 10:09:06 +0000 (11:09 +0100)]
security:  Declare strict void function

Declare void functions as strict prototype
If built along -Wstrict-prototypes it will raise and error,
this is the case on TizenRT.

More patches to come to enable this flag by default.

Bug: https://jira.iotivity.org/browse/IOT-2539
Change-Id: I126edf8d9f74bbe679617a84b2e964a546422709
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>