iotivity.git
2 years agoprovide timeout error of server(504) value in ocstack. 31/17731/4
jihwan.seo [Thu, 23 Feb 2017 13:43:08 +0000 (22:43 +0900)]
provide timeout error of server(504) value in ocstack.

Change-Id: I5ad6b44c188b97fd60e65dc7d47259058520e2f7
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17731
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agobuild: Disable EDR for yocto like linux as not supported yet 57/17557/11
Philippe Coval [Tue, 28 Feb 2017 13:20:17 +0000 (14:20 +0100)]
build: Disable EDR for yocto like linux as not supported yet

Problem was observed when building on yocto's Poky (master)

Bug: https://jira.iotivity.org/browse/IOT-1745
Change-Id: I2e977fdb5ec4811874ab8d9d2a931ea659317c25
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17557
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
2 years agocsdk: prevent release build compiler warning from log tags 53/17753/6
George Nash [Tue, 7 Mar 2017 21:30:45 +0000 (13:30 -0800)]
csdk: prevent release build compiler warning from log tags

Changed `static char const TAG[]` used for logging to `#define TAG`
to prevent -Wunused-const-variable= warning when building code
in release mode.

Change-Id: Idaebfb26863a3a812573c8c40065ad9ff6ea356d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17753
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agofix timing issue for mutex access in ble 33/17733/3
jihwan.seo [Wed, 15 Feb 2017 10:21:37 +0000 (19:21 +0900)]
fix timing issue for mutex access in ble

Change-Id: I95917e8788bf3abce8c8cc143c5cf645286a5d5e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17733
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1583: Removing /W3 warnings inside connectivity/ (part 3) 49/17549/10
Pawel Winogrodzki [Tue, 28 Feb 2017 02:47:30 +0000 (18:47 -0800)]
IOT-1583: Removing /W3 warnings inside connectivity/ (part 3)

Removing the /W3 warnings in order to add the /WX option to prevent new
ones from being added inside the resource/csdk/connectivity/ directory.

Change-Id: Ie1bce977c027e985cd5ba14458d2026b5d391d4f
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17549
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agocsdk: cleanup compiler warnings in occlient and occlientcoll 49/17749/3
George Nash [Tue, 7 Mar 2017 20:45:32 +0000 (12:45 -0800)]
csdk: cleanup compiler warnings in occlient and occlientcoll

warnings -Wconversion-null and -Wmissing-field-initializers were
caused by trying to set a char array to NULL. Its now set to an
empty string. It is not removed so the entry count in the queryInterface
is the same as the number of test casses. The value is no longer used out
of the queryInterface.

If the TEST_GET_NULL test case is used it is special cased to use the
new InitGetRequestOnNullResource.

OC_UNUSED macro has been added to prevent the -Wunused-parameter warning.

Change-Id: I4a32e663bca574a6735f3efad2de42046328cc57
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17749
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agocsdk: fixed compiler warnings in stacktests.cpp 15/17715/3
George Nash [Tue, 7 Mar 2017 00:08:49 +0000 (16:08 -0800)]
csdk: fixed compiler warnings in stacktests.cpp

-Wsign-compare fixed using the `u` suffix on hardcoded
values so the compiler knows they are unsigned values.

Change-Id: Ic5261e816e477e90f089ddc468606b710115bded
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17715
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agoAdd properties for smoketest to run 89/17789/4
Larry Sachs [Wed, 8 Mar 2017 20:06:49 +0000 (12:06 -0800)]
Add properties for smoketest to run

Recent changes have added new properties.
PROJECT_VERSION and MULTIPLE_OWNER are now required.

Change-Id: Iae140a0d9c09f9604f6a50a04320b5f5d47cbde1
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17789
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agoRemove incorrect error message 27/17727/2
Dan Mihai [Tue, 7 Mar 2017 11:40:06 +0000 (03:40 -0800)]
Remove incorrect error message

Fix typo resulting in incorrect error message.

Change-Id: I0ffee0c873e6f1c08e510a48961d27d1a37a630f
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17727
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
2 years ago[IOT-1884] Allow IoTivity to generate and persist PIID 67/17667/8
Alex Kelley [Mon, 13 Feb 2017 19:57:20 +0000 (11:57 -0800)]
[IOT-1884] Allow IoTivity to generate and persist PIID

 1. Generate a PIID for the device so that one is always available.
 2. Add the ability to store and retrieve the PIID from a new .dat
    file so it remains persistent across reboots of the device.
    - This .dat file can be updated to handle other information
      relevant to the device in the future.
 3. Update the PIID in the .dat file if the application wants to
    use a specific PIID.
 4. Update PSInterface to handle different databases instead of
    just the security database.
 5. Update the json2cbor tool to make it easy for developers to
    generate .dat files to specify PIID.
 6. Add example JSON and .dat files for specifying a PIID.

Change-Id: Ic556508ea0fb053386d76b2578721debea8ac046
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17667
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoFormat the two Apple-related SConscripts to Python coding standards 83/17583/8
Mats Wichmann [Wed, 1 Mar 2017 15:51:33 +0000 (08:51 -0700)]
Format the two Apple-related SConscripts to Python coding standards

No functional changes.  Change is made preparatory to pushing a
patch for iot-1862 for a problem in darwin/SConscript

Change-Id: I8a8e492b352871252641d6ffa032c4f2b9f76f15
Signed-off-by: Mats Wichmann <mats@linux.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17583
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoresource-directory: Fix libs dependencies and order 51/17651/10
Philippe Coval [Fri, 3 Mar 2017 00:04:22 +0000 (01:04 +0100)]
resource-directory: Fix libs dependencies and order

Problem was observed when building on yocto

Bug: https://jira.iotivity.org/browse/IOT-1745
Change-Id: I1246cd5bb83738a14fa0aa9e68cf35c4fbc8cbac
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17651
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1868 [C++ layer] Make OCPlatform start and stop reliably 85/17685/8
Way Vadhanasin [Tue, 7 Mar 2017 00:09:50 +0000 (16:09 -0800)]
IOT-1868 [C++ layer] Make OCPlatform start and stop reliably

This change adds reference count to OCPlatform's static start and
stop functions and synchronizes them. It does the following:

1. Ensures that calls to the "C" APIs OCInit and OCStop are balanced.
2. Maintains backward compatibility by introducing new PlatformConfig
   constructor and deprecate the old ones.
3. Updates the existing unit tests and samples.

Because this change allows the framework to stop properly, it exposes
some existing IoTivity leaks in Jenkins (Valgrind validation). Thus
the following leaks are fixed in this change to allow successful
Jenkins runs:

1. caipadapter.c: endpoint cache leak in UDP (no issue for TCP).
- https://build.iotivity.org/ci/job/iotivity-verify-unit_tests/
10907/valgrindResult/pid=24498,0x3fe

2. psinterface.c: CBOR buffer leaks in CreateResetProfile.
- https://build.iotivity.org/ci/job/iotivity-verify-unit_tests/
10922/valgrindResult/pid=2316,0x3ad

3. ocstack.c & securityResourceManager.cpp: persistent storage buffer
leaks as a result of restarting and switching OCPlatform
configuration after shutdown (e.g., between tests).
https://build.iotivity.org/ci/job/iotivity-verify-unit_tests/
10922/valgrindResult/pid=2316,0x3ad

4. OCRepresentationEncodingTest.cpp: representation value leaks.
- https://build.iotivity.org/ci/job/iotivity-verify-unit_tests/
10922/valgrindResult/pid=2316,0x3a9

5. runtest.py: change Valgrind callstack size from the default value
of 12 to 24 so that the test name is visible in the report. Helpful
for reproducibility.

Change-Id: I79406f2cf4282efbb29a69c14e42aae928f54bae
Signed-off-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17685
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoFix a defect detected by static code analyzer 01/17601/7
Jihun Ha [Wed, 8 Mar 2017 13:33:41 +0000 (22:33 +0900)]
Fix a defect detected by static code analyzer

A logic to check a failure of malloc is added.

Change-Id: I1414673e0745fa11c4358e39ea6fedc9e26277ad
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17601
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoSecurity and connectivity defects fix 19/17319/4
Oleksii Beketov [Thu, 16 Feb 2017 10:59:27 +0000 (12:59 +0200)]
Security and connectivity defects fix

Some minor defects (NULL checks and double frees) fixed.

Change-Id: I066a238a9379d45d1f377cc5a144c0bc0a97ccb7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17039
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17319

2 years agoAdd API to set a MOT status. 17/17217/10
Chul Lee [Thu, 9 Mar 2017 02:08:46 +0000 (11:08 +0900)]
Add API to set a MOT status.

Change-Id: I08ab5b4c0d07034d71429ac8698e5ed4763ced2c
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16585
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 60153a2e8d029a9b0280f4b47d615919b73b1519)
Reviewed-on: https://gerrit.iotivity.org/gerrit/17217

2 years agoUpdate PDM 09/17309/13
Chul Lee [Wed, 8 Mar 2017 23:13:39 +0000 (08:13 +0900)]
Update PDM

This patch addresses the following exceptional cases :
 1. The PT terminates unexpectedly.
    - Start the OTM process
    - Device information will be changed to INIT state.
    - PT terminated while OTM.
    - Restart the PT process.
    - Retry the OTM process.
    * OTM start will be failed due to device info already save as INIT state.

  2. Timeout is occured PT side while OTM.
    - Start the OTM process
    - Device information will be changed to INIT state.
    - OTM timeout is occured at the application side.
    - PT retry the OTM.
    * OTM start will be failed due to device info already save as INIT state.

I've added defence code and
added cleanup API that can be used when timeout occurs.

Patch #1 : Initial upload
Patch #2 : Retrigger
Patch #3 : Fix the bug for incorrect PIN inputed while random PIN OxM.
Patch #4-5 : Retrigger
Patch #6 : minor bug fix
Patch #7-8 : Retrigger
Patch #9 : Fix the incorrect log
Patch #10 : Retrigger
Patch #12 : Retrigger

Change-Id: I7781c0d864db6fdac93fa41acbcbf1ac123d15da
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16187
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17309

2 years agoFix build break on -release builds 57/17757/5
Mike Fenelon [Tue, 7 Mar 2017 23:56:12 +0000 (15:56 -0800)]
Fix build break on -release builds

The OC_UNUSED macro is defined in octypes.h which is not included
by the source file. Switching to (void) to minimize the amount of
changes required to fix.

Change-Id: I76c13d448eb568b7f55dcd3974b8ee8891b01098
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17757
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years ago[IOT-1888] Fix /W4 warnings present when building with -noSecurity or -release 55/17755/3
Alex Kelley [Tue, 7 Mar 2017 01:03:44 +0000 (17:03 -0800)]
[IOT-1888] Fix /W4 warnings present when building with -noSecurity or -release

Change-Id: I70ff36b675418f7e441b1af594d922c231430918
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17755
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoClean up compiler warnings found in provisioningclient 47/17447/5
George Nash [Tue, 21 Feb 2017 23:40:57 +0000 (15:40 -0800)]
Clean up compiler warnings found in provisioningclient

Compiler warnings fixed are:
 - unused-parameter fixed by using OC_UNUSED macro
 - type-limits fixed by changing the return type from size_t to off_t
   that is returned by the ftello function.
 - sign-compare fixed by replacing int with size_t where needed
 - format= fixed by replacing %d in printf and scanf with PRIuPTR or SCNuPTR
   from the cinttypes header.

Change-Id: I070ea24193b95ed65d8e3ea914ba8f5b69986f84
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17447
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years agoIOT-1583: Removing IoTivity libs from scons Check* calls. 41/17641/11
Pawel Winogrodzki [Wed, 15 Feb 2017 01:19:01 +0000 (17:19 -0800)]
IOT-1583: Removing IoTivity libs from scons Check* calls.

Due to a scons bug (http://scons.tigris.org/issues/show_bug.cgi?id=3036)
part of the build failures were being silently ignored and led
to cases where failing code ended up being merged.

Additionally, scons weren't picking up changes in files influenced
by the mentioned bug, so it required doing a clean build every time.

Change-Id: Ib63fb1105bceafae59573aa0c15af279e8ffdb6d
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17641
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
2 years agoIOT-1583: Disabling harmless /W4 warnings. 39/17639/4
Pawel Winogrodzki [Thu, 2 Mar 2017 10:23:23 +0000 (02:23 -0800)]
IOT-1583: Disabling harmless /W4 warnings.

In preparation for libcoap /W4 fixes we're disabling warnings,
which do not cause any potential issues.

Change-Id: I136b34f2d5824efcc052b2c7f3a0b8315c8f3f23
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17639
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
2 years agoIOT-1583: Adding /W4 and /WX to timer build. 13/17513/9
Pawel Winogrodzki [Wed, 15 Feb 2017 03:22:57 +0000 (19:22 -0800)]
IOT-1583: Adding /W4 and /WX to timer build.

Making sure any version changes of timer don't introduce
level 4 warnings.

I'm also changing the return value of StartRetransmit() inside
ca_adapter_net_ssl.c, since it's being used as a timer callback,
which doesn't return any values. Nowhere in the code was the returned
value of that function read.

Change-Id: Ic401ae27c5af46b05a21868dfa0c020ee6429f20
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17513
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
2 years ago[IOT-1873] Implement OCF Security CR50 07/17607/4
Dan Mihai [Wed, 1 Mar 2017 03:28:30 +0000 (19:28 -0800)]
[IOT-1873] Implement OCF Security CR50

1. Removed entire resource:

/oic/sec/svc

2. Removed resource properties:
    a. From /oic/sec/amacl:
        rowneruuid
        ams
        amsuuid
    b. From /oic/sec/pstat:
        deviceuuid

Change-Id: I7bbe344feb0a99ca2f8d5e77eef64f840164bc20
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17607
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years agoApply Java API which can start transport type in initialization 87/17687/6
jihwan.seo [Fri, 24 Feb 2017 07:01:24 +0000 (16:01 +0900)]
Apply Java API which can start transport type in initialization

this patch is related to https://gerrit.iotivity.org/gerrit/#/c/16433/

Change-Id: I405306ef94add209e8743fc4636855a5263df58c
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17687
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agofix build failure related implicit typecasting with X86 in bridging. 25/17725/6
jihwan.seo [Tue, 7 Mar 2017 10:08:23 +0000 (19:08 +0900)]
fix build failure related implicit typecasting with X86 in bridging.

[Error Message]
bridging/plugins/lifx_plugin/lifx_objects/lifx.cpp:219:9: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'std::vector<std::shared_ptr<LifxLight> >::size_type {aka unsigned int}' [-Werror=format]
bridging/plugins/hue_plugin/hue_resource.cpp: In function 'OCEntityHandlerResult processGetRequest(OCRepPayload*, HueLightSharedPtr, std::string)':
bridging/plugins/hue_plugin/hue_resource.cpp:842:9: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format]
bridging/plugins/hue_plugin/hue_resource.cpp:842:9: error: format '%d' expects argument of type 'int', but argument 5 has type 'uint64_t {aka long long unsigned int}' [-Werror=format]
bridging/plugins/hue_plugin/hue_resource.cpp: In function 'OCEntityHandlerResult processPutRequest(OCEntityHandlerRequest*, HueLightSharedPtr, std::string, OCRepPayload*)':
bridging/plugins/hue_plugin/hue_resource.cpp:897:9: error: format '%d' expects argument of type 'int', but argument 4 has type 'int64_t {aka long long int}' [-Werror=format]
bridging/plugins/hue_plugin/hue_resource.cpp:932:13: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format]
bridging/plugins/hue_plugin/hue_resource.cpp:943:13: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format]

Change-Id: I39977d75810b4eb9b4bc0fc008825330fd12c0af
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17725
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years agoSupport for partial chroma resource updation in hue plugin 51/17751/2
vijendrx [Tue, 7 Mar 2017 12:14:40 +0000 (17:44 +0530)]
Support for partial chroma resource updation in hue plugin

Added support for updating hue and saturation attributes of
chroma resource in hue plugin on an individual basis.

Change-Id: Ia07e9a858cc3190d0cd4df77f566ef6abc5bd539
Signed-off-by: vijendrx <vijendrax.kumar@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17751
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years ago[IOT-1903] Change to set single adapter flag for cloud notification 61/17761/2
ch79.cho [Wed, 8 Mar 2017 07:22:30 +0000 (16:22 +0900)]
[IOT-1903] Change to set single adapter flag for cloud notification

Fixed to set sindle adapter flag such as OC_ADAPTER_IP and OC_ADAPTER_TCP
during address parsing because multiple set of adapters caused an error
from base layer to handle it.

Change-Id: I7754d9d305d8c29f8d775d802164f5ccd761614b
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17761
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoremove unneccessary brace code in NS logger. 21/17721/2
jihwan.seo [Tue, 7 Mar 2017 08:11:04 +0000 (17:11 +0900)]
remove unneccessary brace code in NS logger.

since we can't enclose a block in C in braces (()).
it is better to remove in NS logger

Change-Id: I33a721155916f4c0eb17e6d34f3e7fbf8440625e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17721
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoAdded deprecated method for backward compatibility 65/17065/7
Randeep Singh [Mon, 6 Feb 2017 09:07:17 +0000 (14:37 +0530)]
Added deprecated method for backward compatibility

setOwnerTransferCallbackData was removed and new api setInputPinCallback
was introduced. In this patch setOwnerTransferCallbackData is added as
deprecated API to maintain backward compatibility.

Change-Id: I0b5fffa476d466c526e2e5bf63ba9186b7dbdf9c
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17065
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Youngman Jung <yman.jung@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoChanged callbackwrapper visibility to private 91/17091/7
Youngman [Wed, 8 Feb 2017 00:56:26 +0000 (09:56 +0900)]
Changed callbackwrapper visibility to private

currently callbackWrapper is public api but is used only internally, so changed its visibility to private

Change-Id: Ic39128dca13a1342103c5cfc8276abfa806f31d4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Youngman <yman.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17091
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoResolved svace issues 59/17259/8
amar [Wed, 1 Feb 2017 08:49:18 +0000 (14:19 +0530)]
Resolved svace issues

Change-Id: Id3aa9a857756a0cda216a12dbef42d9e326998c2
Signed-off-by: amar srivastava <amar.sri@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17041
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2046a5e2643b54a29ee39ce67677b7d574baa832)
Reviewed-on: https://gerrit.iotivity.org/gerrit/17259
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years ago[IOT-1829] findResourceList is not implemented in Java API 13/17713/5
Larry Sachs [Mon, 6 Mar 2017 23:02:40 +0000 (15:02 -0800)]
[IOT-1829] findResourceList is not implemented in Java API

Added jni calls to support new c sdk api to return a list of resources.

OcPlatform.java now has findResources() methods that take a
OnResourcesFoundListener as a callback which has a method for the
returned array of found resources.

Change-Id: Ia874294d0a73b35f7bd23b15d9c122df2622cfdc
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17713
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agosecurity: Link test to oc lib for yocto 61/17561/11
Philippe Coval [Tue, 28 Feb 2017 13:20:17 +0000 (14:20 +0100)]
security: Link test to oc lib for yocto

Problem was observed when building with yocto (master)

Bug: https://jira.iotivity.org/browse/IOT-1745
Change-Id: Ie0c6e692972ca10142a074c3d099a76284774c26
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17561
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
2 years ago[IOT-1887] Android apps fail to run 11/17711/2
Larry Sachs [Mon, 6 Mar 2017 22:47:49 +0000 (14:47 -0800)]
[IOT-1887] Android apps fail to run

Changed java/iotivity-android/build.gradle to copy libresource_directory.so
into the sample app apk files.

As a result of that change, the service/notification builds need to specfically
exclude that library.

Tested with running simple server/client apps on nexus 9.

Change-Id: I2143c37d424614e50a877f0c8c5153387f0a2b09
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17711
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agoIntegrated the version info of IoTivity 27/16527/15
Jaewook Jung [Wed, 18 Jan 2017 10:09:20 +0000 (19:09 +0900)]
Integrated the version info of IoTivity

The version of IoTivity is hard-coded in several files
and it is hard to manage.
So I integrated some of them except spec files for tizen.

The version info will be handled in octypes.h and
/build_common/SConscript.

And made applications can get the version info.
 - C/C++ : 'IOTIVITY_VERSION' in octype.h
 - Java  : 'OCPlatform.getIoTivityVersion()'

Change-Id: Ief7a7ba104faaa9397c314e4efa9426c81a7c0ed
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16527
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoUse os.rename for renaming 03/17703/2
Dan Mihai [Mon, 6 Mar 2017 16:37:37 +0000 (08:37 -0800)]
Use os.rename for renaming

'mv' is not a valid Windows system command.

Change-Id: I25116d6a22e8b664c99ca251231e05af2c97aeb2
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17703
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Mats Wichmann <mats@linux.com>
Reviewed-by: Gaganpreet Kaur <gaganpreetx.kaur@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoAdding Android wrapper to set a seed value for UUID generation 75/16875/7
saurabh.s9 [Tue, 17 Jan 2017 11:33:51 +0000 (17:03 +0530)]
Adding Android wrapper to set a seed value for UUID generation

Change-Id: Id123f745b4409bebbd5cccf9b0d7d8b7e3b7a08d
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16493
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16875
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agoDisable warning 4429 in test code 79/17679/4
Greg Zaverucha [Mon, 6 Mar 2017 18:24:13 +0000 (10:24 -0800)]
Disable warning 4429 in test code

This warning was being produced incorrectly, and causing a build break.

Change-Id: Ifcd71e471fd4fa92ca080006149b1f218fcbaa71
Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17679
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
2 years agoHandle security test failures 89/17489/7
Pawel Winogrodzki [Fri, 24 Feb 2017 01:28:17 +0000 (17:28 -0800)]
Handle security test failures

Disable SRPSaveTrustCertChain* which always fail (IOT-1846)
Fix typo in "TLSAdaper"
Disable TLSAdapter tests that have socket bugs (IOT-1848)
Change exit() calls to EXPECT calls so tests continue gracefully
Make socketOpen_server() work on Windows

Change-Id: Ie2b027a4539845975667709ef60497c345fae2b0
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17489
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years agoLog message ID in host byte order 55/17455/3
Dan Mihai [Wed, 22 Feb 2017 22:56:07 +0000 (14:56 -0800)]
Log message ID in host byte order

Both libcoap and CTT use the host byte order, so this change helps
correlate their log contents with the IoTivity logs.

Change-Id: If8b91a35017329a1a2a5bbe2770c71122c2f382a
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17455
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Tested-by: Mike Fenelon <mike.fenelon@microsoft.com>
2 years agoFix WITH_RA build break 95/17695/2
Dan Mihai [Mon, 6 Mar 2017 15:42:49 +0000 (07:42 -0800)]
Fix WITH_RA build break

Type mismatched introduced by change
ea63cd55d8ade049d37bb3cfb7b7b27b4bce0b6d.

Change-Id: Ifbfed6ceb59dcaa7e6bf6cecf54219da5331cf8c
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17695
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoFixed memory leak on cablockwisetransfer.c 55/17555/10
Jaewook Jung [Tue, 28 Feb 2017 09:50:20 +0000 (18:50 +0900)]
Fixed memory leak on cablockwisetransfer.c

Fixed memory leak on cablockwisetransfer.c detected by static analysis

Change-Id: I4cf2d20bf1303b2a9727494a4d2f0718b2d91330
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17555
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1583: Disabling rebuild of config headers with every scons run. 15/17415/32
Pawel Winogrodzki [Fri, 3 Mar 2017 02:15:14 +0000 (18:15 -0800)]
IOT-1583: Disabling rebuild of config headers with every scons run.

I'm changing the scons behavior to only rebuild the config headers
if they don't exist, so scons wouldn't rebuild everything, what depends
on these headers.

I'm also making small fixes to make sure the generated headers are removed
when scons is run with "-c".

Change-Id: I4b8cf9cafac26e8d619280dccb1c14dab7c437cc
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17415
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1583: Removing /W3 warnings inside connectivity/ (part 2) 47/17547/20
Pawel Winogrodzki [Tue, 28 Feb 2017 02:37:57 +0000 (18:37 -0800)]
IOT-1583: Removing /W3 warnings inside connectivity/ (part 2)

Removing the /W3 warnings in order to add the /WX option to prevent new
ones from being added inside the resource/csdk/connectivity/ directory.

Change-Id: I13cd0b6058693432e3eb57f4bf7a1bfa0fa6f015
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17547
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
2 years agoFixed documentation warnings for cpp-docs 69/17569/3
George Nash [Tue, 28 Feb 2017 18:28:35 +0000 (10:28 -0800)]
Fixed documentation warnings for cpp-docs

Fixed all of the documentation warnings found when running
Doxygen for C++ documentation.

Most of the warnings were due to @param tag not matching
the actual param.

For the copydoc warning foun in OCPlatform the @copydoc
tag was removed because it was not properly copying the
documentation. No clear fix other than actually copying
the documentation.

Change-Id: Ic861ff7dbeb9c7f17d7f39dace05da92f3bb43d1
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17569
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoFixed compilar warning in ocserver 29/17629/3
George Nash [Thu, 2 Mar 2017 18:59:22 +0000 (10:59 -0800)]
Fixed compilar warning in ocserver

The -Wformat= warning was fixed by replacing
the %lld flag with the PRId64 or SCNd64 macro
from the inttypes.

Change-Id: I79b289d79ee2b918ec0947815f2dc6e6d3c07f3c
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17629
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
2 years agoFixed typo on OCInit1() 29/17529/8
Jaewook Jung [Mon, 27 Feb 2017 10:51:13 +0000 (19:51 +0900)]
Fixed typo on OCInit1()

Change-Id: I3cdf6ec363a7ba6b77c49011be6a417f1359049b
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17529
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoFixed documentation warnings for c-docs 43/17543/6
George Nash [Tue, 28 Feb 2017 00:00:02 +0000 (16:00 -0800)]
Fixed documentation warnings for c-docs

Fixed all of the documentation warnings found when running
Doxygen for the C documentation.

All of the documentation warnings fell into 3 areas:
1. Error using the @param[in,out] syntax
2. @param did not match the actual parameter name
3. Paramerter was missing documentation all together

For  case 3 an attempt to provide the best documentation
was done based on context. In a few situations the parameter
documentation is just restating the type of parameter being
passed in.

Change-Id: I06797a471dcefaaa2d9b50dc44ca4228cfafb941
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17543
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1867 Add reference count to OCInit and OCStop 25/17625/10
Way Vadhanasin [Sat, 4 Mar 2017 07:16:04 +0000 (23:16 -0800)]
IOT-1867 Add reference count to OCInit and OCStop

This change adds reference count to OCStack and synchronizes the two
C APIs.

The change also introduces ocatomic.h, which defines some useful
atomic utility functions.

Change-Id: I2ea4023ab1d1dfda882a0d289db6d8ffdac1bdc4
Signed-off-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17625
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoIOT-1583: Removing /W3 warnings inside connectivity/ (part 1) 19/17419/19
Pawel Winogrodzki [Wed, 22 Feb 2017 02:29:14 +0000 (18:29 -0800)]
IOT-1583: Removing /W3 warnings inside connectivity/ (part 1)

Removing the /W3 warnings in order to add the /WX option to prevent new
ones from being added inside the resource/csdk/connectivity/ directory.

Change-Id: Ibd53ad378b5d960ea59f2e2c61254a9257d03a3e
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17419
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years ago[IOT-1861] Fix self-deadlock during OT 05/17605/7
Dan Mihai [Thu, 2 Mar 2017 02:14:57 +0000 (18:14 -0800)]
[IOT-1861] Fix self-deadlock during OT

Avoid acquiring g_sslContextMutex recursively during Ownership
Transfer. Instead, make it a requirement that the caller must
own this lock.

Finding a better solution for this old problem is now tracked
by IOT-1876.

Change-Id: I25ce19a5c48c5adab70e2287288833e40c4db213
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17605
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
2 years agobuild: Apply OCF patch if needed 67/16967/12
Philippe Coval [Wed, 1 Feb 2017 12:53:41 +0000 (13:53 +0100)]
build: Apply OCF patch if needed

Bug: https://jira.iotivity.org/browse/IOT-1745
Change-Id: I2928fed0a97b51f358a0f87f35b164317b4d7b9d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/16967/
Reviewed-on: https://gerrit.iotivity.org/gerrit/16967
Reviewed-by: Mats Wichmann <mats@linux.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years agoIOT-1874 Enable /W4 /WX for resource/csdk/security 91/17591/2
Alex Kelley [Wed, 1 Mar 2017 05:39:10 +0000 (21:39 -0800)]
IOT-1874 Enable /W4 /WX for resource/csdk/security

Change-Id: Ib4b1fbd905a1c8510128f422b6b39d3ef4e42f45
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17591
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years ago[IOT-1878] Windows: Fix build breaks 57/17657/2
Dan Mihai [Fri, 3 Mar 2017 16:07:15 +0000 (08:07 -0800)]
[IOT-1878] Windows: Fix build breaks

Don't try to link with both:
    1. Static lib ocsrm.lib
    2. Import lib octbstack.lib
because octbstack.lib provides references to the copy of ocsrm.lib
that is linked inside octbstack.dll.

Change-Id: I91ec755a58f9fbdf6d203daa3b9ad2cc7ada7988
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17657
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Mats Wichmann <mats@linux.com>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
2 years agoFixed Dtls cookie context setup 83/17283/4
Joonghwan Lee [Wed, 15 Feb 2017 02:01:16 +0000 (11:01 +0900)]
Fixed Dtls cookie context setup

This patch moves DTLS cookie context under SslContext struct and
updates relavant cookie setup operation in order to fix the dtls reconnect.
Also it might be happened a crash when one among sessions is removed
and some client try to reconnect because SslEndPoint has cookie context.

Patch 1: Initial upload
Patch 2: Added __WITH_DTLS__ preprocess define

Change-Id: I271047d458fd1fb5f5477f362c140f1764ae1f2e
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17283
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
2 years agoUpdate Update OCF log level for NS LOG. 23/17523/2
jake [Mon, 27 Feb 2017 07:18:38 +0000 (16:18 +0900)]
Update Update OCF log level for NS LOG.

 - Change DEBUG to INFO_PRIVATE in NS LOG with private data

Change-Id: I69a764e8a1fc9c1cc4a1a4e9785d658dd9d754bd
Signed-off-by: jake <jaehong2.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17523
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
2 years agoAdd more detailed ACE logging 91/17491/4
Dan Mihai [Thu, 23 Feb 2017 22:29:54 +0000 (14:29 -0800)]
Add more detailed ACE logging

This additional logging has been useful for investigating recent CTT
failures related to Access Control.

Output is similar to:

OIC_SRM_ACL: GetACLResourceData: found matching ACE:
OIC_SRM_ACL: =================================================
OIC_SRM_ACL: ACE @ 000001AE29C86FC0
OIC_SRM_ACL:     permission = 0x2
OIC_SRM_ACL:     subjectuuid = 2a000000-0000-0000-0000-000000000
OIC_SRM_ACL:     resources[0]:
OIC_SRM_ACL:         href = /oic/res
OIC_SRM_ACL:         types[0] = oic.wk.res
OIC_SRM_ACL:         interfaces[0] = oic.if.ll
OIC_SRM_ACL:     resources[1]:
OIC_SRM_ACL:         href = /oic/d
OIC_SRM_ACL:         types[0] = oic.wk.d
OIC_SRM_ACL:         interfaces[0] = oic.if.baseline
OIC_SRM_ACL:         interfaces[1] = oic.if.r
OIC_SRM_ACL:     resources[2]:
OIC_SRM_ACL:         href = /oic/p
OIC_SRM_ACL:         types[0] = oic.wk.p
OIC_SRM_ACL:         interfaces[0] = oic.if.baseline
OIC_SRM_ACL:         interfaces[1] = oic.if.r
OIC_SRM_ACL: =================================================

Change-Id: Ib4fd44bcc7be09d426b09cc955894aab2455a711
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17491
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years agoAdd callback to close a PIN display. 67/17267/5
Chul Lee [Tue, 14 Feb 2017 10:50:31 +0000 (19:50 +0900)]
Add callback to close a PIN display.

Change-Id: Ifad924b7d700d03af43997dbfdd604b72bd09cc5
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17267
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years agoRemove unnecessary glib dependency in security 63/17463/2
Youngman [Thu, 23 Feb 2017 06:49:51 +0000 (15:49 +0900)]
Remove unnecessary glib dependency in security

Change-Id: Ic2eaca23d5d64f2433e3aaf5c1bd04767a383d66
Signed-off-by: Youngman <yman.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17463
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years agoFix warning from static analyzer 09/17609/2
jake [Thu, 2 Mar 2017 05:11:49 +0000 (14:11 +0900)]
Fix warning from static analyzer

 - Remove unnecessary function (isdigit)
   * it is valid function when the param is char but used int param
 - Add memory free when return error.

Change-Id: I1bbecc7e88f8973340299b8393736e6fd24f1587
Signed-off-by: jake <jaehong2.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17609
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoFixed core dump during Security Discovery 97/17497/3
js126.lee [Fri, 24 Feb 2017 08:16:18 +0000 (17:16 +0900)]
Fixed core dump during Security Discovery

Issue : Core dump occur in (un)owned device discovery on provisionclient sample,
        when build option with SECURED=1 WITH_TCP=1 WITH_CLOUD=1.
Cause : Incorrect condition to set remoteId in OCHandleResponse.
        So, wrong type casting happen as OCDiscoveryPayload,
        and then core dump occure in OCCMDiscoveryResource function.
        (https://gerrit.iotivity.org/gerrit/#/c/15909)

Change-Id: I5a4c521ad14f8d5a6a9ec944cfdcfc3b705e409d
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17497
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
2 years agoSupport for multiple ciphersuites 33/16633/18
Jongmin Choi [Tue, 28 Feb 2017 08:39:41 +0000 (17:39 +0900)]
Support for multiple ciphersuites

SetupCipher() modified to support multiple ciphersuites
rather than using a fixed one

Patch #1: initial upload
Patch #2: Rebased and SetupCipher() related changes applied
Patch #3: Rebased

Change-Id: I6cb57605984c273bcdb98c5130da9a9995ae50db
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16251
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16633

2 years agoIOT-1869: Fixing Windows builds with "logging" option. 45/17545/5
Pawel Winogrodzki [Tue, 28 Feb 2017 00:48:50 +0000 (16:48 -0800)]
IOT-1869: Fixing Windows builds with "logging" option.

A fix for the broken Windows build, if run.bat was used
with the "-logging" option.

Change-Id: Ic8d506535889c9dd948310461d6b60516b597096
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17545
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
2 years agoChange property names for IoTivity only security features 15/17315/4
Jongmin Choi [Thu, 26 Jan 2017 04:10:22 +0000 (13:10 +0900)]
Change property names for IoTivity only security features

IoTivity only security property names changed to use "x.org.iotivity"

Patch #1: initial upload

Change-Id: Iee08b3e0a4d862d90fec5c6be738e8e70bf9d037
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16791
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17315

2 years agoUpdate sample SVR DB for MOT 37/17137/10
Chul Lee [Mon, 6 Feb 2017 08:28:20 +0000 (17:28 +0900)]
Update sample SVR DB for MOT

according to https://gerrit.iotivity.org/gerrit/#/c/16791/

Change-Id: Ia765112faa639e40770f35e3a34bcd51db60a340
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17063
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17137
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
2 years agoAdding Android API's for Multiple Owner Transfer (MOT) 29/17329/3
Randeep Singh [Fri, 17 Feb 2017 05:58:24 +0000 (11:28 +0530)]
Adding Android API's for Multiple Owner Transfer (MOT)

Change-Id: I3fd43ae1285989f1a316d4fbeeb4684ace893b53
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17329
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years agoIOT-1836 Make resource/csdk/security/provisioning W4 compliant. 01/17401/8
Alex Kelley [Wed, 15 Feb 2017 23:59:02 +0000 (15:59 -0800)]
IOT-1836 Make resource/csdk/security/provisioning W4 compliant.

These changes include the following:
- Fix W4 warnings under resource/csdk/security/provisioning

Other changes to resource/csdk/security/ are tracked in the IOT-1835 code review.

Change-Id: Ibf9d1e1bc70bc37ddead0f97d38964f01d712d54
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17401
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years agoIOT-1835 Make resource/csdk/security W4 compliant. 99/17399/7
Alex Kelley [Wed, 15 Feb 2017 23:50:32 +0000 (15:50 -0800)]
IOT-1835 Make resource/csdk/security W4 compliant.

These changes include the following:
- Prepare resource/csdk/security/SConscript to enable /W4.
- Fix W4 warnings under resource/csdk/security/src
- Fix W4 warnings under resource/csdk/security/tool

Changes to resource/csdk/security/provisioning will come in another review.

Change-Id: I3a26fa952103b3b218569155cd1341aa696944e1
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17399
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
2 years ago[IOT-1845] Fix session leak 85/17485/2
Dan Mihai [Thu, 23 Feb 2017 21:53:42 +0000 (13:53 -0800)]
[IOT-1845] Fix session leak

1. Close OCDoOwnershipTransfer session after successful Ownership
   Transfer (i.e., from ReadyForNomalStatusHandler).

2. Use OC_STACK_UNAUTHORIZED_REQ instead of the CA result returned
   by CAcloseSslConnection when calling SetResult - because SetResult
   expects an OC result as parameter.

Change-Id: I075f7fe168a35a0ab6f5c74f1faa12108156727b
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17485
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
2 years agoMove common Callback test helper to gtest_helper.h. 25/17325/6
Todd Malsbary [Thu, 16 Feb 2017 17:53:53 +0000 (09:53 -0800)]
Move common Callback test helper to gtest_helper.h.

This code was present in both stacktests.cpp and rdtests.cpp.

Change-Id: Ie0b7366fdc23986460994a947e57b8f222129dcc
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17325
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agocsdk: Use OIC_LOG instead of OIC_LOG_V for logging single string 39/17439/5
Philippe Coval [Wed, 22 Feb 2017 18:31:40 +0000 (19:31 +0100)]
csdk: Use OIC_LOG instead of OIC_LOG_V for logging single string

This was creating mess with arduino macros (using VA lists).
An other patch to come later

Change-Id: I9657e11c96e84f375408e732917a275c7c3c1fb0
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17439
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agosecurity: Conditionnal include of mbedtls 73/17473/2
Philippe Coval [Thu, 23 Feb 2017 11:32:55 +0000 (12:32 +0100)]
security: Conditionnal include of mbedtls

Change-Id: I13155cbd4425421c340db74e60c367a76d529cec
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17473
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
2 years agobuild: Enable security by default 73/12073/9
Philippe Coval [Wed, 21 Sep 2016 14:11:02 +0000 (16:11 +0200)]
build: Enable security by default

From now on, developer will need to disable security explicitly:
  scons SECURED=0

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Ic09acf3996b47799020730fc34cd382325a981d8
Origin: https://gerrit.iotivity.org/gerrit/#/c/12073/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12073
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
2 years agoResolving svace issues 95/17295/7
amar [Thu, 2 Feb 2017 04:54:47 +0000 (13:54 +0900)]
Resolving svace issues

Change-Id: I9086e50f802d93dbacf45858646ddfd828791296
Signed-off-by: Amar Srivastava <amar.sri@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17043
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17295
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
2 years ago[IOT-1851] Update log level for private info 95/17495/2
ch79.cho [Fri, 24 Feb 2017 08:10:57 +0000 (17:10 +0900)]
[IOT-1851] Update log level for private info

Extended log levels for noti-service to print private info
seperately such as uuid and IP address.

Change-Id: I17cdbc515d581644b7e40902eb2924cd2e614bea
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17495
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoUnregister CA Network Monitor 67/17467/2
ch79.cho [Thu, 23 Feb 2017 11:09:14 +0000 (20:09 +0900)]
Unregister CA Network Monitor

unregisted a listener to monitor the network status from CA.
The listener has not been unregisted when stopping noti-provider.

Change-Id: I236f11db64d8dd02f6dff957719eef912e4b6f5b
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17467
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years ago[IOT-1850] Fix logging on Notification service. 93/17493/3
KIM JungYong [Fri, 24 Feb 2017 05:10:04 +0000 (14:10 +0900)]
[IOT-1850] Fix logging on Notification service.

Unsafe location of log was moved to safety location.

Bugs: https://jira.iotivity.org/browse/IOT-1850
Change-Id: I5ba9537f10546e1eff6968ec2dcdd95ec04abf34
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17493
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
2 years agoFix calling invalid CAfunction on Notification service. 61/17461/3
KIM JungYong [Thu, 23 Feb 2017 05:58:43 +0000 (14:58 +0900)]
Fix calling invalid CAfunction on Notification service.

When consumer service terminated,
consumer service will unregister Network monitoring.
but, consumer service call invalid function.

In this patch,
modify calling with valid function for unregister monitoring.

Change-Id: I89c5a7f022d144c2b98a43fd956a4155d708a4c6
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17461
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agobuild: Update to 1.3.0 31/16831/2
Philippe Coval [Fri, 27 Jan 2017 15:23:29 +0000 (16:23 +0100)]
build: Update to 1.3.0

Note libcoap still uses IoTivity-1.2.1 branch:
extlibs/libcoap/SConscript

It could be updated in later patch, to be tracked on this page:
https://wiki.iotivity.org/build

Change-Id: I92e93372886380e716c6bf9212035c3925df415a
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16831
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years ago[IOT-1207] Endpoint C++ API 97/10797/84
bg.chun [Tue, 23 Aug 2016 10:06:01 +0000 (19:06 +0900)]
[IOT-1207] Endpoint C++ API

Provide public C++ api for map ocf endpoint flag to resource in server
and change host of resource in client.

Change-Id: I2f4892144c9732fb38162b7174812fa8c51ce02c
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10797
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoMoved a requestId declaration in OCServerRequest 93/17293/8
hyuna0213.jo [Thu, 2 Feb 2017 07:48:37 +0000 (16:48 +0900)]
Moved a requestId declaration in OCServerRequest

we should not add attributes after payload as they get overwritten
when payload content gets copied over.

Change-Id: I0c8a430f92c2196d3f9c816e9ba9d16fd44d88e4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17015
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17293

2 years ago[IOT-1840] Fix incorrect check for IPv4 when generating endpoint 31/17431/3
Todd Malsbary [Wed, 22 Feb 2017 17:26:06 +0000 (09:26 -0800)]
[IOT-1840] Fix incorrect check for IPv4 when generating endpoint
string.

Bug: https://jira.iotivity.org/browse/IOT-1840
Change-Id: I6950ba6a06965f94848d7fb53d13f416fa4906b3
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17431
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoPer CR-47 (doxmtype URN Correction), renamed references to oic.sec.oxm to oic.sec... 91/17391/4
Craig Pratt [Tue, 21 Feb 2017 03:41:18 +0000 (19:41 -0800)]
Per CR-47 (doxmtype URN Correction), renamed references to oic.sec.oxm to oic.sec.doxmtype

Signed-off-by: Craig Pratt <craig@ecaspia.com>
Author: Craig Pratt <craig@ecaspia.com>
Change-Id: I97c22125baee550266deb3a17b65f6a185c22006
Reviewed-on: https://gerrit.iotivity.org/gerrit/17391
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
2 years agoInitial plugin "Hue Plugin" for bridging project. 61/16861/20
skambalx [Thu, 23 Feb 2017 12:23:53 +0000 (17:53 +0530)]
Initial plugin "Hue Plugin" for bridging project.

Change-Id: Ia570d82f47d63418433c73adb6cae043264ea48a
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Gaganpreet Kaur <gaganpreetx.kaur@intel.com>
Signed-off-by: skambalx <srikarx.kambaluru@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16861
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years agobuild: Update version to 1.2.1 63/15263/8
Philippe Coval [Thu, 17 Nov 2016 09:41:31 +0000 (10:41 +0100)]
build: Update version to 1.2.1

Change-Id: Ib8994521a91c17d3714d0594d6fbc05e335cd82e
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15263
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoFix null pointer deref. 79/17479/2
Todd Malsbary [Wed, 22 Feb 2017 23:22:56 +0000 (15:22 -0800)]
Fix null pointer deref.

Change-Id: Idf532c330e1a7115036c043e48cd08d3f00b426c
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17479
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoAdd missing limits.h to oicresourcedirectory.c. 29/17429/3
Todd Malsbary [Wed, 22 Feb 2017 17:13:35 +0000 (09:13 -0800)]
Add missing limits.h to oicresourcedirectory.c.

This fixes a build error when built with RD_MODE="CLIENT,SERVER".

Change-Id: I5229d05c49507493a00b1fb5bf1930f9e66e36aa
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17429
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoIOT-1583: Preparing connectivity scons script for /W3 changes (part 1). 67/17367/17
Pawel Winogrodzki [Mon, 20 Feb 2017 08:08:45 +0000 (00:08 -0800)]
IOT-1583: Preparing connectivity scons script for /W3 changes (part 1).

First batch of changes connectivity scons scripts to allow
enabling of /W3 level warnings for the connectivity directory
only.

This change makes sure the connectivity Environment variable
is separated from the global "env", so it only modifies the way
connectivity is built.

Change-Id: I76e9f742bb462b8b9dd6c5c26e07d9c553d70446
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17367
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoexclude internal Discovery when User connection Preference is "CA_USER_PREF_CLOUD" 95/17395/6
jinhyuck83.park [Fri, 24 Feb 2017 01:22:52 +0000 (10:22 +0900)]
exclude internal Discovery when  User connection Preference is "CA_USER_PREF_CLOUD"
with this modification, internal discovery only carry out in case D2D.

Change-Id: If0938186c9c887a2fe67e5a351b2d4b27b4c7e44
Signed-off-by: jinhyuck83.park <jinhyuck83.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17395
Reviewed-by: Jonggyu Ham <jg.ham@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoIOT-1830: Enabling Cbor tests. 73/17373/4
Pawel Winogrodzki [Mon, 20 Feb 2017 09:46:47 +0000 (01:46 -0800)]
IOT-1830: Enabling Cbor tests.

Enabling Cbor tests, so they'll be run during regular builds.

Change-Id: Icdd8fcc83e4a9a32acd7726da8c59f008de99b8e
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17373
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoHandling of missing parent property in collection response 79/15879/22
Jay Sharma [Thu, 22 Dec 2016 00:05:35 +0000 (00:05 +0000)]
Handling of missing parent property in collection response

In case parent is not included in the response. It creates an empty representation.
The first node is not considered parent.

Change-Id: I088a2bdb552cf6b75e67cc2f16fb9150878d717d
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15879
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
2 years agoChange a maximum size of URI format property to 256 octets 57/17457/3
Jihun Ha [Thu, 23 Feb 2017 01:17:18 +0000 (10:17 +0900)]
Change a maximum size of URI format property to 256 octets

As per OCF specification, a normal string-type property without
any statement for maximum length can have a 64 octets size at maximum.
However, for some cases, e.g. a string for URL, one can use longer string
value with a explicit statement of length in its resource model.
Fortunately, url format is already defined in OCF spec. as one of property type,
which can have 256 octets at maximum.

Change-Id: Ia8536ced5f4ab71ccdabd98e9936b00513efaa27
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17457
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoFix functionality of remote service in Notification service. 27/17427/2
KIM JungYong [Wed, 22 Feb 2017 10:52:56 +0000 (19:52 +0900)]
Fix functionality of remote service in Notification service.

Functionality of parsing address is fixed in the consumer service.
When NSConsuemrEnableRemoteService() was called,
address parsing module used fixed for flags(transport type and secured).
And, consumer service was used previous version of prefix("/di")
for using remote service.

In this patch,
1. Whatever tcp or udp and secured or not, using ipv4 or v6,
   address will be parsed effectually.
2. Prefix of Remote service was modified to "/oic/route" from "/di".

Change-Id: I0f20c308e2e4e84cff377e938d010f195177f8bd
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17427
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Jaehong Lee <jaehong2.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
2 years agoIOT-1583: Adding /W4 and /WX to gtest build. 45/17345/5
Pawel Winogrodzki [Fri, 17 Feb 2017 20:51:23 +0000 (12:51 -0800)]
IOT-1583: Adding /W4 and /WX to gtest build.

Making sure any version changes of gtest don't introduce
any level 4 warnings.

Change-Id: I951aee6029d5f48482aea93240f926a82549e5f0
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17345
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
2 years agoInitial plugin "Nest Plugin" for bridging project. 63/16863/12
vijendrx [Thu, 23 Feb 2017 11:33:18 +0000 (17:03 +0530)]
Initial plugin "Nest Plugin" for bridging project.

Change-Id: I79bc33cf7ddf7a6b29c870f0922c5db3d970f6b8
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: vijendrx <vijendrax.kumar@intel.com>
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: vijendrx <vijendrax.kumar@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16863
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years agoInitial plugin "Lyric Plugin" for bridging project. 65/16865/26
Gaganpreet Kaur [Wed, 15 Feb 2017 10:41:15 +0000 (16:11 +0530)]
Initial plugin "Lyric Plugin" for bridging project.

Change-Id: I3bc2ef0bd0d86f0e307a5648a3a252513c694a5d
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Gaganpreet Kaur <gaganpreetx.kaur@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16865
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years agoInitial commit of the Bridging Project's Mini Plugin Manager + 1 plugin. 07/16707/41
Gaganpreet Kaur [Thu, 23 Feb 2017 04:19:48 +0000 (09:49 +0530)]
Initial commit of the Bridging Project's Mini Plugin Manager + 1 plugin.

This commit is comprised of the Mini Plugin Manager framework along with
1 plugin and 1 stubbed plugin. This commit allows a user to test the full
end-to-end story of the MPM.

Change-Id: I3914963442cb175b438c3e3d8ff2d244f8eb339b
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: vijendrx <vijendrax.kumar@intel.com>
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: skambalx <srikarx.kambaluru@intel.com>
Signed-off-by: Gaganpreet Kaur <gaganpreetx.kaur@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16707
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
2 years ago[IOT-1841] Allow OT sessions to post to /pstat 59/17459/5
Dan Mihai [Thu, 23 Feb 2017 01:48:32 +0000 (17:48 -0800)]
[IOT-1841] Allow OT sessions to post to /pstat

Until yesterday, IOT-1831 was hiding IOT-1841, a bug in the
implementation of IOT-1801.

Change-Id: Icada8099f8c4cef9c271db8f672caa55cd63f0f5
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17459
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
2 years agotizen: Revert "tizen: Bump to 1.2.0+RC1" 29/16829/2
Philippe Coval [Fri, 27 Jan 2017 14:39:07 +0000 (15:39 +0100)]
tizen: Revert "tizen: Bump to 1.2.0+RC1"

This reverts commit 3ed2eecfa49256ae1a86d765effff1522b67be63.
https://gerrit.iotivity.org/gerrit/#/c/13515/

Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: Ia58a4f66793506c80f5e7bc5da6e895d00000000
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16829
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>