provisioning: Rename some C++ headers to avoid collision with CSDK ones 99/15099/4
authorPhilippe Coval <philippe.coval@osg.samsung.com>
Thu, 24 Nov 2016 10:20:23 +0000 (11:20 +0100)
committerPhil Coval <philippe.coval@osg.samsung.com>
Thu, 8 Dec 2016 19:27:52 +0000 (19:27 +0000)
The name clash only happens
 on case insensitive filesystems (ie HPFS on MacOS),
 there is ambiguity with C header ie:
  ./resource/csdk/security/provisioning/include/ocprovisioningmanager.h
  ./resource/include/OCProvisioningManager.h

Renaming to .hpp suffix prevent the problem.

Note, one other approach would be to use namespaces

Like:
   #include <iotivity/csdk/ocprovisioningmanager.h> vs
   #include <iotivity/oc/ocprovisioningmanager.h> or similar

Change-Id: Ie311344a98fd056e5b54f329819090a36a901589
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14747
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/14747/3
Reviewed-on: https://gerrit.iotivity.org/gerrit/15099
Reviewed-by: Kevin Kane <kkane@microsoft.com>
20 files changed:
android/android_api/base/jni/JniDisplayPinListener.h
android/android_api/base/jni/JniOcCloudProvisioning.h
android/android_api/base/jni/JniOcProvisioning.h
android/android_api/base/jni/JniOcSecureResource.h
android/android_api/base/jni/JniPinCheckListener.h
android/android_api/base/jni/JniProvisionResultListner.h
android/android_api/base/jni/JniSecureUtils.h
resource/docs/cpp-doc/Doxyfile
resource/include/OCCloudProvisioning.hpp [moved from resource/include/OCCloudProvisioning.h with 100% similarity]
resource/include/OCProvisioningManager.hpp [moved from resource/include/OCProvisioningManager.h with 100% similarity]
resource/provisioning/examples/cloudClient.cpp
resource/provisioning/examples/cloudWrapper.cpp
resource/provisioning/examples/cloudWrapper.h
resource/provisioning/examples/provisioningclient.cpp
resource/provisioning/src/OCCloudProvisioning.cpp
resource/provisioning/src/OCProvisioningManager.cpp
resource/provisioning/unittests/OCCloudProvisioningTest.cpp
resource/provisioning/unittests/OCProvisioningTest.cpp
service/easy-setup/mediator/richsdk/src/EnrolleeSecurity.h
service/easy-setup/sampleapp/mediator/linux/richsdk_sample/mediator_cpp.cpp

index b4fdf9f..b3a3d44 100644 (file)
@@ -19,7 +19,7 @@
 //-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 #include <jni.h>
 #include "JniOcStack.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 #ifndef _Included_org_iotivity_base_DisplayPinListener
 #define _Included_org_iotivity_base_DisplayPinListener
index 58693c7..52edbe2 100644 (file)
@@ -21,7 +21,7 @@
 */
 
 #include "JniOcStack.h"
-#include "OCCloudProvisioning.h"
+#include "OCCloudProvisioning.hpp"
 #include "JniOcCloudResultListener.h"
 #include "JniGetAclIdByDeviceListener.h"
 #include <mutex>
index bad4a8d..9c293fb 100644 (file)
@@ -20,7 +20,7 @@
 * //-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 */
 #include "JniOcStack.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 #include "JniSecureUtils.h"
 #include "oxmjustworks.h"
 #include "oxmrandompin.h"
index 213f20d..55218e6 100644 (file)
@@ -22,7 +22,7 @@
 
 #include "JniOcStack.h"
 #include "JniProvisionResultListner.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 #include <mutex>
 
 #ifndef _Included_org_iotivity_base_OcSecureResource
index 74d150d..988401b 100644 (file)
@@ -21,7 +21,7 @@
 */
 
 #include "JniOcStack.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 #ifndef _Included_org_iotivity_base_PinCheckListener
 #define _Included_org_iotivity_base_PinCheckListener
index 59a0945..d3d4ac6 100644 (file)
@@ -21,7 +21,7 @@
 */
 #include <jni.h>
 #include "JniOcStack.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 #ifndef _Included_org_iotivity_base_OcProvisioning_JniProvisionResultListner
 #define _Included_org_iotivity_base_OcProvisioning_JniProvisionResultListner
index c7226a5..f6d757e 100644 (file)
@@ -21,7 +21,7 @@
 */
 
 #include "JniOcStack.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 class JniSecureUtils
 {
index 964164f..3a6f5ae 100644 (file)
@@ -666,7 +666,7 @@ INPUT                  = . \
                          ../../include/OCResourceRequest.h \
                          ../../include/OCResourceResponse.h \
                          ../../include/OCResource.h \
-                         ../../include/OCProvisioningManager.h \
+                         ../../include/OCProvisioningManager.hpp \
                          ../../csdk/stack/include/octypes.h \
                          ../../csdk/stack/include/ocstackconfig.h \
                          guides \
index 3d67d2d..642fe81 100644 (file)
@@ -33,7 +33,7 @@
 #include "cloudAuth.h"
 #include "cloudWrapper.h"
 #include "OCApi.h"
-#include "OCCloudProvisioning.h"
+#include "OCCloudProvisioning.hpp"
 
 #ifdef __unix__
 #include <unistd.h> //for unlink
index d7be8fb..8a56411 100644 (file)
@@ -22,7 +22,7 @@
 
 #include "logger.h"
 #include "occloudprovisioning.h"
-#include "OCCloudProvisioning.h"
+#include "OCCloudProvisioning.hpp"
 #include "oic_malloc.h"
 #include "oic_string.h"
 #include "utils.h"
index 51e5538..9fb74f6 100644 (file)
@@ -21,7 +21,7 @@
 #define OC_CLOUD_WRAPPER_H
 
 #include "occloudprovisioning.h"
-#include "OCCloudProvisioning.h"
+#include "OCCloudProvisioning.hpp"
 
 using namespace OC;
 /**
index 03cab4b..c843a8f 100644 (file)
@@ -33,7 +33,7 @@
 #include "oic_string.h"
 #include "OCPlatform.h"
 #include "OCApi.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 #include "oxmjustworks.h"
 #include "oxmrandompin.h"
 #include "aclresource.h"
index 2e6d4a8..295704d 100644 (file)
@@ -19,7 +19,7 @@
  * *****************************************************************/
 
 #include "ocstack.h"
-#include "OCCloudProvisioning.h"
+#include "OCCloudProvisioning.hpp"
 
 namespace OC
 {
index 80421c3..6ab5f6b 100644 (file)
@@ -21,7 +21,7 @@
 #include "ocstack.h"
 #include "srmutility.h"
 #include "base64.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 namespace OC
 {
index 81b0ac2..d459277 100755 (executable)
@@ -24,8 +24,8 @@
 #include <OCPlatform_impl.h>
 #include <oxmjustworks.h>
 #include <oxmrandompin.h>
-#include <OCProvisioningManager.h>
-#include "OCCloudProvisioning.h"
+#include <OCProvisioningManager.hpp>
+#include <OCCloudProvisioning.hpp>
 #include <gtest/gtest.h>
 
 #define TIMEOUT 5
index 5642dda..628b3d0 100644 (file)
@@ -25,7 +25,7 @@
 #include <oxmjustworks.h>
 #include <oxmrandompin.h>
 #include <srmutility.h>
-#include <OCProvisioningManager.h>
+#include <OCProvisioningManager.hpp>
 #include <gtest/gtest.h>
 
 #define TIMEOUT 5
index db9fc7b..2e9b3fa 100755 (executable)
@@ -26,7 +26,7 @@
 #include <condition_variable>
 
 #include "ESRichCommon.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 namespace OIC
 {
index 144685d..9452a3e 100755 (executable)
@@ -23,7 +23,7 @@
 
 #include "OCPlatform.h"
 #include "OCApi.h"
-#include "OCProvisioningManager.h"
+#include "OCProvisioningManager.hpp"
 
 #include "EasySetup.h"
 #include "ESRichCommon.h"